Commit 046649b
committed
fix(dashboard): Remove unnecessary reason check from dismiss prevention
Drop eventDetails.reason checks from onOpenChange — as the maintainer
noted, onOpenChange is only called from Base UI's own interactions
(outside-press, escape-key, focus-out), not from our programmatic
setOpen(false) calls. Checking specific reasons would miss focus-out.1 parent a299b57 commit 046649b
2 files changed
Lines changed: 6 additions & 14 deletions
File tree
- packages/dashboard/src
- app/routes/_authenticated/_orders/components
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
107 | 103 | | |
108 | 104 | | |
109 | 105 | | |
| |||
Lines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
244 | 240 | | |
245 | 241 | | |
246 | 242 | | |
| |||
0 commit comments