fix(dashboard): Treat readonly custom fields as optional in Zod schema (#5057)

Readonly custom fields with nullable: false produced an unsatisfiable Zod schema, permanently disabling the Create/Update button. Fixes #5045

Author: Ryrahul

packages/dashboard/src/lib/framework/form-engine/form-schema-tools.spec.ts

@@ -41,6 +41,7 @@ const createMockCustomField = (
         datetimeMax?: string;
         list?: boolean;
         nullable?: boolean;
+        readonly?: boolean;
     } = {},
 ) => ({
     name,
@@ -305,6 +306,53 @@ describe('form-schema-tools', () => {
             expect(() => schema.parse(undefinedData)).not.toThrow();
         });
 
+        // Readonly custom fields with nullable: false should not block form submission.
+        // The server excludes readonly fields from Create/Update GraphQL input types,
+        // and the dashboard strips them from the mutation payload before submitting.
+        // So the Zod schema must treat them as optional.
+        it('should treat readonly custom fields as optional even when nullable is false', () => {
+            const fields = [createMockField('customFields', 'Object', false, false, [])];
+            const customFields = [
+                createMockCustomField('type', 'string', { nullable: false, readonly: true }),
+            ];
+
+            const schema = createFormSchemaFromFields(fields, customFields, false);
+
+            // Should accept null/undefined since readonly fields cannot be submitted
+            const nullData = { customFields: { type: null } };
+            expect(() => schema.parse(nullData)).not.toThrow();
+
+            const undefinedData = { customFields: { type: undefined } };
+            expect(() => schema.parse(undefinedData)).not.toThrow();
+
+            const emptyData = { customFields: {} };
+            expect(() => schema.parse(emptyData)).not.toThrow();
+
+            // Should still accept a value if one happens to be present
+            const withValue = { customFields: { type: 'manually-created' } };
+            expect(() => schema.parse(withValue)).not.toThrow();
+        });
+
+        // Guards against the readonly fix accidentally making every field optional.
+        // A plain nullable: false field (no readonly) must still reject null/undefined.
+        it('should reject null/undefined for non-readonly custom fields with nullable false', () => {
+            const fields = [createMockField('customFields', 'Object', false, false, [])];
+            const customFields = [
+                createMockCustomField('sku', 'string', { nullable: false }),
+            ];
+
+            const schema = createFormSchemaFromFields(fields, customFields, false);
+
+            const validData = { customFields: { sku: 'AB-123' } };
+            expect(() => schema.parse(validData)).not.toThrow();
+
+            const nullData = { customFields: { sku: null } };
+            expect(() => schema.parse(nullData)).toThrow();
+
+            const undefinedData = { customFields: { sku: undefined } };
+            expect(() => schema.parse(undefinedData)).toThrow();
+        });
+
         it('should only include non-translatable fields in root context', () => {
             const fields = [createMockField('customFields', 'Object', false, false, [])];
             const customFields = [

packages/dashboard/src/lib/framework/form-engine/form-schema-tools.ts

@@ -257,7 +257,7 @@ function applyCustomFieldModifiers(zodType: ZodType, customField: CustomFieldCon
     if (customField.list) {
         modifiedType = z.array(modifiedType);
     }
-    if (customField.nullable !== false) {
+    if (customField.nullable !== false || customField.readonly) {
         modifiedType = modifiedType.optional().nullable();
     }
     if (customField.readonly) {