refactor(core): Share the CustomFieldsInput type-name suffix

The '*CustomFieldsInput' naming convention was a literal in both the schema generation
and the interceptor's schema-driven discovery. Extract it to a single exported constant
so the two sides cannot drift apart on a rename.

Relates to #2648

Author: michaelbromley

packages/core/src/api/config/graphql-custom-fields.ts

@@ -11,6 +11,7 @@ import {
 
 import {
     BaseTypedCustomFieldConfig,
+    CUSTOM_FIELDS_INPUT_TYPE_SUFFIX,
     CustomFieldConfig,
     CustomFields,
     isNonListRelationCustomField,
@@ -163,7 +164,7 @@ export function addGraphQLCustomFields(
 
         if (hasCreateInputType) {
             if (writeableNonLocalizedFields.length) {
-                const createCustomFieldsInputType = `Create${entityName}CustomFieldsInput`;
+                const createCustomFieldsInputType = `Create${entityName}${CUSTOM_FIELDS_INPUT_TYPE_SUFFIX}`;
                 if (!schema.getType(createCustomFieldsInputType)) {
                     customFieldTypeDefs += `
                         input ${createCustomFieldsInputType} {
@@ -201,7 +202,7 @@ export function addGraphQLCustomFields(
 
         if (hasUpdateInputType) {
             if (writeableNonLocalizedFields.length) {
-                const updateCustomFieldsInputType = `Update${entityName}CustomFieldsInput`;
+                const updateCustomFieldsInputType = `Update${entityName}${CUSTOM_FIELDS_INPUT_TYPE_SUFFIX}`;
                 if (!schema.getType(updateCustomFieldsInputType)) {
                     customFieldTypeDefs += `
                         input ${updateCustomFieldsInputType} {

packages/core/src/api/middleware/custom-field-processing-interceptor.ts

@@ -19,7 +19,11 @@ import {
 import { UserInputError } from '../../common/error/errors';
 import { Injector } from '../../common/injector';
 import { ConfigService } from '../../config/config.service';
-import { CustomFieldConfig, CustomFields } from '../../config/custom-field/custom-field-types';
+import {
+    CUSTOM_FIELDS_INPUT_TYPE_SUFFIX,
+    CustomFieldConfig,
+    CustomFields,
+} from '../../config/custom-field/custom-field-types';
 import { parseContext } from '../common/parse-context';
 import { internal_getRequestContext, RequestContext } from '../common/request-context';
 import { validateCustomFieldValue } from '../common/validate-custom-field-value';
@@ -216,7 +220,7 @@ export class CustomFieldProcessingInterceptor implements NestInterceptor {
             return cached;
         }
         const map = new Map<string, Set<string>>();
-        const suffix = 'CustomFieldsInput';
+        const suffix = CUSTOM_FIELDS_INPUT_TYPE_SUFFIX;
         const entityNames = (Object.keys(this.configService.customFields) as Array<keyof CustomFields>).sort(
             (a, b) => (b as string).length - (a as string).length,
         );

packages/core/src/config/custom-field/custom-field-types.ts

@@ -33,6 +33,14 @@ import { RequestContext } from '../../api/common/request-context';
 import { Injector } from '../../common/injector';
 import { VendureEntity } from '../../entity/base/base.entity';
 
+/**
+ * The suffix of every generated GraphQL input type that carries an entity's custom fields, e.g.
+ * `UpdateProductCustomFieldsInput`. It is the single source of this naming convention, shared by the
+ * schema generation (which produces these types) and the custom-field processing interceptor (which
+ * discovers them). If this changes, both sides change together.
+ */
+export const CUSTOM_FIELDS_INPUT_TYPE_SUFFIX = 'CustomFieldsInput';
+
 // prettier-ignore
 export type DefaultValueType<T extends CustomFieldType | StructFieldType> =
     T extends 'string' | 'localeString' | 'text' | 'localeText' ? string :