fix(dashboard): Activate fallback locale before extensions by dlhck · Pull Request #5061 · vendurehq/vendure

dlhck · 2026-07-30T07:29:30Z

Description

Fixes a dashboard startup race where extensions could call Lingui translation functions before the asynchronous default catalog activated a locale. The source locale now activates synchronously with an empty catalog while the compiled dashboard and plugin catalogs continue loading in parallel, and a regression test covers extension evaluation during that window.

Breaking changes

No.

Screenshots

Not applicable.

Checklist

📌 Always:

I have set a clear title
My PR is small and contains a single feature
I have checked my own PR

👍 Most of the time:

I have added or updated test cases
I have updated the README if needed

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

vercel · 2026-07-30T07:29:36Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
vendure-storybook	Ready	Preview	Jul 30, 2026 7:51am

coderabbitai · 2026-07-30T07:29:37Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fa7f7660-3488-4a8e-b102-70c85143c1a9

📥 Commits

Reviewing files that changed from the base of the PR and between 190ef65 and ec428c3.

📒 Files selected for processing (1)

docs/manifest.json

📝 Walkthrough

Walkthrough

The i18n provider synchronously loads and activates an empty catalog for defaultLocale. A new test mocks dashboard extension execution and verifies that early translation evaluation completes without errors while the default locale remains active. The Vite plugin documentation updates generated source metadata, expands tempCompilationDir guidance, and refreshes its modification timestamp.

Possibly related PRs

vendurehq/vendure#4600: Adds related coverage for useDashboardExtensions and extension loading behavior.

Suggested reviewers: michaelbromley

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and clearly matches the main change: synchronizing the fallback locale before extensions run.
Description check	✅ Passed	The description follows the template and includes the change summary, breaking changes, screenshots, and checklist; only the related issue is not linked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-dashboard-lingui-race

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-30T07:33:33Z

Dashboard Preview: https://admin-dashboard-8c1ykyc1n-vendure.vercel.app

Dashboard extensions can evaluate translation calls before the asynchronous default catalog finishes loading. Activate an empty source-locale catalog synchronously so extension imports and compiled catalog loading remain parallel without triggering Lingui's missing-locale error.

vendure-developer-hub · 2026-07-30T07:46:16Z

~~Docs preview~~ — PR merged

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/docs/reference/dashboard/vite-plugin/vendure-dashboard-plugin.mdx`:
- Line 7: Update the source JSDoc in the `vendureDashboardPlugin` implementation
within `vite-plugin-vendure-dashboard.ts`, including the metadata and
`tempCompilationDir` documentation, rather than editing generated reference
output. Regenerate the reference documentation so the corresponding changes
appear under `docs/docs/reference/`.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c04df112-80e0-463c-abe3-94071ede3d77

📥 Commits

Reviewing files that changed from the base of the PR and between b0ebd3d and 190ef65.

📒 Files selected for processing (1)

docs/docs/reference/dashboard/vite-plugin/vendure-dashboard-plugin.mdx

coderabbitai · 2026-07-30T07:48:33Z

 ## vendureDashboardPlugin

-<GenerationInfo sourceFile="packages/dashboard/vite/vite-plugin-vendure-dashboard.ts" sourceLine="242" packageName="@vendure/dashboard" since="3.4.0" />
+<GenerationInfo sourceFile="packages/dashboard/vite/vite-plugin-vendure-dashboard.ts" sourceLine="254" packageName="@vendure/dashboard" since="3.4.0" />


📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Update the source JSDoc instead of editing generated reference output.

This file is auto-generated, so these metadata and tempCompilationDir documentation changes will be overwritten. Apply the documentation changes in packages/dashboard/vite/vite-plugin-vendure-dashboard.ts and regenerate the reference docs.

As per path instructions, docs/docs/reference/**: Do not edit files in docs/docs/reference/ directly - they are auto-generated by scripts and will be overwritten.

Also applies to: 26-26, 88-98

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/docs/reference/dashboard/vite-plugin/vendure-dashboard-plugin.mdx` at line 7, Update the source JSDoc in the `vendureDashboardPlugin` implementation within `vite-plugin-vendure-dashboard.ts`, including the metadata and `tempCompilationDir` documentation, rather than editing generated reference output. Regenerate the reference documentation so the corresponding changes appear under `docs/docs/reference/`.

Source: Path instructions

sonarqubecloud · 2026-07-30T07:54:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vercel Bot deployed to Preview July 30, 2026 07:31 View deployment

dlhck changed the title ~~fix(dashboard): activate fallback locale before extensions~~ fix(dashboard): Activate fallback locale before extensions Jul 30, 2026

dlhck marked this pull request as ready for review July 30, 2026 07:38

dlhck changed the base branch from minor to master July 30, 2026 07:38

dlhck requested a review from michaelbromley as a code owner July 30, 2026 07:38

dlhck force-pushed the fix-dashboard-lingui-race branch from 0a91230 to b0ebd3d Compare July 30, 2026 07:42

vercel Bot deployed to Preview July 30, 2026 07:44 View deployment

michaelbromley approved these changes Jul 30, 2026

View reviewed changes

michaelbromley enabled auto-merge (squash) July 30, 2026 07:44

docs: update line numbers and add tempCompilationDir option details

190ef65

vercel Bot deployed to Preview July 30, 2026 07:47 View deployment

coderabbitai Bot reviewed Jul 30, 2026

View reviewed changes

docs: Regenerate manifest.json

ec428c3

vercel Bot deployed to Preview July 30, 2026 07:51 View deployment

dlhck disabled auto-merge July 30, 2026 08:08

dlhck merged commit aaa2eb0 into master Jul 30, 2026
38 checks passed

dlhck deleted the fix-dashboard-lingui-race branch July 30, 2026 08:08

vendure-ci-automation-bot Bot locked and limited conversation to collaborators Jul 30, 2026

Navigation Menu

Uh oh!

fix(dashboard): Activate fallback locale before extensions - #5061

fix(dashboard): Activate fallback locale before extensions#5061
dlhck merged 3 commits into
masterfrom
fix-dashboard-lingui-race

dlhck commented Jul 30, 2026 •

edited by blacksmith-sh Bot

Loading

Uh oh!

vercel Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Walkthrough

Uh oh!

github-actions Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

vendure-developer-hub Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 30, 2026

Uh oh!

sonarqubecloud Bot commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dlhck commented Jul 30, 2026 • edited by blacksmith-sh Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Breaking changes

Screenshots

Checklist

Uh oh!

vercel Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vendure-developer-hub Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 30, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dlhck commented Jul 30, 2026 •

edited by blacksmith-sh Bot

Loading

vercel Bot commented Jul 30, 2026 •

edited

Loading

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

github-actions Bot commented Jul 30, 2026 •

edited

Loading

vendure-developer-hub Bot commented Jul 30, 2026 •

edited

Loading