Skip to content

Inconsistencies in vercel-composition-patterns and vercel-react-best-practices skills #286

Description

@jason-ezenwa

The following inconsistencies/bugs were confirmed by a fresh npx skills add vercel-labs/agent-skills install. All are present in the downloaded files before any local modification.


1 — vercel-composition-patterns: broken example code in state-lift-state.md

Files: skills/vercel-composition-patterns/rules/state-lift-state.md (line 114), AGENTS.md (line 681)

The "Correct" example references Composer.Context:

const { actions } = use(Composer.Context)

Composer is a compound component object ({ Provider, Frame, Input, … }) — it has no .Context property. The correct reference, consistent with state-context-interface.md and every other usage in the skill, is:

const { actions } = use(ComposerContext)

2 — vercel-composition-patterns: impact level conflict on Component Architecture section

Files: rules/architecture-avoid-boolean-props.md, SKILL.md, rules/_sections.md

Three sources disagree on the impact of the Component Architecture section:

  • architecture-avoid-boolean-props.md frontmatter: impact: CRITICAL
  • SKILL.md Quick Reference table: HIGH
  • rules/_sections.md: HIGH

One of these needs to be the authority — currently an agent reading any two of these files gets conflicting signals.


3 — vercel-react-best-practices: stale Quick Reference description for js-batch-dom-css

File: skills/vercel-react-best-practices/SKILL.md (line 110)

Quick Reference says:

js-batch-dom-css - Group CSS changes via classes or cssText

The rule file title is "Avoid Layout Thrashing" with a substantively different scope. The description was not updated when the rule was renamed/revised.


4 — vercel-react-best-practices: stale Quick Reference description for advanced-use-latest

File: skills/vercel-react-best-practices/SKILL.md (line 130)

Quick Reference says:

advanced-use-latest - useLatest for stable callback refs

The rule file title is now "useEffectEvent for Stable Callback Refs" and the implementation has changed. Description is stale.


5 — vercel-react-best-practices: invalid YAML frontmatter in rerender-memo-with-default-value.md

File: skills/vercel-react-best-practices/rules/rerender-memo-with-default-value.md

The frontmatter block contains leading and trailing blank lines inside the --- delimiters, which breaks strict YAML parsers:

---

title: Extract Default Non-primitive Parameter Value...
impact: MEDIUM
...

---

Every other rule file in both skills uses tightly-packed frontmatter with no interior blank lines.


Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions