[Scatter-Gather] Add inline to enum-string maps

Using inline variables make sure the data in the map is not duplicated when including the header file in multiple headers. This C++17 feature was explicitly added to facilitate this usecase (defining const variables in header files.)

Author: AmirhosseinPoolad

libs/libarchfpga/src/scatter_gather_types.h

@@ -19,8 +19,8 @@ enum class e_scatter_gather_type {
  * 
  */
 struct t_sg_location {
-    e_sb_location type; ///< Type of locations that the pattern is instantiated at.
-    int num; ///< Number of scatter-gather pattern instantiations per location.
+    e_sb_location type;       ///< Type of locations that the pattern is instantiated at.
+    int num;                  ///< Number of scatter-gather pattern instantiations per location.
     std::string sg_link_name; ///< Name of scatter-gather link to be used.
 };
 

libs/libarchfpga/src/switchblock_types.h

@@ -31,7 +31,7 @@ enum e_side : unsigned char {
     NUM_3D_SIDES = 6,
 };
 
-const std::unordered_map<char, e_side> CHAR_SIDE_MAP = {
+inline const std::unordered_map<char, e_side> CHAR_SIDE_MAP = {
     {'T', TOP},
     {'t', TOP},
     {'R', RIGHT},
@@ -64,12 +64,12 @@ enum class e_sb_location {
     E_XY_SPECIFIED
 };
 
-const std::unordered_map<std::string, e_sb_location> SB_LOCATION_STRING_MAP = {{"EVERYWHERE", e_sb_location::E_EVERYWHERE},
-                                                                               {"PERIMETER", e_sb_location::E_PERIMETER},
-                                                                               {"CORE", e_sb_location::E_CORE},
-                                                                               {"CORNER", e_sb_location::E_CORNER},
-                                                                               {"FRINGE", e_sb_location::E_FRINGE},
-                                                                               {"XY_SPECIFIED", e_sb_location::E_XY_SPECIFIED}};
+inline const std::unordered_map<std::string, e_sb_location> SB_LOCATION_STRING_MAP = {{"EVERYWHERE", e_sb_location::E_EVERYWHERE},
+                                                                                      {"PERIMETER", e_sb_location::E_PERIMETER},
+                                                                                      {"CORE", e_sb_location::E_CORE},
+                                                                                      {"CORNER", e_sb_location::E_CORNER},
+                                                                                      {"FRINGE", e_sb_location::E_FRINGE},
+                                                                                      {"XY_SPECIFIED", e_sb_location::E_XY_SPECIFIED}};
 
 /**
  * @brief Describes regions that a specific switch block specifications should be applied to