Skip to content

Commit dbd208c

Browse files
authored
Simplify atomic function passthroughs (#2601)
1 parent 31b2376 commit dbd208c

1 file changed

Lines changed: 21 additions & 27 deletions

File tree

source/vstd/atomic.rs

Lines changed: 21 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ macro_rules! atomic_common_methods {
171171
opens_invariants none
172172
no_unwind
173173
{
174-
return self.ato.load(Ordering::SeqCst);
174+
self.ato.load(Ordering::SeqCst)
175175
}
176176

177177
#[inline(always)]
@@ -184,7 +184,7 @@ macro_rules! atomic_common_methods {
184184
opens_invariants none
185185
no_unwind
186186
{
187-
self.ato.store(v, Ordering::SeqCst);
187+
self.ato.store(v, Ordering::SeqCst)
188188
}
189189

190190
#[inline(always)]
@@ -208,10 +208,7 @@ macro_rules! atomic_common_methods {
208208
opens_invariants none
209209
no_unwind
210210
{
211-
match self.ato.compare_exchange(current, new, Ordering::SeqCst, Ordering::SeqCst) {
212-
Ok(x) => Result::Ok(x),
213-
Err(x) => Result::Err(x),
214-
}
211+
self.ato.compare_exchange(current, new, Ordering::SeqCst, Ordering::SeqCst)
215212
}
216213

217214
#[inline(always)]
@@ -234,10 +231,7 @@ macro_rules! atomic_common_methods {
234231
opens_invariants none
235232
no_unwind
236233
{
237-
match self.ato.compare_exchange_weak(current, new, Ordering::SeqCst, Ordering::SeqCst) {
238-
Ok(x) => Result::Ok(x),
239-
Err(x) => Result::Err(x),
240-
}
234+
self.ato.compare_exchange_weak(current, new, Ordering::SeqCst, Ordering::SeqCst)
241235
}
242236

243237
#[inline(always)]
@@ -253,7 +247,7 @@ macro_rules! atomic_common_methods {
253247
opens_invariants none
254248
no_unwind
255249
{
256-
return self.ato.swap(v, Ordering::SeqCst);
250+
self.ato.swap(v, Ordering::SeqCst)
257251
}
258252

259253
#[inline(always)]
@@ -265,7 +259,7 @@ macro_rules! atomic_common_methods {
265259
opens_invariants none
266260
no_unwind
267261
{
268-
return self.ato.into_inner();
262+
self.ato.into_inner()
269263
}
270264

271265
}
@@ -291,7 +285,7 @@ macro_rules! atomic_integer_methods {
291285
opens_invariants none
292286
no_unwind
293287
{
294-
return self.ato.fetch_add(n, Ordering::SeqCst);
288+
self.ato.fetch_add(n, Ordering::SeqCst)
295289
}
296290

297291
#[inline(always)]
@@ -306,7 +300,7 @@ macro_rules! atomic_integer_methods {
306300
opens_invariants none
307301
no_unwind
308302
{
309-
return self.ato.fetch_sub(n, Ordering::SeqCst);
303+
self.ato.fetch_sub(n, Ordering::SeqCst)
310304
}
311305

312306
// fetch_add and fetch_sub are more natural in the common case that you
@@ -358,7 +352,7 @@ macro_rules! atomic_integer_methods {
358352
opens_invariants none
359353
no_unwind
360354
{
361-
return self.ato.fetch_and(n, Ordering::SeqCst);
355+
self.ato.fetch_and(n, Ordering::SeqCst)
362356
}
363357

364358
#[inline(always)]
@@ -373,7 +367,7 @@ macro_rules! atomic_integer_methods {
373367
opens_invariants none
374368
no_unwind
375369
{
376-
return self.ato.fetch_or(n, Ordering::SeqCst);
370+
self.ato.fetch_or(n, Ordering::SeqCst)
377371
}
378372

379373
#[inline(always)]
@@ -388,7 +382,7 @@ macro_rules! atomic_integer_methods {
388382
opens_invariants none
389383
no_unwind
390384
{
391-
return self.ato.fetch_xor(n, Ordering::SeqCst);
385+
self.ato.fetch_xor(n, Ordering::SeqCst)
392386
}
393387

394388
#[inline(always)]
@@ -403,7 +397,7 @@ macro_rules! atomic_integer_methods {
403397
opens_invariants none
404398
no_unwind
405399
{
406-
return self.ato.fetch_nand(n, Ordering::SeqCst);
400+
self.ato.fetch_nand(n, Ordering::SeqCst)
407401
}
408402

409403
#[inline(always)]
@@ -418,7 +412,7 @@ macro_rules! atomic_integer_methods {
418412
opens_invariants none
419413
no_unwind
420414
{
421-
return self.ato.fetch_max(n, Ordering::SeqCst);
415+
self.ato.fetch_max(n, Ordering::SeqCst)
422416
}
423417

424418
#[inline(always)]
@@ -433,7 +427,7 @@ macro_rules! atomic_integer_methods {
433427
opens_invariants none
434428
no_unwind
435429
{
436-
return self.ato.fetch_min(n, Ordering::SeqCst);
430+
self.ato.fetch_min(n, Ordering::SeqCst)
437431
}
438432

439433
}
@@ -457,7 +451,7 @@ macro_rules! atomic_bool_methods {
457451
opens_invariants none
458452
no_unwind
459453
{
460-
return self.ato.fetch_and(n, Ordering::SeqCst);
454+
self.ato.fetch_and(n, Ordering::SeqCst)
461455
}
462456

463457
#[inline(always)]
@@ -473,7 +467,7 @@ macro_rules! atomic_bool_methods {
473467
opens_invariants none
474468
no_unwind
475469
{
476-
return self.ato.fetch_or(n, Ordering::SeqCst);
470+
self.ato.fetch_or(n, Ordering::SeqCst)
477471
}
478472

479473
#[inline(always)]
@@ -489,7 +483,7 @@ macro_rules! atomic_bool_methods {
489483
opens_invariants none
490484
no_unwind
491485
{
492-
return self.ato.fetch_xor(n, Ordering::SeqCst);
486+
self.ato.fetch_xor(n, Ordering::SeqCst)
493487
}
494488

495489
#[inline(always)]
@@ -505,7 +499,7 @@ macro_rules! atomic_bool_methods {
505499
opens_invariants none
506500
no_unwind
507501
{
508-
return self.ato.fetch_nand(n, Ordering::SeqCst);
502+
self.ato.fetch_nand(n, Ordering::SeqCst)
509503
}
510504

511505
}
@@ -620,7 +614,7 @@ impl<T> PAtomicPtr<T> {
620614
opens_invariants none
621615
no_unwind
622616
{
623-
return self.ato.fetch_and(n, Ordering::SeqCst);
617+
self.ato.fetch_and(n, Ordering::SeqCst)
624618
}
625619

626620
#[inline(always)]
@@ -640,7 +634,7 @@ impl<T> PAtomicPtr<T> {
640634
opens_invariants none
641635
no_unwind
642636
{
643-
return self.ato.fetch_xor(n, Ordering::SeqCst);
637+
self.ato.fetch_xor(n, Ordering::SeqCst)
644638
}
645639

646640
#[inline(always)]
@@ -659,7 +653,7 @@ impl<T> PAtomicPtr<T> {
659653
opens_invariants none
660654
no_unwind
661655
{
662-
return self.ato.fetch_or(n, Ordering::SeqCst);
656+
self.ato.fetch_or(n, Ordering::SeqCst)
663657
}
664658
}
665659

0 commit comments

Comments
 (0)