fix(glance_image): use common role for image updates (#3862)

Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mnaser <435815+mnaser@users.noreply.github.com>
Co-authored-by: Mohammed Naser <mnaser@vexxhost.com>
Co-authored-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Co-authored-by: Copilot <copilot@github.com>

Author: 4 people

galaxy.yml

@@ -17,7 +17,7 @@ dependencies:
   kubernetes.core: 2.4.0
   openstack.cloud: ">=2.0.0"
   vexxhost.ceph: ">=3.2.0"
-  atmosphere.common: ">=0.6.0"
+  atmosphere.common: ">=0.7.0"
   vexxhost.kubernetes: ">=2.5.0"
 tags:
   - application

releasenotes/notes/fix-glance-image-update-on-change-849b9af67e04e180.yaml

@@ -0,0 +1,9 @@
+---
+fixes:
+  - |
+    Use the ``atmosphere.common.glance_image`` role from
+    ``atmosphere.common`` 0.7.0 instead of Atmosphere's local copy. This
+    keeps Glance image uploads in sync with source address and HTTP ``ETag``
+    changes while preserving the safer upload-before-rename behavior for
+    replacing outdated service images. Atmosphere also removes the unused
+    local ``qemu_utils`` role because the common role now handles QEMU tooling.

roles/glance/tasks/main.yml

@@ -38,7 +38,7 @@
 
 - name: Create images
   ansible.builtin.include_role:
-    name: glance_image
+    name: atmosphere.common.glance_image
   loop: "{{ glance_images }}"
   vars:
     glance_image_name: "{{ item.name }}"
@@ -47,7 +47,7 @@
     glance_image_min_ram: "{{ item.min_ram | default(omit) }}"
     glance_image_container_format: "{{ item.container_format | default(omit) }}"
     glance_image_disk_format: "{{ item.disk_format | default(omit) }}"
-    glance_image_properties: "{{ item.properties | default(omit) }}"
+    glance_image_properties: "{{ item.properties | default({}) }}"
     glance_image_kernel: "{{ item.kernel | default(omit) }}"
     glance_image_ramdisk: "{{ item.ramdisk | default(omit) }}"
     glance_image_is_public: "{{ item.is_public | default(omit) }}"

roles/glance_image/README.md

@@ -48,7 +48,7 @@
 
 - name: Upload images
   ansible.builtin.include_role:
-    name: glance_image
+    name: atmosphere.common.glance_image
   loop:
     - name: "{{ ironic_python_agent_deploy_kernel_name }}"
       url: "{{ ironic_python_agent_deploy_kernel_url }}"

roles/glance_image/defaults/main.yml

@@ -209,7 +209,7 @@
 
 - name: Upload images
   ansible.builtin.include_role:
-    name: glance_image
+    name: atmosphere.common.glance_image
   loop: "{{ magnum_images }}"
   vars:
     glance_image_name: "{{ item.name }}"

roles/glance_image/meta/main.yml

@@ -35,7 +35,7 @@ manila_flavor_extra_specs: {}
 
 # Service instance image
 manila_image_name: manila-service-image
-manila_image_url: "https://object-storage.public.mtl1.vexxhost.net/swift/v1/b98c5fdfb9be4e39a34b93d0b425ac2b/atmosphere-images/manila-{{ atmosphere_version | regex_replace('-beta.','b') }}.qcow2" # noqa yaml[line-length]
+manila_image_url: https://github.com/vexxhost/manila-service-images/releases/download/2026.05-3/manila-service-image.qcow2
 manila_image_container_format: bare
 manila_image_disk_format: qcow2