Merge branch 'netdata:master' into master

Author: vhbui02

.github/PULL_REQUEST_TEMPLATE.md

@@ -6,6 +6,8 @@ Include "Fixes #nnn" if you are fixing an existing issue.
 
 ##### Test Plan
 
+- [ ] AI-generated or AI-assisted content has been manually verified (examples/instructions tested where applicable).
+
 <!--
 Provide enough detail so that your reviewer can understand which test cases you
 have covered, and recreate them if necessary. If our CI covers sufficient tests, then state which tests cover the change.

.github/data/distros.yml

@@ -216,7 +216,7 @@ include:
 
   - &fedora
     distro: fedora
-    version: "43"
+    version: "44"
     support_type: Core
     notes: ''
     eol_check: true
@@ -225,13 +225,20 @@ include:
       dnf remove -y json-c-devel
     packages: &fedora_packages
       type: rpm
-      repo_distro: fedora/43
+      repo_distro: fedora/44
       builder_rev: *def_builder_rev
       arches:
         - x86_64
         - aarch64
     test:
       ebpf-core: true
+  - <<: *fedora
+    version: "43"
+    packages:
+      <<: *fedora_packages
+      repo_distro: fedora/43
+    test:
+      ebpf-core: true
   - <<: *fedora
     version: "42"
     packages:
@@ -356,7 +363,7 @@ include:
 
   - &ubuntu
     distro: ubuntu
-    version: "24.04"
+    version: "26.04"
     support_type: Core
     notes: ''
     eol_check: true
@@ -369,7 +376,7 @@ include:
       apt-get remove -y libjson-c-dev
     packages: &ubuntu_packages
       type: deb
-      repo_distro: ubuntu/noble
+      repo_distro: ubuntu/resolute
       builder_rev: v2
       arches:
         - amd64
@@ -383,20 +390,15 @@ include:
       <<: *ubuntu_packages
       repo_distro: ubuntu/questing
   - <<: *ubuntu
-    version: "25.04"
+    version: "24.04"
     packages:
       <<: *ubuntu_packages
-      repo_distro: ubuntu/plucky
+      repo_distro: ubuntu/noble
   - <<: *ubuntu
     version: "22.04"
     packages:
       <<: *ubuntu_packages
       repo_distro: ubuntu/jammy
-  - <<: *ubuntu
-    version: "20.04"
-    packages:
-      <<: *ubuntu_packages
-      repo_distro: ubuntu/focal
 legacy: # Info for platforms we used to support and still need to handle packages for
   - <<: *debian
     version: "10"
@@ -461,6 +463,16 @@ legacy: # Info for platforms we used to support and still need to handle package
     packages:
       <<: *ubuntu_packages
       repo_distro: ubuntu/oracular
+  - <<: *ubuntu
+    version: "25.04"
+    packages:
+      <<: *ubuntu_packages
+      repo_distro: ubuntu/plucky
+  - <<: *ubuntu
+    version: "20.04"
+    packages:
+      <<: *ubuntu_packages
+      repo_distro: ubuntu/focal
 no_include: # Info for platforms not covered in CI
   - distro: docker
     version: "19.03 or newer"

.github/scripts/gen-matrix-packaging.py

@@ -5,7 +5,7 @@
 
 from ruamel.yaml import YAML
 
-ALWAYS_RUN_ARCHES = ["amd64", "x86_64"]
+ALWAYS_RUN_ARCHES = ["amd64", "x86_64", 'i386', 'armhf', 'aarch64', 'arm64']
 SHORT_RUN = sys.argv[1]
 yaml = YAML(typ='safe')
 entries = list()

.github/scripts/prep-ibm-mq-libs.sh

@@ -0,0 +1,55 @@
+#!/bin/bash
+
+set -euo pipefail
+
+url="$(cat packaging/vendor/ibm_mq.url)"
+sha256="$(cat packaging/vendor/ibm_mq.sha256)"
+file="${url##*/}"
+cache_dir="artifacts/cache"
+tmp_dir="tmp"
+hash_path="${tmp_dir}/hash"
+dl_path="${tmp_dir}/${file}"
+cache_path="${cache_dir}/${file}"
+extract_path="${tmp_dir}/ibm_mq"
+need_to_fetch=1
+
+rm -rf "${extract_path}"
+mkdir -p "${tmp_dir}" "${cache_dir}" "${extract_path}"
+
+hash_valid() {
+    local path="${1}"
+    echo "${sha256}  ${path}" > "${hash_path}"
+    if sha256sum -c "${hash_path}"; then
+        return 0
+    else
+        return 1
+    fi
+}
+
+if [ -f "${cache_path}" ]; then
+    if ! hash_valid "${cache_path}" ; then
+        rm -f "${cache_path}"
+    else
+        need_to_fetch=0
+    fi
+fi
+
+if [ "${need_to_fetch}" -eq 1 ]; then
+    rm -f "${dl_path}"
+    curl --output "${dl_path}" \
+         --fail \
+         --location \
+         --max-time 300 \
+         --connect-timeout 90 \
+         --retry 5 \
+         --retry-all-errors \
+         --retry-delay 90 \
+         --remote-time \
+         "${url}"
+
+    hash_valid "${dl_path}"
+
+    cp "${dl_path}" "${cache_path}"
+fi
+
+tar -xvzf "${cache_path}" -C "${extract_path}"

.github/scripts/windows-linker-check.ps1

@@ -0,0 +1,32 @@
+#Requires -Version 4.0
+
+$ErrorActionPreference = "Stop"
+
+$ndPath = "C:\Program Files\Netdata\usr\bin\netdata.exe"
+$lddPath = "C:\Program Files\Netdata\usr\bin\ldd.exe"
+
+if (Test-Path -Path $ndPath) {
+    Write-Output "$ndPath found, attempting to check linking"
+
+    if (Test-Path -Path $lddPath) {
+        & $lddPath $ndPath | Tee-Object -Variable lddResult
+
+        if ($LastExitCode -ne 0) {
+            Write-Output "Exit Code: $LastExitCode"
+            exit 1
+        }
+
+        if ($lddResult -match 'missing|not found') {
+            Write-Output "Libraries missing from install"
+            exit 1
+        } else {
+            Write-Output "Linking OK"
+        }
+    } else {
+        Write-Output "$lddPath not found, unable to check linking"
+        exit 2
+    }
+} else {
+    Write-Output "$ndPath does not exist"
+    exit 1
+}

.github/workflows/build.yml

@@ -182,7 +182,7 @@ jobs:
       - name: Store
         id: store
         if: needs.file-check.outputs.run == 'true'
-        uses: actions/upload-artifact@v6.0.0
+        uses: actions/upload-artifact@v7.0.0
         with:
           name: dist-tarball
           path: artifacts/*.tar.gz
@@ -313,7 +313,7 @@ jobs:
       - name: Store
         id: store
         if: needs.file-check.outputs.run == 'true'
-        uses: actions/upload-artifact@v6.0.0
+        uses: actions/upload-artifact@v7.0.0
         with:
           name: dist-static-${{ matrix.arch }}
           path: artifacts/*.gz.run
@@ -380,13 +380,13 @@ jobs:
       - name: Sign Agent Code
         id: sign-agent
         if: needs.file-check.outputs.run == 'true' && github.event_name != 'pull_request'
-        uses: azure/trusted-signing-action@v0.5.11
+        uses: azure/artifact-signing-action@v1.1.0
         with:
           azure-tenant-id: ${{ secrets.CODE_SIGNING_TENNANT_ID }}
           azure-client-id: ${{ secrets.CODE_SIGNING_CLIENT_ID }}
           azure-client-secret: ${{ secrets.CODE_SIGNING_CLIENT_SECRET }}
           endpoint: "https://eus.codesigning.azure.net/"
-          trusted-signing-account-name: Netdata
+          signing-account-name: Netdata
           certificate-profile-name: Netdata
           files-folder: ${{ github.workspace }}\build
           files-folder-filter: exe,dll,sys
@@ -403,13 +403,13 @@ jobs:
       - name: Sign Installer
         id: sign-installer
         if: needs.file-check.outputs.run == 'true' && github.event_name != 'pull_request'
-        uses: azure/trusted-signing-action@v0.5.11
+        uses: azure/artifact-signing-action@v1.1.0
         with:
           azure-tenant-id: ${{ secrets.CODE_SIGNING_TENNANT_ID }}
           azure-client-id: ${{ secrets.CODE_SIGNING_CLIENT_ID }}
           azure-client-secret: ${{ secrets.CODE_SIGNING_CLIENT_SECRET }}
           endpoint: "https://eus.codesigning.azure.net/"
-          trusted-signing-account-name: Netdata
+          signing-account-name: Netdata
           certificate-profile-name: Netdata
           files-folder: ${{ github.workspace }}\packaging\windows
           files-folder-filter: msi
@@ -418,7 +418,7 @@ jobs:
           timestamp-digest: SHA256
       - name: Upload Installer
         id: upload
-        uses: actions/upload-artifact@v6.0.0
+        uses: actions/upload-artifact@v7.0.0
         with:
           name: windows-x86_64-installer
           path: packaging\windows\netdata*.msi
@@ -450,6 +450,75 @@ jobs:
             && needs.file-check.outputs.run == 'true'
           }}
 
+  windows-test: # Test the Windows installer
+    name: Test Windows installer
+    runs-on: windows-latest
+    needs:
+      - windows-build
+      - file-check
+    steps:
+      - name: Skip Check
+        id: skip
+        if: needs.file-check.outputs.run != 'true'
+        run: Write-Output "SKIPPED"
+      - name: Checkout
+        uses: actions/checkout@v6
+        id: checkout
+        if: needs.file-check.outputs.run == 'true'
+        with:
+          submodules: false
+          lfs: false
+      - name: Retrieve Windows Artifacts
+        id: fetch-windows
+        if: needs.file-check.outputs.run == 'true'
+        uses: Wandalen/wretry.action@v3
+        with:
+          action: actions/download-artifact@v4
+          with: |
+            pattern: windows-*-installer
+            path: dist-artifacts
+            merge-multiple: true
+          attempt_limit: 3
+          attempt_delay: 2000
+      - name: Install Netdata
+        id: install-netdata
+        if: needs.file-check.outputs.run == 'true'
+        run: |
+          $installerProc = Start-Process "msiexec" "/qn /i `"$PWD\dist-artifacts\netdata-x64.msi`" /l* `"$PWD\msi.log`" NDDRVINST=0" -Wait -NoNewWindow -PassThru
+          Write-Output "Exit Code: $installerProc.ExitCode"
+          Get-Content "$PWD\msi.log"
+          $successCodes = @(0, 3010)
+          if ($installerProc.ExitCode -notin $successCodes) {
+              exit 1
+          }
+      - name: Check agent linking
+        id: linker-check
+        if: needs.file-check.outputs.run == 'true'
+        run: ./.github/scripts/windows-linker-check.ps1
+      - name: Failure Notification
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_COLOR: 'danger'
+          SLACK_FOOTER: ''
+          SLACK_ICON_EMOJI: ':github-actions:'
+          SLACK_TITLE: 'Windows install test failed:'
+          SLACK_USERNAME: 'GitHub Actions'
+          SLACK_MESSAGE: |-
+              ${{ github.repository }}: Windows install test failed.
+              Checkout agent sources: ${{ steps.checkout.outcome }}
+              Fetch Windows installers: ${{ steps.fetch-windows.outcome }}
+              Install Netdata: ${{ steps.install-netdata.outcome }}
+              Check agent linking: ${{ steps.linker-check.outcome }}
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }}
+        if: >-
+          ${{
+            failure()
+            && startsWith(github.ref, 'refs/heads/master')
+            && github.event_name != 'pull_request'
+            && github.repository == 'netdata/netdata'
+            && needs.file-check.outputs.run == 'true'
+          }}
+
   prepare-upload: # Consolidate the artifacts for uploading or releasing.
     name: Prepare Artifacts
     runs-on: ubuntu-latest
@@ -508,7 +577,7 @@ jobs:
       - name: Store Artifacts
         id: store
         if: needs.file-check.outputs.run == 'true'
-        uses: actions/upload-artifact@v6.0.0
+        uses: actions/upload-artifact@v7.0.0
         with:
           name: final-artifacts
           path: artifacts/*
@@ -754,6 +823,7 @@ jobs:
     if: github.event_name == 'workflow_dispatch' && github.event.inputs.type == 'nightly' && github.repository == 'netdata/netdata'
     needs:
       - prepare-upload
+      - windows-test
       - artifact-verification-dist
       - artifact-verification-static
     steps:
@@ -889,6 +959,7 @@ jobs:
     needs:
       - artifact-verification-dist
       - artifact-verification-static
+      - windows-test
       - normalize-tag
     steps:
       - name: Checkout
@@ -1018,7 +1089,7 @@ jobs:
           submodules: recursive
       - name: Setup Buildx
         id: buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Build test environment
         id: build
         uses: Wandalen/wretry.action@v3

.github/workflows/check-markdown.yml

@@ -56,6 +56,11 @@ jobs:
           source ./venv/bin/activate
           cd netdata && python3 integrations/gen_doc_collector_page.py
 
+      - name: Generate src/collectors/SECRETS.md
+        run: |
+          source ./venv/bin/activate
+          cd netdata && python3 integrations/gen_doc_secrets_page.py
+
       - name: Run Ingest
         working-directory: learn
         run: |