vde_switch - bug in hub mode

[VincVerdon]

Hi,
I'm using Vde 2.3.3
When I configure vde_switch in hub mode from command line or admin term, it doesn't work anymore. Bug ?

[VincVerdon]

I've found the problem. Error in port.c code : loop counter initialization must be to 0 value, not 1, everywhere
for(i = 0; i < numports; i++)
As I launch hub with only 3 ports with -n 3 option, only 2 are really active.
Same pb in switch port count !

[danielinux]

Hey @VincVerdon this looks like a valid claim. The i = 1 counter initialization is needed because 0 is reserved. The issue is an off-by-one when setting numports after your -n. I'm opening a PR that should fix this.

[danielinux]

#68 should fix this. Please let us know.

[VincVerdon]

Hi,
I wonder what is the 0 port reserved to do ? I have tried beginning loops with 0 and didn't constat problems for the moment. Could you explain ?
I will try #68.

Hey @VincVerdon this looks like a valid claim. The i = 1 counter initialization is needed because 0 is reserved. The issue is an off-by-one when setting numports after your -n. I'm opening a PR that should fix this.