refactor(core): keep widget post-render hook internal

Author: ibgreen

docs/api-reference/core/widget.md

@@ -39,12 +39,6 @@ Additional inline CSS styles on the top HTML element of the widget. camelCase CS
 
 Additional CSS classnames on the top HTML element.
 
-#### `onAfterRenderHTML` (function, optional) {#onafterrenderhtml-prop}
-
-Called after the widget has rendered HTML into its root element. Receives the root `HTMLElement`.
-
-If a widget subclass implements the protected `onAfterRenderHTML()` method, that method runs before this callback.
-
 #### `_container` (string | HTMLDivElement, optional) {#_container}
 
 Experimental. The container that this widget is being attached to. Default to `viewId`.
@@ -99,7 +93,7 @@ This function is implemented by the specific widget subclass to update the HTML
 
 #### `onAfterRenderHTML` {#onafterrenderhtml}
 
-Optional. Called after `onRenderHTML()` has updated the widget HTML, and before the `onAfterRenderHTML` prop callback.
+Optional. Called after `onRenderHTML()` has updated the widget HTML.
 
 #### `onAdd` {#onadd}
 

docs/api-reference/widgets/widget-tooltip.md

@@ -11,7 +11,7 @@ import '@deck.gl/widgets/stylesheet.css';
 
 ## Usage
 
-Pass `updateWidgetTooltip` as the `onAfterRenderHTML` prop. Descendants with a `data-deck-widget-tooltip` attribute become tooltip anchors.
+Call `updateWidgetTooltip` from `onAfterRenderHTML()`. Descendants with a `data-deck-widget-tooltip` attribute become tooltip anchors.
 
 ```tsx
 class ResetWidget extends Widget {
@@ -27,17 +27,9 @@ class ResetWidget extends Widget {
       rootElement
     );
   }
-}
-
-const widget = new ResetWidget({
-  onAfterRenderHTML: updateWidgetTooltip
-});
-```
 
-Subclassing remains available when a custom widget always needs the helper:
-
-```ts
-protected override onAfterRenderHTML = updateWidgetTooltip;
+  protected override onAfterRenderHTML = updateWidgetTooltip;
+}
 ```
 
 Tooltip labels are plain text. Set `aria-label` separately when the anchor needs an accessible name, such as an icon-only button. If an anchor also has a native `title`, the helper removes it to avoid competing browser tooltips. The helper shows tooltips on pointer hover and keyboard focus, and hides them on pointer leave, blur, Escape, or the next render.

modules/core/src/lib/widget.ts

@@ -18,8 +18,6 @@ export type WidgetProps = {
   style?: Partial<CSSStyleDeclaration>;
   /** Additional CSS class. */
   className?: string;
-  /** Called after the widget has rendered HTML into its root element. */
-  onAfterRenderHTML?: (rootElement: HTMLElement) => void;
   /**
    * The container that this widget is being attached to. Default to `viewId`.
    * If set to `'root'`, the widget is placed relative to the whole deck.gl canvas.
@@ -37,8 +35,7 @@ export abstract class Widget<
     id: 'widget',
     style: {},
     _container: null,
-    className: '',
-    onAfterRenderHTML: undefined!
+    className: ''
   };
 
   /** Unique identifier of the widget. */
@@ -99,7 +96,6 @@ export abstract class Widget<
     if (this.rootElement) {
       this.onRenderHTML(this.rootElement);
       this.onAfterRenderHTML(this.rootElement);
-      this.props.onAfterRenderHTML?.(this.rootElement);
     }
   }
 

test/modules/core/lib/widget-manager.spec.ts

@@ -54,7 +54,7 @@ const mockDeckInstance = {
   height: 400
 };
 
-test('Widget#onAfterRenderHTML prop runs after protected hook', () => {
+test('Widget#onAfterRenderHTML runs after onRenderHTML', () => {
   const calls: string[] = [];
   class AfterRenderWidget extends TestWidget {
     override onRenderHTML(): void {
@@ -66,13 +66,11 @@ test('Widget#onAfterRenderHTML prop runs after protected hook', () => {
     }
   }
 
-  const widget = new AfterRenderWidget({
-    onAfterRenderHTML: () => calls.push('prop')
-  });
+  const widget = new AfterRenderWidget();
   widget.rootElement = document.createElement('div');
   widget.updateHTML();
 
-  expect(calls).toEqual(['render', 'hook', 'prop']);
+  expect(calls).toEqual(['render', 'hook']);
 });
 
 test('WidgetManager#setProps', () => {