Does visit build on Tahoe? Glew missing?

[jrobcary]

I am trying to build an older visit on OSX Tahoe,

$ uname -r
25.4.0

that was branched off of

commit bff11bd7916cb368746c17bc8704c1e459a057b0
Author: Cyrus Harrison <cyrush@llnl.gov>
Date:   Thu Apr 11 08:45:15 2024 -0700

     3.4.1 release prep (#19444)

To get vtk to build, I had to upgrade vtk, so I went to the latest, 9.6.1. However, visit fails to configure with

-- Checking for VTK in /Users/cary/opt/dev5/contrib-appleclang/vtk4ctk-9.6.1-sersh
CMake Error at CMake/FindVTK9.cmake:66 (find_package):
  Found package configuration file:

    /Users/cary/opt/dev5/contrib-appleclang/vtk4ctk-sersh/lib/cmake/vtk-9.6/vtk-config.cmake

  but it set VTK_FOUND to FALSE so package "VTK" is considered to be NOT
  FOUND.  Reason given by package:

  Could not find the VTK package with the following required components:
  glew.

Call Stack (most recent call first):
  CMake/FindVisItVTK.cmake:25 (include)
  CMake/SetUpThirdParty.cmake:569 (include)
  CMakeLists.txt:928 (include)

Is there a fix for this?

[biagas]

VisIt is currently using VTK 9.5.0 on develop (and soon to be released version 3.5.0). You might encounter other issues if you stick with VTK 9.6 as we haven't tried it and don't know if there are breaking API chanages.

AFAIK, VTK no longer uses glew, it uses 'glad' instead. How did you configure your VTK build?

[jrobcary]

I configured with

env Qt5_DIR='/opt/homebrew/Cellar/qt@5/5.15.18/lib/cmake/Qt5' '/Users/cary/opt/dev5/contrib-appleclang/cmake-3.30.5-ser/bin/cmake' \
  -DCMAKE_INSTALL_PREFIX:PATH=/Users/cary/opt/dev5/contrib-appleclang/vtk4ctk-9.6.1-sersh \
  -DCMAKE_BUILD_TYPE:STRING=Release \
  -DCMAKE_COLOR_MAKEFILE:BOOL=FALSE \
  -DCMAKE_VERBOSE_MAKEFILE:BOOL=TRUE \
  -DBUILD_SHARED_LIBS:BOOL=ON \
  -DVTK_DEBUG_LEAKS:BOOL=OFF \
  -DBUILD_TESTING:BOOL=OFF \
  -DVTK_REPORT_OPENGL_ERRORS:BOOL=false \
  -DVTK_ALL_NEW_OBJECT_FACTORY:BOOL=TRUE \
  -DVTK_USE_TK:BOOL=OFF \
  -DVTK_USE_64BIT_IDS:BOOL=ON \
  -DVTK_QT_VERSION:STRING=5 \
  -DVTK_LEGACY_REMOVE:BOOL=ON \
  -DVTK_FORBID_DOWNLOADS:BOOL=true \
  -DVTK_GROUP_ENABLE_Imaging:STRING=DONT_WANT \
  -DVTK_GROUP_ENABLE_MPI:STRING=DONT_WANT \
  -DVTK_GROUP_ENABLE_Qt:STRING=DONT_WANT \
  -DVTK_GROUP_ENABLE_Rendering:STRING=DONT_WANT \
  -DVTK_GROUP_ENABLE_StandAlone:STRING=DONT_WANT \
  -DVTK_GROUP_ENABLE_Views:STRING=DONT_WANT \
  -DVTK_GROUP_ENABLE_Web:STRING=DONT_WANT \
  -DVTK_MODULE_ENABLE_VTK_CommonCore:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_FiltersFlowPaths:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_FiltersHybrid:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_FiltersModeling:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_GeovisCore:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_IOEnSight:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_IOGeometry:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_IOLegacy:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_IOPLY:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_IOXML:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_InteractionStyle:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_RenderingAnnotation:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_RenderingFreeType:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_RenderingOpenGL2:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_RenderingVolumeOpenGL2:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_libxml2:STRING=YES \
  -DVTK_MODULE_ENABLE_VTK_GUISupportQt:STRING=YES \
  -DCMAKE_INSTALL_NAME_DIR='/Users/cary/opt/dev5/contrib-appleclang/vtk4ctk-9.6.1-sersh/lib' \
  -DCMAKE_OSX_SYSROOT:PATH='/Library/Developer/CommandLineTools/SDKs/MacOSX26.4.sdk' \
  -DCMAKE_C_COMPILER:FILEPATH='/usr/bin/clang' \
  -DCMAKE_CXX_COMPILER:FILEPATH='/usr/bin/clang++' \
  -DCMAKE_C_FLAGS:STRING='-Wno-error=implicit-function-declaration -Wno-error=strict-prototypes -falign-functions=8 -fvisibility=default -isystem /opt/homebrew/include -mmacosx-version-min=10.15 -pipe -fPIC -fno-common -fexceptions' \
  -DCMAKE_CXX_FLAGS:STRING='-fno-common -fexceptions' \
  -DVTK_WRAP_PYTHON:BOOL=ON \
  -DVTK_REQUIRED_OBJCXX_FLAGS:STRING='' \
  -G 'Unix Makefiles' /Users/cary/MyDocs/projects/vsimall-dev5/builds/vtk4ctk-9.6.1

[jrobcary]

Got it. The problem is that vtk-9.2.6 does not build on Tahoe (26.4), but 9.4.2, 9.5.2, and 9.6.1 do.

However, visit-3.4.1 will not configure against vtk-9.4.2.

Will vtk-9.5.0 work with visit-3.4.2?
Or should I go to develop?

[biagas]

VTK 9.5.0 --> develop (or 3.5.0 if you can wait another week or so while we finalize.)

[jrobcary]

I do not see a 3.5RC branch. Will that come off of develop?

[JustinPrivitera]

Yes, most likely next week. Develop is a good choice for now.

[JustinPrivitera]

But 3.5.0 should be releasing very shortly.

[jrobcary]

I am continuing on this build from visit/develop. I have now run into

[ 33%] Generating visit_module_py_setup.stamp
cd /Users/cary/MyDocs/projects/vsimall-dev5/visit4ctk/src/visitpy/visit_module && /opt/homebrew/Frameworks/Python.framework/Versions/3.13/bin/python3.13 -m pip install . -V --upgrade --disable-pip-version-check --no-warn-script-location --target /Users/cary/MyDocs/projects/vsimall-dev5/builds/visit4ctk/sersh/lib/site-packages
Processing ./.
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: finished with status 'done'
  Getting requirements to build wheel: finished with status 'done'
ERROR: Exception:
Traceback (most recent call last):
  File "/Users/cary/opt/dev5/contrib-appleclang/Python-3.10.4-sersh/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 107, in _run_wrapper
    status = _inner_run()
  File "/Users/cary/opt/dev5/contrib-appleclang/Python-3.10.4-sersh/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 98, in _inner_run
    return self.run(options, args)
...
Lots of stuff
...
  File "/Users/cary/opt/dev5/contrib-appleclang/Python-3.10.4-sersh/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_impl.py", line 196, in get_requires_for_build_wheel
    return self._call_hook(
           ~~~~~~~~~~~~~~~^
        "get_requires_for_build_wheel", {"config_settings": config_settings}
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/Users/cary/opt/dev5/contrib-appleclang/Python-3.10.4-sersh/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_impl.py", line 402, in _call_hook
    raise BackendUnavailable(
    ...<4 lines>...
    )
pip._vendor.pyproject_hooks._impl.BackendUnavailable: Cannot import 'setuptools.build_meta'

Thoughts?

[jrobcary]

I can sidestep the above error by doing

make -j8 -i
make -j8

with no failures. But then "make install" fails with

-- Installing: /Users/cary/opt/dev5/volatile-appleclang/visit4ctk-stable3.5.0.r19734-sersh/3.5.0/darwin-arm64/bin/qt.conf
CMake Error at cmake_install.cmake:1008 (file):
  file INSTALL cannot find "/opt/homebrew/plugins/platforms": No such file or
  directory.

While that directory does not exist, I do find in the homebrew installation:

$ ls  /opt/homebrew/share/qt/plugins/platforms/
libqcocoa.dylib		libqminimal.dylib	libqoffscreen.dylib

but nothing similar for qt6:

$ ls  /opt/homebrew/share/qt6
json_schema	wayland		webchannel

[biagas]

Did you build Qt via build_visit? You might want to try that instead of system Qt, I honestly don't know how well system Qt is tested against VisIt. Also, we are using Python 3.13.9 on develop, so you might encounter issues using 3.10 with VisIt.

[jrobcary]

Running build_visit from trunk gives

Cloning VisIt with Git (http://github.com/visit-dav/visit.git) . . .
Unable to build VisIt. Recursive Git clone of 'http://github.com/visit-dav/visit.git' failed.

The log contains

...
Updating files: 100% (19862/19862)^MUpdating files: 100% (19862/19862), done.
error: /Users/cary/MyDocs/projects/visitall/visit/src/tools/dev/scripts/visit/.git/hooks/post-checkout

[biagas]

Probably an LFS issue. Can you try again?

[jrobcary]

Thanks. Now past that!

Made this change to get past an error regarding MACOSX_DEPLOYMENT_TARGET:

diff --git a/src/tools/dev/scripts/bv_support/bv_main.sh b/src/tools/dev/scripts/bv_support/bv_main.sh
index 870136c497..59b38e96ed 100644
--- a/src/tools/dev/scripts/bv_support/bv_main.sh
+++ b/src/tools/dev/scripts/bv_support/bv_main.sh
@@ -388,6 +388,9 @@ function initialize_build_visit()
         elif [[ ${VER_MAJOR} == 24 ]] ; then
             # keep 13 (ventura)
             export MACOSX_DEPLOYMENT_TARGET=13.0
+        elif [[ ${VER_MAJOR} == 25 ]] ; then
+            # keep 13 (ventura)
+            export MACOSX_DEPLOYMENT_TARGET=13.0
         else
             echo "Unsupported Darwin major version, ${VER_MAJOR}."
             echo "Maybe add a new case for MACOSX_DEPLOYMENT_TARGET"

Problem now in llvm:

In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX26.4.sdk/usr/include/xlocale.h:42:
/Library/Developer/CommandLineTools/SDKs/MacOSX26.4.sdk/usr/include/xlocale/_regex.h:37:15: error: unknown type name 'regex_t'
   37 | int     regcomp_l(regex_t * __restrict, const char * __restrict, int,
      |                   ^
/Library/Developer/CommandLineTools/SDKs/MacOSX26.4.sdk/usr/include/xlocale/_regex.h:43:16: error: unknown type name 'regex_t'
   43 | int     regncomp_l(regex_t * __restrict, const char * __restrict _LIBC_COUNT(__len),
      |                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX26.4.sdk/usr/include/xlocale/_regex.h:46:16: error: unknown type name 'regex_t'
   46 | int     regwcomp_l(regex_t * __restrict, const wchar_t * __restrict,
      |                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX26.4.sdk/usr/include/xlocale/_regex.h:49:23: error: unknown type name 'regex_t'
   49 | int     regwnexec_l(const regex_t * __restrict, const wchar_t * __restrict _LIBC_COUNT(__len),

I guess with the Tahoe sdk, so not clear what to do until Apple fixes this.