Stabilizing build.ssrEmitAssets

[patak-cat]

build.ssrEmitAssets

• Introduced in vite@4.1.0
• Rationale in original PR
• Docs missing
• Used by SvelteKit, Astro, Redwood. GitHub Search

If you have feedback about this feature, let's discuss it here. Given current usage, it would be good to move it out of experimental in Vite 5. cc @brillout, as the feature didn't work initially for you in vite-plugin-ssr.

[brillout]

Indeed, vite-plugin-ssr still uses its own workaround. I'll give build.ssrEmitAssets another shot and report back later this week / next week.

Edit: New ETA this week.

[brillout]

SvelteKit seems to still having issues, and @s3812497 is actually considering using vite-plugin-ssr's woarkound instead of build.ssrEmitAssets.

So I'm thinking of sticking with vite-plugin-ssr's workaround.

(Apologies for the delay, a lot of unforeseen high prios popped up.)

[brillout]

Update: seems like SvelteKit issues were resolved in SvelteKit land.

Conclusion: AFACIT the quirks required on meta-framework land are this.

[dai-shi]

Thanks to redwoodjs/graphql#8887, I start using ssrEmitAssets in https://github.com/dai-shi/waku/pull/106.

[teemingc]

Is there a solution to specify an imported asset as a client asset in server-only code so it is exposed publicly in the final build?
Related to sveltejs/kit#9961 where users want to serve assets through an endpoint.
Maybe a suffix such as import foo from './foo.png?client'

EDIT: this is no longer an issue. SvelteKit always copies server assets over to the client assets folder.

[bluwy]

For that case, I think SvelteKit can orchestrate building the client and server assets as separate folders, then copy files over that has ?client (information collected as a Vite plugin while building)?

I don't think it's something Vite can tackle yet unless/until we figure out a new API that builds both the client and server (and more), and communicate information between them.

[brillout]

Looking at sveltejs/kit#9073 it seems like the issue should be solved: both the server and client assets are being copied. So, regardless of whether assets are being imported by server or client files, they should always be present in the public build, or am I missing something here?

unless/until we figure out a new API that builds both the client and server

@patak-dev Is that on Vite's radar? 👀 Would be neat as it would solve the problem once and for all and without requiring quirks from the meta framework.

[teemingc]

Looking at sveltejs/kit#9073 it seems like the issue should be solved: both the server and client assets are being copied. So, regardless of whether assets are being imported by server or client files, they should always be present in the public build, or am I missing something here?

You're right! I made a mistake. It seems the issue lies elsewhere. Thanks for pointing this out.

[brillout]

the issue lies elsewhere

For future reference: the issue lies here.

[patak-cat]

@brillout it isn't on the Vite's team radar at this point. There were no further discussions except for a few comments like the above when we hit the limits of what's possible with independent builds.

[hi-ogawa]

Hi, it's not confirmed by remix maintainers yet, but remix's vite plugin might have a similar issue as sveltekit for assets referenced only by server code.
So, I proposed a PR to use ssrEmitAssets on remix as well in a similar way.
There's no feedback to vite-side yet, but I thought it's worth pinging this "stabilizing" series of discussion.

PR remix-run/remix#7892
issue remix-run/remix#7847

[sapphi-red]

This was stabilized in Vite 5