Skip to content

Refactor the create and patch service logic in haprovider #317

@lubronzhan

Description

@lubronzhan

Bug description
The haprovider logic is not correctly createAndPatch service. some of the fields won't be patched after created. it should use something like below to correctly patch service in case service is modified incorrectly by human

https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/pkg/services/vimmachine.go#L310-L374

Affected product area (please put an X in all that apply)

  • Docs
  • Installation
  • Plugin
  • Security
  • Test and Release
  • User Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions