Prompt use of personal CF CLI config if found

[andrew-woosnam]

Feature idea:
When the extension launches, it checks for the presence of a cf cli config.json file at the default installation directory (~/.cf). If found, a prompt could appear offering to use those values for the CF connection (e.g. copy the contents of the personal config.json into the vsix config.json), obviating the need to log in to CF manually.

[ccheetham]

@atwoosnam Does that imply keeping the 2 in synch? If not, could lead to unexpected-to-the-developer behavior.

[dtillman]

I would find having to answer that question every time I started VS annoying ... I would prefer that the two environments be separate ...

@atwoosnam : If I start VS and login, and then terminate VS, and immediately restart it .. do I have to login again? If the tokens are still valid in the cf ".config" file used by VS plugin I shouldn't have to re login correct?

[andrew-woosnam]

@ccheetham nah I was thinking this would just allow you to log in quickly the first time but then let the 2 stay separate afterward.
I can see what you mean, that choosing to use an existing CF connection when logging in might suggest to a user that the 2 environments will mirror each other going forward... 🤔
Maybe some careful messaging with this prompt could nip that assumption in the bud? Or maybe it'd still be confusing enough to make this feature not worth it 😄🤷

[andrew-woosnam]

@dtillman correct - as long as the config.json file stays around between VS sessions there should be no need to reauthenticate (unless you purposefully log out of the CF env in VS)

[andrew-woosnam]

You may have noticed that the CF connection does not persist between sessions when using the "experimental" VS instance (while debugging this VSIX e.g.) -- I don't remember exactly what causes this (I know I've looked into it and I think it's because the config.json gets wiped on every build), but @zzori-theoriginal and I have tested several times that it isn't the case for "real" VS instances.

[dtillman]

@atwoosnam : I could see value in giving the user an option (i.e. yes/no dialog) to initialize the plugins "cf.config" file from the CLI's "cf.config" file only if the plugins file doesn't exist. Wording of the dialog would be important ... so not to infer they are kept in sync. I was thinking you would prompt every time... which I wouldn't like ;-)