refactor: use range-based loops (#514)

Replace explicit index iterations with range-style for-loops to simplify and idiomatize loop constructs. These edits are aimed at clearer, more idiomatic Go iteration.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>

Author: tenthirtyam

builder/vmware/common/cdrom_utils.go

@@ -51,7 +51,7 @@ func FindNextAvailableCDROMSlot(vmxData map[string]string, adapterType string) (
 	}
 
 	// Find the next available slot.
-	for busNum := 0; busNum < 4; busNum++ { // VMware supports up to 4 buses for most adapter types
+	for busNum := range 4 { // VMware supports up to 4 buses for most adapter types
 		busStr := strconv.Itoa(busNum)
 		busSlots := usedSlots[busStr]
 

builder/vmware/common/driver_parser.go

@@ -1994,7 +1994,7 @@ func flattenNetworkingConfig(in chan networkingCommandEntry) NetworkingConfig {
 			vmnet = e.removeNatPrefix.vnet
 			prefixes, exists := result.natPrefix[vmnet]
 			if exists {
-				for index := 0; index < len(prefixes); index++ {
+				for index := range prefixes {
 					if prefixes[index] == e.removeNatPrefix.prefix {
 						result.natPrefix[vmnet] = append(prefixes[:index], prefixes[index+1:]...)
 						break

builder/vmware/common/driver_parser_test.go

@@ -1079,7 +1079,7 @@ func TestParserTokenizeNetworkingConfig(t *testing.T) {
 		{"newline-less"},
 	}
 
-	for testnum := 0; testnum < len(tests); testnum++ {
+	for testnum := range tests {
 		inCh := consumeString(tests[testnum])
 		outCh := tokenizeNetworkingConfig(inCh)
 		result := collectIntoStringList(outCh)
@@ -1091,7 +1091,7 @@ func TestParserTokenizeNetworkingConfig(t *testing.T) {
 		}
 
 		ok := true
-		for index := 0; index < len(expected); index++ {
+		for index := range expected {
 			if result[index] != expected[index] {
 				ok = false
 			}
@@ -1116,7 +1116,7 @@ func TestParserSplitNetworkingConfig(t *testing.T) {
 		{"and", "begin", "with", "an", "empty", "string"},
 	}
 
-	for testnum := 0; testnum < len(tests); testnum++ {
+	for testnum := range tests {
 		inCh := consumeString(tests[testnum])
 		stringCh := tokenizeNetworkingConfig(inCh)
 		outCh := splitNetworkingConfig(stringCh)
@@ -1133,7 +1133,7 @@ func TestParserSplitNetworkingConfig(t *testing.T) {
 		}
 
 		ok := true
-		for index := 0; index < len(expected); index++ {
+		for index := range expected {
 			if result[index] != expected[index] {
 				ok = false
 			}
@@ -1152,14 +1152,14 @@ func TestParserParseNetworkingConfigVersion(t *testing.T) {
 		"VERSION=a,b",
 	}
 
-	for testnum := 0; testnum < len(successTests); testnum++ {
+	for testnum := range successTests {
 		test := []string{successTests[testnum]}
 		if _, err := networkingReadVersion(test); err != nil {
 			t.Errorf("success-test %d parsing failed: %v", 1+testnum, err)
 		}
 	}
 
-	for testnum := 0; testnum < len(successTests); testnum++ {
+	for testnum := range successTests {
 		test := []string{failureTests[testnum]}
 		if _, err := networkingReadVersion(test); err == nil {
 			t.Errorf("failure-test %d should have failed", 1+testnum)
@@ -1181,7 +1181,7 @@ func TestParserParseNetworkingConfigEntries(t *testing.T) {
 		"remove_nat_prefix 57005 /31",
 	}
 
-	for testnum := 0; testnum < len(tests); testnum++ {
+	for testnum := range tests {
 		test := strings.Split(tests[testnum], " ")
 		parser := NetworkingParserByCommand(test[0])
 		if parser == nil {

builder/vmware/common/step_configure_vnc.go

@@ -68,7 +68,7 @@ func VNCPassword(skipPassword bool) string {
 
 	password := make([]byte, length)
 
-	for i := 0; i < length; i++ {
+	for i := range length {
 		password[i] = charSet[rand.Intn(charSetLength)]
 	}
 

builder/vmware/common/step_output_dir.go

@@ -97,7 +97,7 @@ func (s *StepOutputDir) Cleanup(state multistep.StateBag) {
 		exists, _ := dir.DirExists()
 		if exists {
 			ui.Say("Deleting output directory...")
-			for i := 0; i < 5; i++ {
+			for range 5 {
 				err := dir.RemoveAll()
 				if err == nil {
 					break