refactor: use new(...) for pointers in tests and parser (#509)

Replace temporary variable pointer creation with direct new(...) calls.

In Go 1.26, a pointer can be created directly from an expression using new(expr).
Instead of declaring a temporary variable just to take its address, you can pass the value or function result directly to new. This removes boilerplate, keeps related logic in one place, and makes pointer initialization easier to read.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>

Author: tenthirtyam

builder/vmware/common/driver_parser.go

@@ -1147,8 +1147,7 @@ func ReadDhcpConfiguration(fd *os.File) (DhcpConfiguration, error) {
 	var walkDeclarations func(root pDeclaration, out chan *ConfigDeclaration)
 
 	walkDeclarations = func(root pDeclaration, out chan *ConfigDeclaration) {
-		res := createDeclaration(root)
-		out <- &res
+		out <- new(createDeclaration(root))
 		for _, p := range root.declarations {
 			walkDeclarations(p, out)
 		}

builder/vmware/common/step_create_disks_test.go

@@ -22,7 +22,7 @@ func strPtr(s string) *string {
 }
 func NewTestCreateDiskStep() *StepCreateDisks {
 	return &StepCreateDisks{
-		OutputDir:          strPtr("output_dir"),
+		OutputDir:          new("output_dir"),
 		CreateMainDisk:     true,
 		DiskName:           "disk_name",
 		MainDiskSize:       uint(1024),

builder/vmware/common/step_create_snapshot_test.go

@@ -17,7 +17,7 @@ func TestStepCreateSnapshot_impl(t *testing.T) {
 
 func NewTestCreateSnapshotStep() *StepCreateSnapshot {
 	return &StepCreateSnapshot{
-		SnapshotName: strPtr("snapshot_name"),
+		SnapshotName: new("snapshot_name"),
 	}
 }
 
@@ -54,7 +54,7 @@ func TestStepCreateSnapshot(t *testing.T) {
 func TestStepCreateSnapshot_skip(t *testing.T) {
 	state := testState(t)
 	step := NewTestCreateSnapshotStep()
-	step.SnapshotName = strPtr("")
+	step.SnapshotName = new("")
 
 	state.Put("vmx_path", "foo")
 

builder/vmware/common/step_export_test.go

@@ -54,7 +54,7 @@ func TestStepExport_localArgs(t *testing.T) {
 	step := new(StepExport)
 
 	step.SkipExport = false
-	step.OutputDir = stringPointer("test_output")
+	step.OutputDir = new("test_output")
 	step.VMName = "test-name"
 	step.Format = "ova"
 
@@ -88,7 +88,7 @@ func TestStepExport_localArgsExportOutputPath(t *testing.T) {
 	step := new(StepExport)
 
 	step.SkipExport = false
-	step.OutputDir = stringPointer("test_output")
+	step.OutputDir = new("test_output")
 	step.VMName = "test-name"
 	step.Format = "ova"
 
@@ -121,7 +121,7 @@ func TestStepExport_localArgs_OvftoolOptions(t *testing.T) {
 	step := new(StepExport)
 
 	step.SkipExport = false
-	step.OutputDir = stringPointer("test_output")
+	step.OutputDir = new("test_output")
 	step.VMName = "test-name"
 	step.Format = "ova"
 	step.OVFToolOptions = []string{"--option=value", "--second-option=\"quoted value\""}