refactor: optimize slice allocations and meta checks (#655)

* refactor: optimize slice allocations and meta checks

Preallocate slice capacities and consolidate meta check appends across the codebase to reduce allocations, clarify test check composition, and resolve golangci-lint errors in the GitHub Actions CI runs.

Changes include preallocating error/slice capacities, replacing repeated make([]T,0) with capacity-aware makes (many mock tests use capacity 1 for reference arrays), and refactoring test check builders to use a metaChecks variable and a single composed slice before calling `resource.ComposeTestCheckFunc`.

* fix: remove dead checks in network policy tests

Removed empty if blocks in `checkNetworkPolicyResourceAttributes` and
`verifyNetworkPolicyResourceCreation` that looked up `ENABLE_POLICY_ENV_TEST` but had no body. The checks were no-ops and triggered staticcheck SA4006 ("this value of found is never used"). Inline the workspace name directly, matching the pattern used in other policy acceptance tests.

No test behavior changes.

---------

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>

Author: tenthirtyam

internal/helper/openapi_v3_schema_validator/openapi_v3_schema_validator.go

@@ -44,7 +44,7 @@ type OpenAPIV3SchemaValidator struct {
 }
 
 func (validator *OpenAPIV3SchemaValidator) ValidateRequiredFields(objectValues map[string]interface{}) (errs []error) {
-	errs = make([]error, 0)
+	errs = make([]error, 0, len(validator.Schema))
 
 	for k, v := range validator.Schema {
 		objectValue := objectValues[k]

internal/resources/cluster/data_source_cluster_test.go

@@ -36,13 +36,14 @@ func TestAcceptanceForAttachClusterDataSource(t *testing.T) {
 }
 
 func checkDataSourceAttributes() resource.TestCheckFunc {
-	var check = []resource.TestCheckFunc{
+	metaChecks := testhelper.MetaDataSourceAttributeCheck(testhelper.ClusterDataSourceName, testhelper.ClusterResourceName)
+	check := make([]resource.TestCheckFunc, 0, 3+len(metaChecks))
+	check = append(check,
 		verifyClusterDataSource(testhelper.ClusterDataSourceName),
 		resource.TestCheckResourceAttrPair(testhelper.ClusterDataSourceName, "name", testhelper.ClusterResourceName, "name"),
 		resource.TestCheckResourceAttrSet(testhelper.ClusterDataSourceName, "id"),
-	}
-
-	check = append(check, testhelper.MetaDataSourceAttributeCheck(testhelper.ClusterDataSourceName, testhelper.ClusterResourceName)...)
+	)
+	check = append(check, metaChecks...)
 
 	return resource.ComposeTestCheckFunc(check...)
 }

internal/resources/cluster/nodepools/resource_node_pool.go

@@ -547,7 +547,7 @@ func flattenTkgServiceVsphere(tkgServiceVsphere *nodepoolmodel.VmwareTanzuManage
 	flattenTkgServiceVsphereData[storageClassKey] = tkgServiceVsphere.StorageClass
 	flattenTkgServiceVsphereData[failureDomainKey] = tkgServiceVsphere.FailureDomain
 
-	vls := make([]interface{}, 0)
+	vls := make([]interface{}, 0, len(tkgServiceVsphere.Volumes))
 	for _, vl := range tkgServiceVsphere.Volumes {
 		vls = append(vls, flattenTKGSVolumes(vl))
 	}

internal/resources/cluster/tkgaws/resource_tkg_aws.go

@@ -66,7 +66,7 @@ func ConstructTKGAWSClusterSpec(data []interface{}) (spec *tkgawsmodel.VmwareTan
 func FlattenTKGAWSClusterSpec(spec *tkgawsmodel.VmwareTanzuManageV1alpha1ClusterInfrastructureTkgawsSpec) (data []interface{}) {
 	flattenSpecData := make(map[string]interface{})
 
-	acs := make([]interface{}, 0)
+	acs := make([]interface{}, 0, len(spec.AdvancedConfigs))
 
 	for _, ac := range spec.AdvancedConfigs {
 		acs = append(acs, common.FlattenAdvancedConfig(ac))

internal/resources/cluster/tkgvsphere/resource_tkgvsphere.go

@@ -68,7 +68,7 @@ func ConstructTKGVsphereClusterSpec(data []interface{}) (spec *tkgvspheremodel.V
 func FlattenTKGVsphereClusterSpec(spec *tkgvspheremodel.VmwareTanzuManageV1alpha1ClusterInfrastructureTkgvsphereSpec) (data []interface{}) {
 	flattenSpecData := make(map[string]interface{})
 
-	acs := make([]interface{}, 0)
+	acs := make([]interface{}, 0, len(spec.AdvancedConfigs))
 
 	for _, ac := range spec.AdvancedConfigs {
 		acs = append(acs, common.FlattenAdvancedConfig(ac))

internal/resources/clustergroup/data_source_cluster_group_test.go

@@ -61,13 +61,14 @@ data "%s" "%s" {
 }
 
 func checkDataSourceAttributes(dataSourceName, resourceName string) resource.TestCheckFunc {
-	var check = []resource.TestCheckFunc{
+	metaChecks := testhelper.MetaDataSourceAttributeCheck(dataSourceName, resourceName)
+	check := make([]resource.TestCheckFunc, 0, 3+len(metaChecks))
+	check = append(check,
 		verifyClusterGroupDataSource(dataSourceName),
 		resource.TestCheckResourceAttrPair(dataSourceName, "name", resourceName, "name"),
 		resource.TestCheckResourceAttrSet(dataSourceName, "id"),
-	}
-
-	check = append(check, testhelper.MetaDataSourceAttributeCheck(dataSourceName, resourceName)...)
+	)
+	check = append(check, metaChecks...)
 
 	return resource.ComposeTestCheckFunc(check...)
 }

internal/resources/clustergroup/resource_cluster_group_test.go

@@ -71,12 +71,13 @@ resource "%s" "%s" {
 }
 
 func checkResourceAttributes(provider *schema.Provider, resourceName, clusterGroupName string) resource.TestCheckFunc {
-	var check = []resource.TestCheckFunc{
+	metaChecks := testhelper.MetaResourceAttributeCheck(resourceName)
+	check := make([]resource.TestCheckFunc, 0, 2+len(metaChecks))
+	check = append(check,
 		verifyClusterGroupResourceCreation(provider, resourceName, clusterGroupName),
 		resource.TestCheckResourceAttr(resourceName, "name", clusterGroupName),
-	}
-
-	check = append(check, testhelper.MetaResourceAttributeCheck(resourceName)...)
+	)
+	check = append(check, metaChecks...)
 
 	return resource.ComposeTestCheckFunc(check...)
 }

internal/resources/credential/data_source_credential_test.go

@@ -71,17 +71,17 @@ data "%s" "%s" {
 }
 
 func checkDataSourceAttributes(dataSourceName, resourceName string) resource.TestCheckFunc {
-	var check = []resource.TestCheckFunc{
-		verifyClusterGroupDataSource(dataSourceName),
-		resource.TestCheckResourceAttrPair(dataSourceName, "name", resourceName, "name"),
-		resource.TestCheckResourceAttrSet(dataSourceName, "id"),
-	}
-
 	checks := []resource.TestCheckFunc{
 		resource.TestCheckResourceAttr(resourceName, "meta.#", "1"),
 		resource.TestCheckResourceAttrSet(resourceName, "meta.0.uid"),
 	}
 
+	check := make([]resource.TestCheckFunc, 0, 3+len(checks))
+	check = append(check,
+		verifyClusterGroupDataSource(dataSourceName),
+		resource.TestCheckResourceAttrPair(dataSourceName, "name", resourceName, "name"),
+		resource.TestCheckResourceAttrSet(dataSourceName, "id"),
+	)
 	check = append(check, checks...)
 
 	return resource.ComposeTestCheckFunc(check...)

internal/resources/credential/resource_credential_test.go

@@ -171,16 +171,16 @@ resource "%s" "%s" {
 }
 
 func checkResourceAttributes(provider *schema.Provider, resourceName, credentialName string) resource.TestCheckFunc {
-	var check = []resource.TestCheckFunc{
-		verifyCredentialResourceCreation(provider, resourceName, credentialName),
-		resource.TestCheckResourceAttr(resourceName, "name", credentialName),
-	}
-
 	checks := []resource.TestCheckFunc{
 		resource.TestCheckResourceAttr(resourceName, "meta.#", "1"),
 		resource.TestCheckResourceAttrSet(resourceName, "meta.0.uid"),
 	}
 
+	check := make([]resource.TestCheckFunc, 0, 2+len(checks))
+	check = append(check,
+		verifyCredentialResourceCreation(provider, resourceName, credentialName),
+		resource.TestCheckResourceAttr(resourceName, "name", credentialName),
+	)
 	check = append(check, checks...)
 
 	return resource.ComposeTestCheckFunc(check...)

internal/resources/customiamrole/resource_custom_iam_role.go

@@ -241,7 +241,7 @@ func formatAggregationRuleData(tfAggregationRule []interface{}, modelAggregation
 		}
 	}
 
-	aggregationRule = make([]interface{}, 0)
+	aggregationRule = make([]interface{}, 0, 1)
 	aggregationRuleMap := make(map[string]interface{})
 	aggregationRuleMap[ClusterRoleSelectorKey] = clusterRoleSelector
 	aggregationRule = append(aggregationRule, aggregationRuleMap)