Request: please pass the model class to dataTransformer

[seankndy]

It would be nice if this plugin would pass the model class as the second argument to the dataTransformer callback so that the dataTransformer function could mutate extra state in the model. Example:

In my model:

export default class FooBar extends Model {
  // ....

  static state() {
    return {
      abilities: null,
    }
  }
}

Now in the transformer:

  dataTransformer: (response, model) => {
    if ('abilities' in response.data) {
      model.commit((state) => {
        state.abilities = response.data.abilities
      })
    }
    return 'data' in response.data ? response.data.data : response.data
  }

I can accomplish this same sort of thing by passing a 'model' into the axios config during the request:

API call:

    const response = FooBar.api()
      .get('/foobars', {
        model: FooBar,
      })

Then in dataTransformer, use it in response.config:

  dataTransformer: (response) => {
    if ('model' in response.config && 'abilities' in response.data) {
      response.config.model.commit((state) => state.abilities = response.data.abilities)
    }

    return 'data' in response.data ? response.data.data : response.data
  }

However it seems reasonable to me that the plugin would pass in the model and make this cleaner.

[cuebit]

Curious to understand why you'd need a reference to the constructor?

If you're calling FooBar.api(), the transformer belongs to FooBar, therefore FooBar can be referenced statically.

If your transformer is anonymously generic then that's a user-land resolution.

In the case of the latter, maybe you could use a factory to pass the model reference?

[seankndy]

The data transformer in this case is global and applies to every model. So in the calling code I am using the static FooBar, but in the transformer itself I don't know which model was called as it's generic to every model.