Address review feedback on the new UI coverage tests

- welcomeConfig.test.ts: assert repeated reads after a malformed file keep
  returning the default rather than caching a bad parse, and add a case
  proving recovery once the file is replaced and the cache is reset.
- validation.test.ts: stop asserting that validateKeyFile('~') is valid.
  That claimed a directory is a valid key file, which is a production quirk
  (filed as #3402), and dev-docs/RULES.md forbids enshrining a bug as
  specification. The bare-tilde branch is now pinned by asserting that '~'
  and the literal home path receive the same verdict, which still fails if
  expandTilde's bare-tilde branch is broken.
- interactive-ui.test.ts: name the scenario file that actually sets
  LLXPRT_CODE_WELCOME_CONFIG_PATH so the comment cannot be misread as the
  test setting it.

Author: acoliver

packages/cli/src/config/welcomeConfig.test.ts

@@ -120,6 +120,19 @@ describe('loadWelcomeConfig', () => {
     resetWelcomeConfigForTesting();
     expect(loadWelcomeConfig()).toEqual({ welcomeCompleted: false });
     expect(isWelcomeCompleted()).toBe(false);
+    // Repeated reads without a cache reset must keep returning the default
+    // rather than re-parsing (or caching) the corrupt file into something else.
+    expect(loadWelcomeConfig()).toEqual({ welcomeCompleted: false });
+    expect(isWelcomeCompleted()).toBe(false);
+  });
+
+  it('recovers once the malformed file is replaced and the cache is reset', () => {
+    fs.writeFileSync(getConfigPath(), '{ not json', 'utf-8');
+    resetWelcomeConfigForTesting();
+    expect(isWelcomeCompleted()).toBe(false);
+    fs.writeFileSync(getConfigPath(), '{"welcomeCompleted": true}', 'utf-8');
+    resetWelcomeConfigForTesting();
+    expect(isWelcomeCompleted()).toBe(true);
   });
 });
 

packages/cli/src/ui/components/ProfileCreateWizard/validation.test.ts

@@ -157,11 +157,19 @@ describe('validateKeyFile', () => {
     });
   });
 
-  it('expands a bare tilde to the home directory itself', async () => {
+  it('treats a bare tilde exactly like the literal home directory path', async () => {
+    // expandTilde has a separate branch for a bare `~`. Asserting that `~` and
+    // the literal home path get the SAME verdict pins that branch without
+    // asserting anything about what the verdict for a directory ought to be —
+    // validateKeyFile currently only checks read access, so it accepts a
+    // directory, and that is a separate question (filed as #3402) that this
+    // coverage-only test must not enshrine either way.
     const dir = keyFileDir();
     homeDirOverride = dir;
 
-    await expect(validateKeyFile('~')).resolves.toEqual({ valid: true });
+    const bareTilde = await validateKeyFile('~');
+    const literalHome = await validateKeyFile(dir);
+    expect(bareTilde.valid).toBe(literalHome.valid);
   });
 
   it('reports not-found for a tilde path whose target is absent from the home directory', async () => {

scripts/tests/interactive-ui.test.ts

@@ -164,10 +164,12 @@ describe('Interactive UI (tmux harness)', () => {
   runTmuxE2E(
     'a clean welcome config shows onboarding, and skipping dismisses it',
     () => {
-      // The scenario points LLXPRT_CODE_WELCOME_CONFIG_PATH at a per-run temp
-      // path that does not exist, so the CLI starts as a first-run/clean
-      // runner. Pointing it at a completed config instead makes the scenario
-      // fail on the first waitFor, which is what makes this smoke meaningful.
+      // The startCommand inside scripts/tmux-script.onboarding.json — not this
+      // test — sets LLXPRT_CODE_WELCOME_CONFIG_PATH to a per-run temp path and
+      // removes it before launch, so the CLI starts as a first-run/clean
+      // runner. Editing that scenario to point at a completed config instead
+      // makes it fail on the first waitFor, which is what makes this smoke
+      // meaningful rather than vacuous.
       const result = runHarness(
         'tmux-script.onboarding.json',
         'onboarding-clean-runner',