Fix struct pointers, add struct support, add more tests

Author: w4z3d

.clang-tidy

@@ -1,5 +1,5 @@
 ---
-Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,bugprone-argument-comment,bugprone-assert-side-effect,bugprone-bad-signal-to-kill-thread,bugprone-branch-clone,bugprone-copy-constructor-init,bugprone-dangling-handle,bugprone-dynamic-static-initializers,bugprone-fold-init-type,bugprone-forward-declaration-namespace,bugprone-forwarding-reference-overload,bugprone-inaccurate-erase,bugprone-incorrect-roundings,bugprone-integer-division,bugprone-lambda-function-name,bugprone-macro-parentheses,bugprone-macro-repeated-side-effects,bugprone-misplaced-operator-in-strlen-in-alloc,bugprone-misplaced-pointer-arithmetic-in-alloc,bugprone-misplaced-widening-cast,bugprone-move-forwarding-reference,bugprone-multiple-statement-macro,bugprone-no-escape,bugprone-not-null-terminated-result,bugprone-parent-virtual-call,bugprone-posix-return,bugprone-reserved-identifier,bugprone-sizeof-container,bugprone-sizeof-expression,bugprone-spuriously-wake-up-functions,bugprone-string-constructor,bugprone-string-integer-assignment,bugprone-string-literal-with-embedded-nul,bugprone-suspicious-enum-usage,bugprone-suspicious-include,bugprone-suspicious-memory-comparison,bugprone-suspicious-memset-usage,bugprone-suspicious-missing-comma,bugprone-suspicious-semicolon,bugprone-suspicious-string-compare,bugprone-swapped-arguments,bugprone-terminating-continue,bugprone-throw-keyword-missing,bugprone-too-small-loop-variable,bugprone-undefined-memory-manipulation,bugprone-undelegated-constructor,bugprone-unhandled-self-assignment,bugprone-unused-raii,bugprone-unused-return-value,bugprone-use-after-move,bugprone-virtual-near-miss,cert-dcl21-cpp,cert-dcl58-cpp,cert-err34-c,cert-err52-cpp,cert-err58-cpp,cert-err60-cpp,cert-flp30-c,cert-msc50-cpp,cert-msc51-cpp,cert-str34-c,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-narrowing-conversions,cppcoreguidelines-pro-type-member-init,cppcoreguidelines-pro-type-static-cast-downcast,cppcoreguidelines-slicing,google-default-arguments,google-explicit-constructor,google-runtime-operator,hicpp-exception-baseclass,hicpp-multiway-paths-covered,misc-misplaced-const,misc-new-delete-overloads,misc-no-recursion,misc-non-copyable-objects,misc-throw-by-value-catch-by-reference,misc-unconventional-assign-operator,misc-uniqueptr-reset-release,modernize-avoid-bind,modernize-concat-nested-namespaces,modernize-deprecated-headers,modernize-deprecated-ios-base-aliases,modernize-loop-convert,modernize-make-shared,modernize-make-unique,modernize-pass-by-value,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-disallow-copy-and-assign-macro,modernize-replace-random-shuffle,modernize-return-braced-init-list,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-auto,modernize-use-bool-literals,modernize-use-emplace,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-nodiscard,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,mpi-buffer-deref,mpi-type-mismatch,openmp-use-default-none,performance-faster-string-find,performance-for-range-copy,performance-implicit-conversion-in-loop,performance-inefficient-algorithm,performance-inefficient-string-concatenation,performance-inefficient-vector-operation,performance-move-const-arg,performance-move-constructor-init,performance-no-automatic-move,performance-noexcept-move-constructor,performance-trivially-destructible,performance-type-promotion-in-math-fn,performance-unnecessary-copy-initialization,performance-unnecessary-value-param,portability-simd-intrinsics,readability-avoid-const-params-in-decls,readability-const-return-type,readability-container-size-empty,readability-convert-member-functions-to-static,readability-delete-null-pointer,readability-deleted-default,readability-inconsistent-declaration-parameter-name,readability-make-member-function-const,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-control-flow,readability-redundant-declaration,readability-redundant-function-ptr-dereference,readability-redundant-smartptr-get,readability-redundant-string-cstr,readability-redundant-string-init,readability-simplify-subscript-expr,readability-static-accessed-through-instance,readability-static-definition-in-anonymous-namespace,readability-string-compare,readability-uniqueptr-delete-release,readability-use-anyofallof'
+Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,bugprone-argument-comment,bugprone-assert-side-effect,bugprone-bad-signal-to-kill-thread,bugprone-branch-clone,bugprone-copy-constructor-init,bugprone-dangling-handle,bugprone-dynamic-static-initializers,bugprone-fold-init-type,bugprone-forward-declaration-namespace,bugprone-forwarding-reference-overload,bugprone-inaccurate-erase,bugprone-incorrect-roundings,bugprone-integer-division,bugprone-lambda-function-name,bugprone-macro-parentheses,bugprone-macro-repeated-side-effects,bugprone-misplaced-operator-in-strlen-in-alloc,bugprone-misplaced-pointer-arithmetic-in-alloc,bugprone-misplaced-widening-cast,bugprone-move-forwarding-reference,bugprone-multiple-statement-macro,bugprone-no-escape,bugprone-not-null-terminated-result,bugprone-parent-virtual-call,bugprone-posix-return,bugprone-reserved-identifier,bugprone-sizeof-container,bugprone-sizeof-expression,bugprone-spuriously-wake-up-functions,bugprone-string-constructor,bugprone-string-integer-assignment,bugprone-string-literal-with-embedded-nul,bugprone-suspicious-enum-usage,bugprone-suspicious-include,bugprone-suspicious-memory-comparison,bugprone-suspicious-memset-usage,bugprone-suspicious-missing-comma,bugprone-suspicious-semicolon,bugprone-suspicious-string-compare,bugprone-swapped-arguments,bugprone-terminating-continue,bugprone-throw-keyword-missing,bugprone-too-small-loop-variable,bugprone-undefined-memory-manipulation,bugprone-undelegated-constructor,bugprone-unhandled-self-assignment,bugprone-unused-raii,bugprone-unused-return-value,bugprone-use-after-move,bugprone-virtual-near-miss,cert-dcl21-cpp,cert-dcl58-cpp,cert-err34-c,cert-err52-cpp,cert-err58-cpp,cert-err60-cpp,cert-flp30-c,cert-msc50-cpp,cert-msc51-cpp,cert-str34-c,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-narrowing-conversions,cppcoreguidelines-pro-type-member-init,cppcoreguidelines-slicing,google-default-arguments,google-explicit-constructor,google-runtime-operator,hicpp-exception-baseclass,hicpp-multiway-paths-covered,misc-misplaced-const,misc-new-delete-overloads,misc-no-recursion,misc-non-copyable-objects,misc-throw-by-value-catch-by-reference,misc-unconventional-assign-operator,misc-uniqueptr-reset-release,modernize-avoid-bind,modernize-concat-nested-namespaces,modernize-deprecated-headers,modernize-deprecated-ios-base-aliases,modernize-loop-convert,modernize-make-shared,modernize-make-unique,modernize-pass-by-value,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-disallow-copy-and-assign-macro,modernize-replace-random-shuffle,modernize-return-braced-init-list,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-auto,modernize-use-bool-literals,modernize-use-emplace,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-nodiscard,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,mpi-buffer-deref,mpi-type-mismatch,openmp-use-default-none,performance-faster-string-find,performance-for-range-copy,performance-implicit-conversion-in-loop,performance-inefficient-algorithm,performance-inefficient-string-concatenation,performance-inefficient-vector-operation,performance-move-const-arg,performance-move-constructor-init,performance-no-automatic-move,performance-noexcept-move-constructor,performance-trivially-destructible,performance-type-promotion-in-math-fn,performance-unnecessary-copy-initialization,performance-unnecessary-value-param,portability-simd-intrinsics,readability-avoid-const-params-in-decls,readability-const-return-type,readability-container-size-empty,readability-convert-member-functions-to-static,readability-delete-null-pointer,readability-deleted-default,readability-inconsistent-declaration-parameter-name,readability-make-member-function-const,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-control-flow,readability-redundant-declaration,readability-redundant-function-ptr-dereference,readability-redundant-smartptr-get,readability-redundant-string-cstr,readability-redundant-string-init,readability-simplify-subscript-expr,readability-static-accessed-through-instance,readability-static-definition-in-anonymous-namespace,readability-string-compare,readability-uniqueptr-delete-release,readability-use-anyofallof'
 WarningsAsErrors: '*'
 CheckOptions:
   - key:             bugprone-argument-comment.CommentBoolLiterals

src/analysis/type_check.cpp

@@ -6,7 +6,41 @@ void TypeVisitor::emit_error(const SourceLocation &loc,
                              const std::string &message) {
   diagnostics->error(loc, message).with_snippet(*source_manager);
 }
+// Im TypeChecker oder einem eigenen Pass:
 
+void TypeVisitor::register_builtins() {
+  // void print_int(int x)
+  register_extern("print_int", types.get_void(), {types.get_int()});
+  register_extern("println", types.get_void(), {});
+  register_extern("print_bool", types.get_void(), {types.get_bool()});
+  register_extern("print_char", types.get_void(), {types.get_int()});
+  register_extern("print_int_ln", types.get_void(), {types.get_int()});
+
+  // int read_int()
+  register_extern("read_int", types.get_int(), {});
+  register_extern("read_char", types.get_int(), {});
+
+  // void exit(int code)
+  register_extern("exit", types.get_void(), {types.get_int()});
+  register_extern("abort", types.get_void(), {});
+  register_extern("assert", types.get_void(), {types.get_bool()});
+}
+
+void TypeVisitor::register_extern(
+    const std::string &name, const source_type::Type *ret_type,
+    std::vector<const source_type::Type *> params) {
+
+  std::vector<source_type::QualType> param_quals;
+  param_quals.reserve(params.size());
+  for (auto *p : params)
+    param_quals.emplace_back(p);
+
+  auto *func_type =
+      types.get_function(source_type::QualType(ret_type), param_quals);
+  auto *sym =
+      symbol_table->create_function(name, {}, ret_type, func_type, true);
+  symbol_table->define(sym);
+}
 const source_type::Type *
 TypeVisitor::resolve_underlying(const source_type::Type *t) {
   return types.resolve_through_typedefs(t);

src/analysis/type_check.hpp

@@ -14,7 +14,7 @@ class TypeVisitor : public ASTVisitor {
   bool has_return = false;
 
   arena::Arena arena;
-  source_type::TypeRegistry types;
+  source_type::TypeRegistry &types;
 
   std::shared_ptr<DiagnosticEmitter> diagnostics;
   std::shared_ptr<SourceManager> source_manager;
@@ -25,15 +25,20 @@ class TypeVisitor : public ASTVisitor {
   const source_type::Type *resolve_underlying(const source_type::Type *t);
   bool is_small_type(const source_type::Type *t);
   const source_type::Type *lvalue_type(const LValue &val);
+  void register_builtins();
+  void register_extern(const std::string &name,
+                       const source_type::Type *ret_type,
+                       std::vector<const source_type::Type *> params);
 
 public:
   explicit TypeVisitor(std::shared_ptr<DiagnosticEmitter> diagnostics,
                        std::shared_ptr<SourceManager> source_manager,
-                       std::shared_ptr<SymbolTable> symbol_table)
+                       std::shared_ptr<SymbolTable> symbol_table,
+                       source_type::TypeRegistry &types)
       : diagnostics(std::move(diagnostics)),
         source_manager(std::move(source_manager)),
         symbol_table(std::move(symbol_table)), arena(arena::Arena{}),
-        types(arena) {}
+        types(types) {}
 
   // ── Top Level ────────────────────────────────────────
   void visit(TranslationUnit &unit) override;

src/defs/type.cpp

@@ -7,13 +7,10 @@ bool PointerType::equals(const Type &other) const {
   const auto &otherPtr = dynamic_cast<const PointerType &>(other);
   if (!to || !otherPtr.to)
     return !to && !otherPtr.to; // Both null or both not null
-  if (auto *struct_type = dynamic_cast<const StructType *>(otherPtr.to))
-    printf("%p: %s\n", otherPtr.to, struct_type->toString().c_str());
   return to->equals(*otherPtr.to);
 }
 bool StructType::equals(const Type &other) const {
 
-  printf("Struct eq: %s\n", other.toString().c_str());
   return other.kind == Kind::Struct &&
          name == dynamic_cast<const StructType &>(other).name;
 }

src/hir/hir_builder.cpp

@@ -168,8 +168,10 @@ hir::Value *HIRBuilder::build_load(hir::type::Type *loaded_type,
                                    hir::Value *ptr, std::string_view name) {
   auto *instruction = arena.create<hir::Instruction>(
       hir::Opcode::Load, loaded_type, std::vector<hir::Value *>{ptr});
+  std::cout << "Emitting load for types " << loaded_type->to_string()
+            << " ptr type: " << ptr->type->to_string() << std::endl;
   instruction->name = name;
-  instruction->type_arg = ptr->type;
+  instruction->type_arg = loaded_type;
   return insert(instruction);
 }
 
@@ -261,9 +263,6 @@ hir::Value *HIRBuilder::build_call(hir::Function *callee,
   assert(args.size() == callee->function_type->param_types.size() &&
          "argument count mismatch");
   for (size_t i = 0; i < args.size(); i++) {
-    std::cout << callee->to_string() << " args: " << args[i]->type->to_string()
-              << " " << callee->function_type->param_types[i]->to_string()
-              << std::endl;
     assert(args[i]->type == callee->function_type->param_types[i] &&
            "argument type mismatch");
   }