Skip to content

Potential issue with sorting #37

Description

@lb-

I just started to resolve wagtail/wagtail#10719 and have realised that our sorting rules could be causing some issues.

When I run the stylelint formatter / fixer on the Wagtail codebase I see that it's moving all our @include mixins to the top of the selector block.

// Mixins should always be first in declarations
'order/order': [
{
name: 'include',
type: 'at-rule',
},
'declarations',
],

From my understanding, this will actually cause a few problems where the styles will not be overridden at breakpoints.

Screenshot 2023-10-27 at 5 06 42 pm

Context of this change.

I know I merged this in but just wondering if there are some nuances for how mixins can be used that we should be allowing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions