Skip to content

RequestException is the base class exception? #134

Description

@nickmoreton

Suggestion:

I believe RequestException is the base class exception so if you want to keep it specific then it might be better to put this one last https://stackoverflow.com/a/47007419

I've added some snippets below which could work to shorten the code a little but I haven't got a lot of experience with exepction handling so not sure if they would be considered bad practise or not:

    except (requests.ConnectionError, requests.HTTPError, requests.ReadTimeout, requests.Timeout, requests.ConnectTimeout, requests.RequestException) as e :
        print(f"{type(e).__name__}: {src}")
        return None, False, None

or

    except Exception as e:
        print(f"{type(e).__name__}: {src}")
        return None, False, None

Originally posted by @Morsey187 in #125 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions