refactor(fetch): Use constants for LLM task names and add salary filter tests

Signed-off-by: wallentx <william.allentx@gmail.com>

Author: wallentx

internal/fetcher/job_fetcher.go

@@ -94,13 +94,13 @@ func fetchAllJobsWithCandidateCache(ctx context.Context, appCfg *AppConfig, crit
 	// 1. Fetch via LLM job search when enabled.
 	if appCfg.LLM.Enabled && appCfg.LLM.JobSearch {
 		llmSvc := getLLMService(ctx)
-		if !llmSvc.IsAvailable(ctx, "llm_job_search") {
+		if !llmSvc.IsAvailable(ctx, LLMTaskJobSearch) {
 			mu.Lock()
 			setFetchSearchStatus(&summary, fetchSearchLLM, "disabled: LLM job search runner unavailable")
 			mu.Unlock()
 		} else {
 			reportFetchProgress(progress, "Preparing LLM job search...")
-			llm, restoreAuth, initErr := llmSvc.InitConfiguredLLM(ctx, appCfg, llmTaskJobSearch)
+			llm, restoreAuth, initErr := llmSvc.InitConfiguredLLM(ctx, appCfg, LLMTaskJobSearch)
 			if initErr == nil {
 				defer restoreAuth()
 				promptBytes, err := fetchAllJobsReadFile(runtimeSearchPromptPath)
@@ -156,7 +156,7 @@ func fetchAllJobsWithCandidateCache(ctx context.Context, appCfg *AppConfig, crit
 		switch {
 		case !appCfg.LLM.Enabled:
 			setFetchSearchStatus(&summary, fetchSearchLLMWeb, "disabled: LLM is disabled in config")
-		case !getLLMService(ctx).IsAvailable(ctx, "llm_web_search"):
+		case !getLLMService(ctx).IsAvailable(ctx, LLMTaskWebSearch):
 			setFetchSearchStatus(&summary, fetchSearchLLMWeb, "disabled: LLM search runner unavailable")
 		case len(effectiveSources.LLMWebTargets) == 0:
 			setFetchSearchStatus(&summary, fetchSearchLLMWeb, "enabled, but no llm_web targets were configured or resolved")

internal/fetcher/job_fetcher_test.go

@@ -378,8 +378,8 @@ func TestFetchAllJobsLLMWebParseErrorIsSkipped(t *testing.T) {
 	prevSearch := fetchAllJobsExecuteLLMSearch
 	prevWebSearch := fetchAllJobsExecuteLLMWebSearch
 	fetchAllJobsInitConfiguredLLM = func(ctx context.Context, appCfg *AppConfig, task string) (llms.Model, func(), error) {
-		if task != llmTaskJobSearch {
-			t.Fatalf("fetchAllJobsInitConfiguredLLM task = %q, want %q", task, llmTaskJobSearch)
+		if task != LLMTaskJobSearch {
+			t.Fatalf("fetchAllJobsInitConfiguredLLM task = %q, want %q", task, LLMTaskJobSearch)
 		}
 		return fakeLLMModel{}, func() {}, nil
 	}
@@ -634,8 +634,8 @@ func TestFetchAllJobsLLMSearchRepairsIdentityBeforeValidation(t *testing.T) {
 	if applyGETRequests == 0 {
 		t.Fatal("fetchAllJobs() did not fetch the apply page for llm_job_search identity repair")
 	}
-	if len(initTasks) != 1 || initTasks[0] != llmTaskJobSearch {
-		t.Fatalf("fetchAllJobs() initialized LLM tasks %#v, want only %q", initTasks, llmTaskJobSearch)
+	if len(initTasks) != 1 || initTasks[0] != LLMTaskJobSearch {
+		t.Fatalf("fetchAllJobs() initialized LLM tasks %#v, want only %q", initTasks, LLMTaskJobSearch)
 	}
 	if got, want := jobs[0].CompanyWebsite, "https://www.acme.com"; got != want {
 		t.Fatalf("jobs[0].CompanyWebsite = %q, want %q", got, want)
@@ -2249,8 +2249,8 @@ func TestFetchAllJobsCombinesLLMAndRSSSources(t *testing.T) {
 	prevIdentity := fetchAllJobsEnrichJobIdentity
 	prevReadFile := fetchAllJobsReadFile
 	fetchAllJobsInitConfiguredLLM = func(ctx context.Context, appCfg *AppConfig, task string) (llms.Model, func(), error) {
-		if task != llmTaskJobSearch && task != llmTaskJobIdentity {
-			t.Fatalf("fetchAllJobsInitConfiguredLLM task = %q, want %q or %q", task, llmTaskJobSearch, llmTaskJobIdentity)
+		if task != LLMTaskJobSearch && task != llmTaskJobIdentity {
+			t.Fatalf("fetchAllJobsInitConfiguredLLM task = %q, want %q or %q", task, LLMTaskJobSearch, llmTaskJobIdentity)
 		}
 		return fakeLLMModel{}, func() {}, nil
 	}

internal/fetcher/job_filter_test.go

@@ -2,6 +2,43 @@ package fetcher
 
 import "testing"
 
+func TestExtractAndCheckSalary(t *testing.T) {
+	tests := []struct {
+		text    string
+		minBase int
+		want    bool
+	}{
+		{
+			text:    "Competitive / DOE",
+			minBase: 120000,
+			want:    true,
+		},
+		{
+			text:    "$90K - $150K",
+			minBase: 120000,
+			want:    true,
+		},
+		{
+			text:    "$80K - $95K",
+			minBase: 120000,
+			want:    false,
+		},
+		{
+			text:    "$118,000 - $231,000 USD/year",
+			minBase: 120000,
+			want:    true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.text, func(t *testing.T) {
+			if got := extractAndCheckSalary(tt.text, tt.minBase); got != tt.want {
+				t.Fatalf("extractAndCheckSalary(%q, %d) = %t; want %t", tt.text, tt.minBase, got, tt.want)
+			}
+		})
+	}
+}
+
 func TestJobMatchesWorkSettings(t *testing.T) {
 	tests := []struct {
 		name     string

internal/fetcher/job_identity_enricher.go

@@ -8,7 +8,7 @@ import (
 
 func newJobIdentityLLMEnricher(ctx context.Context, appCfg *AppConfig) (jobIdentityPageEnrichFunc, func(), string) {
 	llmSvc := getLLMService(ctx)
-	if appCfg == nil || !appCfg.LLM.Enabled || !llmSvc.IsAvailable(ctx, "llm_job_enrichment") {
+	if appCfg == nil || !appCfg.LLM.Enabled || !llmSvc.IsAvailable(ctx, LLMTaskJobEnrichment) {
 		return nil, nil, ""
 	}
 	llm, restoreAuth, err := llmSvc.InitConfiguredLLM(ctx, appCfg, llmTaskJobIdentity)

internal/fetcher/llm_hooks.go

@@ -8,7 +8,12 @@ import (
 	"github.com/tmc/langchaingo/llms"
 )
 
-const llmTaskJobSearch = "llm_job_search"
+const (
+	LLMTaskJobSearch     = "llm_job_search"
+	LLMTaskWebSearch     = "llm_web_search"
+	LLMTaskJobEnrichment = "llm_job_enrichment"
+)
+
 const llmTaskJobIdentity = "job_identity"
 
 type InitLLMFunc func(ctx context.Context, appCfg *AppConfig, task string) (llms.Model, func(), error)
@@ -78,7 +83,7 @@ func (fallbackLLMService) ExecuteWebSearch(ctx context.Context, appCfg *AppConfi
 	if fetchAllJobsInitConfiguredLLM == nil || fetchAllJobsExecuteLLMSearch == nil {
 		return nil, fmt.Errorf("LLM web search hook not configured")
 	}
-	llm, restoreAuth, err := fetchAllJobsInitConfiguredLLM(ctx, appCfg, llmTaskJobSearch)
+	llm, restoreAuth, err := fetchAllJobsInitConfiguredLLM(ctx, appCfg, LLMTaskJobSearch)
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize: %w", err)
 	}
@@ -94,13 +99,13 @@ func (fallbackLLMService) EnrichJobIdentity(ctx context.Context, llm llms.Model,
 }
 
 func (fallbackLLMService) IsAvailable(ctx context.Context, task string) bool {
-	if task == "llm_web_search" {
+	if task == LLMTaskWebSearch {
 		return fetchAllJobsExecuteLLMWebSearch != nil || (fetchAllJobsInitConfiguredLLM != nil && fetchAllJobsExecuteLLMSearch != nil)
 	}
-	if task == "llm_job_search" {
+	if task == LLMTaskJobSearch {
 		return fetchAllJobsInitConfiguredLLM != nil && fetchAllJobsExecuteLLMSearch != nil
 	}
-	if task == "llm_job_enrichment" {
+	if task == LLMTaskJobEnrichment {
 		return fetchAllJobsInitConfiguredLLM != nil && fetchAllJobsEnrichJobIdentity != nil
 	}
 	return false