Merge pull request #1863 from walt-id/policy-exceptions

Policy exceptions

Author: JakeFernandes98

waltid-libraries/credentials/waltid-verification-policies2/src/commonMain/kotlin/id/walt/policies2/vc/policies/status/StatusPolicyImplementation.kt

@@ -108,9 +108,9 @@ object StatusPolicyImplementation {
     private suspend fun processW3C(
         data: JsonElement,
         attribute: W3CStatusPolicyAttribute
-    ): Result<Unit> {
+    ): Result<Unit> = runCatching {
         val statusEntry = w3cEntryContentParser.parse(data)
-        return w3cStatusValidator.validate(statusEntry, attribute)
+        w3cStatusValidator.validate(statusEntry, attribute).getOrThrow()
     }
 
     private suspend fun processListW3C(
@@ -147,9 +147,9 @@ object StatusPolicyImplementation {
     private suspend fun processIETF(
         data: JsonElement,
         attribute: IETFStatusPolicyAttribute
-    ): Result<Unit> {
+    ): Result<Unit> = runCatching {
         val statusEntry = ietfEntryContentParser.parse(data)
-        return ietfStatusValidator.validate(statusEntry, attribute)
+        ietfStatusValidator.validate(statusEntry, attribute).getOrThrow()
     }
 
     private fun getStatusEntryElementExtractor(args: StatusPolicyArgument) = when (args) {

waltid-libraries/protocols/waltid-openid4vp-verifier/src/commonMain/kotlin/id/walt/verifier2/handlers/vpresponse/Verifier2SessionCredentialPolicyValidation.kt

@@ -37,7 +37,11 @@ object Verifier2SessionCredentialPolicyValidation {
                 policies.vc_policies?.policies.orEmpty().map { policy ->
                     async(Dispatchers.Default) {
                         log.trace { "Validating '$queryId' credential#$credentialIndex with policy '${policy.id}': $credential" }
-                        val result = policy.verify(credential, context)
+                        val result = runCatching { policy.verify(credential, context) }
+                            .getOrElse { ex ->
+                                log.warn { "Policy '${policy.id}' threw an unexpected exception for '$queryId' credential#$credentialIndex: ${ex.message}" }
+                                Result.failure(ex)
+                            }
                         log.trace { "'$queryId' credential#$credentialIndex '${policy.id}' result: $result" }
 
                         CredentialPolicyResult(
@@ -60,7 +64,11 @@ object Verifier2SessionCredentialPolicyValidation {
             credentials.flatMapIndexed { credentialIndex, specificCredential ->
                 queryPolicies.policies.map { policy ->
                     async(Dispatchers.Default) {
-                        val result = policy.verify(specificCredential, context)
+                        val result = runCatching { policy.verify(specificCredential, context) }
+                            .getOrElse { ex ->
+                                log.warn { "Specific policy '${policy.id}' threw an unexpected exception for '$queryId' credential#$credentialIndex: ${ex.message}" }
+                                Result.failure(ex)
+                            }
 
                         queryId to CredentialPolicyResult(
                             policy = policy,