hls2

Author: lws-team

AGENTS.md

@@ -3,11 +3,13 @@
 ## Overview
 
 Please err on the side of high quality, not lazy, implementation decisions, because the code
-will have to be maintained for a long time.  And everybody, LLM or person, is able to work
+will have to be maintained for a long time.  Everybody, LLM or person, is able to work
 better if we keep the code clean and to a high standard to start with.
 
 Even if your instructions don't include specific admonishment about quality, it is always
-necessary.
+necessary.  Lws started in 2010 the main goal when working on a feature is to
+improve the library with the feature.  That means shortcuts and desperate
+incomplete hacks to deliver the feature are always wrong.
 
 Our work should follow the existing usage of apis in the project as much as possible.
 
@@ -54,14 +56,17 @@ We are very concerned about security, architecturally and in the code.  We avoid
 
  - `FILE *` and use apis like open(), read().
 
- - casual linked-lists and use `lws_dll2_t`.
+ - hand-rolled ad-hoc code when there are library helpers, eg no casual
+   linked-lists; use `lws_dll2_t` instead.
 
 We consider using:
 
  - lwsac instead of discrete allocations, if the pattern of allocations will benefit from it.
 
  - lws_struct to convert between sqlite storage <-> structs <-> JSON
 
+ - lws_tokenize instead of strtok() and variants
+
 We are very concerned about portability and all builds occur with -Werror -Wall -Wextra.
 
 ## Appropriate locality
@@ -109,7 +114,7 @@ commands for the platform.
 
 minimal-examples-lowlevel/http-client/minimal-http-client-post/CMakeLists.txt shows how to use the fixtures
 stuff to magic peers into being while being sensitive to parallel CI using a CMake unique socket allocator
-function to make unique ports.
+function to select unique ports.
 
 In the case you can build and run ctest meaningfully, please do confirm the build passes before completing
 work on your goal.  Use parallel builds and eg, ctest -j8 to reduce the cost in realtime.

lib/core-net/client/connect3.c

@@ -515,7 +515,7 @@ lws_client_connect_3_connect(struct lws *wsi, const char *ads,
 
 					if (wsi->a.context->event_loop_ops->promote_parallel)
 						wsi->a.context->event_loop_ops->promote_parallel(wsi, pidx);
-					else
+					else if (lws_socket_is_valid(wsi->desc.sockfd))
 						compatible_close(wsi->desc.sockfd);
 
 					promote_parallel_fd(wsi, pidx);

minimal-examples-lowlevel/http-server/minimal-http-server-hls/media/Big_Buck_Bunny_360_10s_1MB.es.srt

@@ -0,0 +1,13 @@
+1
+00:00:00,500 --> 00:00:02,800
+[Big Buck Bunny] Subtitulo de prueba uno.
+
+2
+00:00:03,000 --> 00:00:05,500
+Este es el subtitulo dos,
+cruzando un limite de segmento.
+
+3
+00:00:06,200 --> 00:00:09,000
+Subtitulo tres en el mismo segmento
+que el dos.

minimal-examples-lowlevel/http-server/minimal-http-server-hls/media/Big_Buck_Bunny_360_10s_1MB.srt

@@ -0,0 +1,13 @@
+1
+00:00:00,500 --> 00:00:02,800
+[Big Buck Bunny] Test subtitle cue one.
+
+2
+00:00:03,000 --> 00:00:05,500
+This is cue two, spanning a
+segment boundary at ~5s.
+
+3
+00:00:06,200 --> 00:00:09,000
+Cue three lands in the same segment
+as cue two, to test multi-cue output.

minimal-examples-lowlevel/http-server/minimal-http-server-hls/mount-origin/player.css

@@ -23,6 +23,28 @@ video {
     height: auto;
     display: block;
 }
+
+/* Subtitle cue rendering. Cues arrive via the native <track> element that
+ * hls.js creates (renderTextTracksNatively). Font-size is expressed in vh
+ * units so it scales with the viewport (and thus the actual rendered video
+ * size) rather than the tiny default; in fullscreen it grows further via the
+ * :fullscreen rule below. The cue vertical position (VTTCue.line) is set in
+ * player.js, which also lifts cues higher when fullscreen so they clear
+ * tablet camera cutouts at the bottom edge. */
+video::cue {
+    font-size: 2.2vh;
+    line-height: 1.25;
+    background: rgba(0, 0, 0, 0.72);
+    color: #ffffff;
+    white-space: pre-wrap;
+}
+/* In fullscreen the video fills the viewport; bump the cue font to match the
+   larger frame (proportional to the size increase, not the same fixed size). */
+video:fullscreen::cue,
+video:-webkit-full-screen::cue {
+    font-size: 3.4vh;
+    line-height: 1.3;
+}
 .header {
     width: 100%;
     max-width: 800px;
@@ -63,8 +85,22 @@ video {
     width: 100%;
     max-width: 800px;
     display: flex;
-    justify-content: flex-end;
+    justify-content: space-between;
+    align-items: center;
     margin-top: 10px;
+    gap: 12px;
+}
+
+.button-group {
+    display: flex;
+    align-items: center;
+    gap: 8px;
+}
+
+/* put a little air between adjacent controls inside a group */
+.button-group .toggle-btn,
+.button-group select.toggle-btn {
+    margin-right: 0;
 }
 
 .toggle-btn {
@@ -85,6 +121,18 @@ video {
     color: #ffffff;
 }
 
+/* "on" state, used for the CC toggle */
+.toggle-btn.active {
+    background-color: #2a7a2a;
+    color: #ffffff;
+    border-color: #3a9a3a;
+}
+
+#sub-lang {
+    padding: 5px 8px;
+    cursor: pointer;
+}
+
 .video-title {
     color: #888888;
     font-size: 14px;

minimal-examples-lowlevel/http-server/minimal-http-server-hls/mount-origin/player.html

@@ -23,7 +23,11 @@ <h2>LWS Media Player</h2>
     </div>
 
     <div class="button-container">
-        <button id="toggle-logs-btn" class="toggle-btn">logs</button>
+        <div class="button-group">
+            <button id="toggle-logs-btn" class="toggle-btn">logs</button>
+            <select id="sub-lang" class="toggle-btn hidden" title="Subtitle language"></select>
+            <button id="cc-btn" class="toggle-btn hidden" title="Toggle subtitles">CC</button>
+        </div>
         <button id="delete-btn" class="toggle-btn hidden" style="background: #cc0000;">&#x1F5D1; delete</button>
     </div>