feat: add core no-redeclare rule

Author: fansenze

internal/plugins/typescript/rules/no_redeclare/no_redeclare.go

@@ -69,6 +69,7 @@ func TestNoRedeclareRule(t *testing.T) {
 			// declarations are module-scoped and do not merge with lib globals.
 			{Code: "export {};\nvar Object = 0;", Options: map[string]interface{}{"builtinGlobals": true}},
 			{Code: "import {} from './foo';\nvar Array = 0;", Options: map[string]interface{}{"builtinGlobals": true}},
+			{Code: "export {};\n/*globals Array */", Options: map[string]interface{}{"builtinGlobals": true}},
 
 			// ====================================================================
 			// TypeScript declaration merging (default ignoreDeclarationMerge: true).
@@ -246,8 +247,8 @@ func TestNoRedeclareRule(t *testing.T) {
 			// interfaces in different declaration spaces. ESLint, which does
 			// name-level matching, flags these. We intentionally don't.
 			// ====================================================================
-			{Code: "type NodeListOf = 1;"},                      // lib.dom
-			{Code: "type HTMLElement = 1;"},                     // lib.dom
+			{Code: "type NodeListOf = 1;"},  // lib.dom
+			{Code: "type HTMLElement = 1;"}, // lib.dom
 			{Code: "type Array = 1;", Options: map[string]interface{}{"builtinGlobals": true}}, // lib.es5 core interface
 			// Extending a lib interface with a same-named user interface is
 			// the idiomatic TS pattern (ImportMeta augmentation, etc.) — it
@@ -516,6 +517,13 @@ func TestNoRedeclareRule(t *testing.T) {
 					{MessageId: "redeclaredAsBuiltin", Line: 1, Column: 5},
 				},
 			},
+			{
+				Code: "/*globals Array */",
+				Errors: []rule_tester.InvalidTestCaseError{
+					{MessageId: "redeclaredAsBuiltin", Line: 1, Column: 11},
+				},
+				Options: map[string]interface{}{"builtinGlobals": true},
+			},
 			// ====================================================================
 			// Documented divergence #1 (see no_redeclare.md):
 			// `builtinGlobals` resolves against the project's `lib` configuration

internal/plugins/typescript/rules/no_redeclare/no_redeclare_test.go

@@ -86,6 +86,7 @@ import (
 	"github.com/web-infra-dev/rslint/internal/rules/no_param_reassign"
 	"github.com/web-infra-dev/rslint/internal/rules/no_proto"
 	"github.com/web-infra-dev/rslint/internal/rules/no_prototype_builtins"
+	"github.com/web-infra-dev/rslint/internal/rules/no_redeclare"
 	"github.com/web-infra-dev/rslint/internal/rules/no_regex_spaces"
 	"github.com/web-infra-dev/rslint/internal/rules/no_restricted_imports"
 	"github.com/web-infra-dev/rslint/internal/rules/no_restricted_syntax"
@@ -222,6 +223,7 @@ func GetAllRules() []rule.Rule {
 		no_octal_escape.NoOctalEscapeRule,
 		no_param_reassign.NoParamReassignRule,
 		no_proto.NoProtoRule,
+		no_redeclare.NoRedeclareRule,
 		radix.RadixRule,
 		no_regex_spaces.NoRegexSpacesRule,
 		no_return_assign.NoReturnAssignRule,

internal/rules/all.go

@@ -8,29 +8,6 @@ import (
 	"github.com/web-infra-dev/rslint/internal/utils"
 )
 
-// builtinGlobals contains names of known read-only built-in globals.
-var builtinGlobals = map[string]bool{
-	"AggregateError": true, "Array": true, "ArrayBuffer": true, "AsyncDisposableStack": true,
-	"AsyncIterator": true, "Atomics": true,
-	"BigInt": true, "BigInt64Array": true, "BigUint64Array": true,
-	"Boolean": true, "DataView": true, "Date": true,
-	"decodeURI": true, "decodeURIComponent": true, "DisposableStack": true,
-	"encodeURI": true, "encodeURIComponent": true,
-	"Error": true, "escape": true, "EvalError": true,
-	"FinalizationRegistry": true, "Float32Array": true, "Float64Array": true, "Function": true,
-	"globalThis": true, "Infinity": true, "Int8Array": true,
-	"Int16Array": true, "Int32Array": true, "Intl": true, "isFinite": true,
-	"isNaN": true, "Iterator": true, "JSON": true, "Map": true, "Math": true,
-	"NaN": true, "Number": true, "Object": true, "parseFloat": true,
-	"parseInt": true, "Promise": true, "Proxy": true, "RangeError": true,
-	"ReferenceError": true, "Reflect": true, "RegExp": true,
-	"Set": true, "SharedArrayBuffer": true, "String": true, "SuppressedError": true,
-	"Symbol": true, "SyntaxError": true, "TypeError": true,
-	"Uint8Array": true, "Uint8ClampedArray": true, "Uint16Array": true,
-	"Uint32Array": true, "unescape": true, "URIError": true, "undefined": true,
-	"WeakMap": true, "WeakRef": true, "WeakSet": true,
-}
-
 type options struct {
 	exceptions map[string]bool
 }
@@ -78,7 +55,7 @@ var NoGlobalAssignRule = rule.Rule{
 		return rule.RuleListeners{
 			ast.KindIdentifier: func(node *ast.Node) {
 				name := node.Text()
-				if !builtinGlobals[name] || opts.exceptions[name] {
+				if !utils.IsECMAScriptGlobal(name) || opts.exceptions[name] {
 					return
 				}