Skip to content

Commit 4be7050

Browse files
committed
ci: restore ut and full e2e test run
1 parent 5ad17bf commit 4be7050

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

.github/workflows/test.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,7 @@ jobs:
8686
# ======== ut ========
8787
ut:
8888
needs: prepare
89-
# Temporarily skip ut entirely while focusing on watch e2e under the
90-
# @rspack-canary/core override. Restore by switching back to the original
91-
# `if: needs.prepare.outputs.changed == 'true'`.
92-
if: false
89+
if: needs.prepare.outputs.changed == 'true'
9390
runs-on: ${{ matrix.os }}
9491
timeout-minutes: 15
9592
strategy:
@@ -153,8 +150,7 @@ jobs:
153150

154151
# ======== e2e ========
155152
e2e:
156-
# `ut` is temporarily disabled; drop it from `needs` until ut is re-enabled.
157-
needs: [prepare, lint]
153+
needs: [prepare, lint, ut]
158154
if: needs.prepare.outputs.changed == 'true'
159155
runs-on: ${{ matrix.os }}
160156
timeout-minutes: 15
@@ -248,10 +244,8 @@ jobs:
248244
find e2e/node_modules /Users/runner/work/rstest/rstest/node_modules \
249245
-name 'rspack.darwin-arm64.node' 2>/dev/null | xargs -I{} ls -lh {} || true
250246
251-
# Temporarily filter to watch-related e2e cases. Restore by removing the
252-
# trailing `watch` argument.
253247
- name: E2E Test (${{ matrix.test_script }})
254-
run: cd e2e && pnpm ${{ matrix.test_script }} watch
248+
run: cd e2e && pnpm ${{ matrix.test_script }}
255249

256250
# RCA debug: a canary rspack build with file-level trace writes to
257251
# /tmp/rca-binding-trace.log inside the runner. Dump it on failure

0 commit comments

Comments
 (0)