WebKit export tool does not add wpt-pr-bot as a reviewer (but leaves a comment)

[graouts]

I've exported a few WebKit changes to the WPT repository using the appropriate export tool (Tools/Scripts/export-w3c-test-changes) and the result has been that wpt-pr-bot leaves the "This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+." comment but is not added as a reviewer leaving the PR with no assigned reviewer. Here's the most recent example: web-platform-tests/wpt#50756.

[gsnedders]

Compare: web-platform-tests/wpt#50755

[gsnedders]

Maybe this is just another way in which #164 fails? I'm not sure I totally understand the code-flow here.

[gsnedders]

Oh, your WebKit bug is still open, so the one situation that applies to WebKit GitHub PRs doesn't apply, therefore we don't conclude it has been reviewed yet:

wpt-pr-bot/lib/metadata/webkit.js

Lines 43 to 47 in f03de16

	if (change.field_name == "resolution") {
	if (change.added.includes("FIXED") && ["ews-feeder@webkit.org", "commit-queue@webkit.org"].includes(history_item.who)) {
	flags.reviewed = true;
	flags.inCommit = true;
	}

I agree the state of the WPT PR could be clearer in this case, for example adding itself as a reviewer anyway.

See:

wpt-pr-bot/lib/comment.js

Lines 44 to 46 in f03de16

	// WebKit has a slightly different flow than other browser exports. The PR
	// is not automatically approved; instead we wait for r+ downstream. In the
	// meantime, we shouldn't assign anyone to it.

[graouts]

I could be wrong, and in fact given all of the above I most likely am, but I've only noticed this recently and I've always used Tools/Scripts/export-w3c-test-changes after creating a WebKit PR, ie. when the bugzilla bug is very much open.