chore: update addEffect

Author: antsukanova

src/media/local-audio-stream.spec.ts

@@ -310,6 +310,23 @@ describe('LocalAudioStream', () => {
       expect(effect.replaceInputTrack).not.toHaveBeenCalled();
     });
 
+    it('should not register duplicate constraint handlers when addEffect is called with the same effect', async () => {
+      expect.hasAssertions();
+
+      const onCalls = (effect.on as jest.Mock).mock.calls;
+      const initialConstraintsRequiredCount = onCalls.filter(
+        ([event]: [string]) => event === 'constraints-required'
+      ).length;
+
+      await audioLocalStream.addEffect(effect);
+
+      const afterConstraintsRequiredCount = onCalls.filter(
+        ([event]: [string]) => event === 'constraints-required'
+      ).length;
+
+      expect(afterConstraintsRequiredCount).toBe(initialConstraintsRequiredCount);
+    });
+
     it('should not register audio constraint handlers for video tracks', async () => {
       expect.hasAssertions();
 

src/media/local-audio-stream.ts

@@ -18,8 +18,11 @@ export class LocalAudioStream extends LocalStream {
    * @inheritdoc
    */
   async addEffect(effect: TrackEffect): Promise<void> {
-    await super.addEffect(effect);
+    if (this.effects.some((e) => e.id === effect.id)) {
+      return;
+    }
     this.addConstraintHandlers(effect);
+    await super.addEffect(effect);
   }
 
   /**
@@ -186,13 +189,13 @@ export class LocalAudioStream extends LocalStream {
      * The base class handles its own listener cleanup separately.
      */
     const removeConstraintHandlers = () => {
-      effect.off('constraints-required' as EffectEvent, handleConstraintsRequired);
-      effect.off('constraints-released' as EffectEvent, handleConstraintsReleased);
-      effect.off('disposed' as EffectEvent, removeConstraintHandlers);
+      effect.off('constraints-required' as EffectEvent, handleConstraintsRequired as never);
+      effect.off('constraints-released' as EffectEvent, handleConstraintsReleased as never);
+      effect.off('disposed' as EffectEvent, removeConstraintHandlers as never);
     };
 
-    effect.on('constraints-required' as EffectEvent, handleConstraintsRequired);
-    effect.on('constraints-released' as EffectEvent, handleConstraintsReleased);
-    effect.on('disposed' as EffectEvent, removeConstraintHandlers);
+    effect.on('constraints-required' as EffectEvent, handleConstraintsRequired as never);
+    effect.on('constraints-released' as EffectEvent, handleConstraintsReleased as never);
+    effect.on('disposed' as EffectEvent, removeConstraintHandlers as never);
   }
 }