Skip to content

Commit 1406aa2

Browse files
author
Christina Mullen
committed
update pr comments
1 parent e8a783a commit 1406aa2

23 files changed

Lines changed: 294 additions & 282 deletions

File tree

packages/contact-center/cc-components/src/components/task/CampaignTask/CampaignTaskListItem/campaign-task-list-item.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22
import {Avatar, Button, ListItem, Text, Tooltip} from '@momentum-design/components/dist/react';
33
import CampaignCountdown from '../../CampaignCountdown/campaign-countdown';
44
import TaskTimer from '../../TaskTimer/index';
5-
import {CampaignTaskListItemProps} from './campaign-task-list-item.types';
5+
import {CampaignTaskListItemProps} from '../../task.types';
66
import {
77
CAMPAIGN_ACCEPT,
88
CAMPAIGN_CONNECTING,

packages/contact-center/cc-components/src/components/task/CampaignTask/CampaignTaskListItem/campaign-task-list-item.types.ts

Lines changed: 0 additions & 61 deletions
This file was deleted.

packages/contact-center/cc-components/src/components/task/CampaignTask/CampaignTaskPopover/campaign-task-popover.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import React, {useRef} from 'react';
22
import {Popover} from '@momentum-design/components/dist/react';
33
import CampaignTaskListItem from '../CampaignTaskListItem/campaign-task-list-item';
44
import GlobalVariablesPanel from '../../GlobalVariablesPanel/global-variables-panel';
5-
import {CampaignTaskPopoverProps} from './campaign-task-popover.types';
6-
import {CallAssociatedDataMap, getCallerIdentifier} from '../../task.types';
5+
import {CampaignTaskPopoverProps, CallAssociatedDataMap, getCallerIdentifier} from '../../task.types';
76
import {getAgentViewableGlobalVariables} from '../../Task/task.utils';
87
import {getCampaignCpd} from '../../TaskList/task-list.utils';
98
import './campaign-task-popover.style.scss';
Lines changed: 1 addition & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,49 +1 @@
1-
import {ILogger, ITask} from '@webex/cc-store';
2-
3-
/**
4-
* Properties for the CampaignTaskPopover component.
5-
*
6-
* Displays a hover popover over the campaign preview task with the
7-
* ListItem row (avatar, title, phone, countdown, action buttons)
8-
* and a two-column scrollable data panel of global variables.
9-
*/
10-
export interface CampaignTaskPopoverProps {
11-
/** The campaign preview task. */
12-
task: ITask;
13-
14-
/** Logger instance for logging purposes. */
15-
logger?: ILogger;
16-
17-
/** ID of the trigger element that opens the popover on hover. */
18-
triggerId: string;
19-
20-
/** Whether the Accept button has been clicked (shows "Connecting..." state). */
21-
isAcceptClicked: boolean;
22-
23-
/** Whether the campaign preview has been accepted by the backend (call controls visible). */
24-
isAccepted: boolean;
25-
26-
/** Whether the Accept button is disabled. */
27-
isAcceptDisabled: boolean;
28-
29-
/** Whether the Skip button is disabled. */
30-
isSkipDisabled: boolean;
31-
32-
/** Whether the Remove button is disabled. */
33-
isRemoveDisabled: boolean;
34-
35-
/** Handler for Accept button click. */
36-
onAccept: () => void;
37-
38-
/** Handler for Skip button click. */
39-
onSkip: () => void;
40-
41-
/** Handler for Remove button click. */
42-
onRemove: () => void;
43-
44-
/** Handler for countdown timeout. */
45-
onTimeout: () => void;
46-
47-
/** Timestamp (ms) when the campaign call was accepted — used for the handle time timer. */
48-
handleTimestamp?: number;
49-
}
1+
// Types moved to ../../task.types.ts — import from there instead.

packages/contact-center/cc-components/src/components/task/CampaignTask/campaign-task.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ import {
1111
CampaignAutoAction,
1212
CAMPAIGN_ACTION_ERROR_MAP,
1313
CampaignErrorActionType,
14-
} from './campaign-task.types';
15-
import {CallAssociatedDataMap, getCallerIdentifier} from '../task.types';
14+
CallAssociatedDataMap,
15+
getCallerIdentifier,
16+
} from '../task.types';
1617
import {getAgentViewableGlobalVariables} from '../Task/task.utils';
1718
import {CANCEL, CAMPAIGN_TASK_REGION_LABEL} from '../constants';
1819
import {getAgentJoinTimestamp, getCampaignCpd} from '../TaskList/task-list.utils';

packages/contact-center/cc-components/src/components/task/CampaignTask/campaign-task.types.ts

Lines changed: 0 additions & 113 deletions
This file was deleted.

packages/contact-center/cc-components/src/components/task/GlobalVariablesPanel/global-variables-panel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import {Text} from '@momentum-design/components/dist/react';
3-
import {GlobalVariablesPanelProps} from './global-variables-panel.types';
3+
import {GlobalVariablesPanelProps} from '../task.types';
44
import {GLOBAL_VARIABLES_LABEL} from '../constants';
55
import './global-variables-panel.style.scss';
66

packages/contact-center/cc-components/src/components/task/GlobalVariablesPanel/global-variables-panel.types.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

packages/contact-center/cc-components/src/components/task/TaskList/task-list.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import React from 'react';
22
import {ErrorBoundary} from 'react-error-boundary';
33
import {withMetrics} from '@webex/cc-ui-logging';
4-
import {TaskListComponentProps, MEDIA_CHANNEL} from '../task.types';
4+
import {TaskListComponentProps, MEDIA_CHANNEL, CampaignCallProcessingDetails} from '../task.types';
55
import Task from '../Task';
66
import CampaignTask from '../CampaignTask/campaign-task';
7-
import {CampaignCallProcessingDetails} from '../CampaignTask/campaign-task.types';
87
import {
98
extractTaskListItemData,
109
isTaskListEmpty,

packages/contact-center/cc-components/src/components/task/TaskList/task-list.utils.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import {MEDIA_CHANNEL, TaskListItemData, getCallerIdentifier} from '../task.types';
2-
import {CampaignCallProcessingDetails} from '../CampaignTask/campaign-task.types';
1+
import {MEDIA_CHANNEL, TaskListItemData, getCallerIdentifier, CampaignCallProcessingDetails} from '../task.types';
32
import store, {isIncomingTask, ILogger, ITask} from '@webex/cc-store';
43

54
interface ParticipantWithJoin {

0 commit comments

Comments
 (0)