Vercel edge middleware (incorrectly*) documented to run on static files

[qw-in]

📚 Subject area/topic

Vercel adapter edge middleware feature

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/en/guides/integrations-guide/vercel/#running-astro-middleware-on-vercel-edge-functions

📋 Description of content that is out-of-date or incorrect

When edgeMiddleware is enabled, an edge function will execute your middleware code for all requests including static assets, prerendered pages, and on-demand rendered pages.

This does not appear to be true in my testing. Like other middleware it appears to only run on on-demand pages. See withastro/astro#10536 (comment)

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

This is a tricky one but I can put something together if necessary

[sarah11918]

I can see that was quite an old issue linked, and I'm not sure whether anything might have changed, so I'll ask @ematipico to confirm what the correct thing to document should be!

[ematipico]

Mmmh, to be honest I'm not sure what's the correct behaviour on Vercel. I thought that their edge middleware runs before the request of each page, static assets pages too. If it's not the case, we can change the documentation

[qw-in]

Thanks, quite busy this week but I'll try to deploy something maybe next week and open a PR based on the results

[sarah11918]

Just wondering whether you're still interested in following up with this @qw-in ! We'll need someone to test and confirm with a reproduction before we can update any docs.

[florian-lefebvre]

I've setup a vercel edge middleware on top of a static starlight site this week and AFAIK it runs even for static assets! For the record, I'm using a vercel middleware, not the Astro middleware + the edgeMiddleware: true vercel integration option so maybe it behaves differently