ref: removes connection closes planned for a separate PR

gomaja · gomaja · commit 5cf050a987dc · 2025-06-11T16:18:28.000+03:00
diff --git a/aspsm.go b/aspsm.go
@@ -17,7 +17,6 @@ func (c *Conn) initiateASPSM() error {
 }
 func (c *Conn) handleAspUp(aspUp *messages.AspUp) error {
 	if c.State() != StateAspDown {
-		defer c.Close() // Provided to handle bugs from peer STPs
 		return NewErrUnexpectedMessage(aspUp)
 
 	}
@@ -49,7 +48,6 @@ func (c *Conn) handleAspUpAck(aspUpAck *messages.AspUpAck) error {
 }
 
 func (c *Conn) handleAspDown(aspDown *messages.AspDown) error {
-	c.Close() // Closing the connection to close the dataChan, to avoid the Read function keeping blocked on the channel.
 	switch c.State() {
 	case StateAspInactive, StateAspActive:
 		return NewErrUnexpectedMessage(aspDown)

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ func (c *Conn) initiateASPSM() error {`
`17`	`17`	`}`
`18`	`18`	`func (c Conn) handleAspUp(aspUp messages.AspUp) error {`
`19`	`19`	`if c.State() != StateAspDown {`
`20`		`- defer c.Close() // Provided to handle bugs from peer STPs`
`21`	`20`	`return NewErrUnexpectedMessage(aspUp)`
`22`	`21`
`23`	`22`	`}`
`@@ -49,7 +48,6 @@ func (c Conn) handleAspUpAck(aspUpAck messages.AspUpAck) error {`
`49`	`48`	`}`
`50`	`49`
`51`	`50`	`func (c Conn) handleAspDown(aspDown messages.AspDown) error {`
`52`		`- c.Close() // Closing the connection to close the dataChan, to avoid the Read function keeping blocked on the channel.`
`53`	`51`	`switch c.State() {`
`54`	`52`	`case StateAspInactive, StateAspActive:`
`55`	`53`	`return NewErrUnexpectedMessage(aspDown)`