Commit 151e151
committed
fix(bar): give ProgressBarBase an explicit __del__ chain (CodeQL missing-call-to-delete)
CodeQL flagged ProgressBarBase (Iterable + ProgressBarMixinBase multiple
inheritance) for finalizing without an explicit __del__ calling the base
finalizer. Revert the earlier wrong-class guarded super().__del__() in
ProgressBarMixinBase and define ProgressBarBase.__del__ = super().__del__(),
which resolves to the same ProgressBarMixinBase.__del__ reached by
inheritance — behaviourally identical, MI chain now explicit.1 parent 1395a47 commit 151e151
1 file changed
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | 178 | | |
186 | 179 | | |
187 | 180 | | |
| |||
214 | 207 | | |
215 | 208 | | |
216 | 209 | | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
217 | 219 | | |
218 | 220 | | |
219 | 221 | | |
| |||
0 commit comments