fix(todos): use addDismissedTodo thunk to prevent stale closure on dismiss

dismissTodo was closing over dismissedTodos from the last render. When
the parent component did not re-render after the first dismiss, the
second dismiss called setDismissedTodos with only the new id, overwriting
the previously dismissed one and causing it to reappear stuck with the
is-dismissing class.

Author: Narek13

modules/ppcp-settings/resources/js/data/todos/hooks.js

@@ -38,7 +38,7 @@ const useStoreData = () => {
 
 const useHooks = () => {
 	const { dispatch, select } = useStoreData();
-	const { fetchTodos, setDismissedTodos, setCompletedTodos } = dispatch;
+	const { fetchTodos, addDismissedTodo, setCompletedTodos } = dispatch;
 
 	// Get todos data from store
 	const todos = select.getTodos();
@@ -47,12 +47,7 @@ const useHooks = () => {
 
 	const dismissedSet = new Set( dismissedTodos );
 
-	const dismissTodo = async ( todoId ) => {
-		if ( ! dismissedSet.has( todoId ) ) {
-			const newDismissedTodos = [ ...dismissedTodos, todoId ];
-			await setDismissedTodos( newDismissedTodos );
-		}
-	};
+	const dismissTodo = ( todoId ) => addDismissedTodo( todoId );
 
 	const setTodoCompleted = async ( todoId, isCompleted ) => {
 		let newCompletedTodos;