🧪 Update PartnersEndpointTest and fix SellerStatusFilter docblocks

Author: danieldudzic

modules/ppcp-api-client/src/Helper/SellerStatusFilter.php

@@ -23,9 +23,14 @@
 use WooCommerce\PayPalCommerce\ApiClient\Entity\SellerStatusCapability;
 use WooCommerce\PayPalCommerce\ApiClient\Entity\SellerStatusProduct;
 
+/**
+ * Class SellerStatusFilter
+ */
 class SellerStatusFilter {
 
 	/**
+	 * Complete fallback SellerStatus used when the API call fails.
+	 *
 	 * @var SellerStatus|null
 	 */
 	private ?SellerStatus $fallback = null;
@@ -66,6 +71,8 @@ class SellerStatusFilter {
 	private array $removed_capabilities = array();
 
 	/**
+	 * Country override, or null to keep the original value.
+	 *
 	 * @var string|null
 	 */
 	private ?string $country_override = null;
@@ -82,10 +89,20 @@ public function set_fallback( SellerStatus $fallback ): self {
 		return $this;
 	}
 
+	/**
+	 * Returns the fallback SellerStatus, or null if none is set.
+	 *
+	 * @return SellerStatus|null
+	 */
 	public function get_fallback(): ?SellerStatus {
 		return $this->fallback;
 	}
 
+	/**
+	 * Whether a fallback is configured.
+	 *
+	 * @return bool
+	 */
 	public function has_fallback(): bool {
 		return null !== $this->fallback;
 	}
@@ -171,8 +188,7 @@ public function override_country( string $country ): self {
 	 * Whether any transformations have been registered.
 	 */
 	public function has_modifications(): bool {
-		return $this->fallback !== null
-			|| ! empty( $this->product_capability_additions )
+		return ! empty( $this->product_capability_additions )
 			|| ! empty( $this->product_capability_removals )
 			|| ! empty( $this->removed_products )
 			|| ! empty( $this->ensured_capabilities )

tests/PHPUnit/ApiClient/Endpoint/PartnersEndpointTest.php

@@ -13,6 +13,7 @@
 use WooCommerce\PayPalCommerce\ApiClient\Factory\SellerStatusFactory;
 use WooCommerce\PayPalCommerce\ApiClient\Helper\Cache;
 use WooCommerce\PayPalCommerce\ApiClient\Helper\FailureRegistry;
+use WooCommerce\PayPalCommerce\ApiClient\Helper\SellerStatusFilter;
 use WooCommerce\PayPalCommerce\TestCase;
 use function Brain\Monkey\Functions\expect;
 use function Brain\Monkey\Functions\when;
@@ -78,7 +79,7 @@ public function setUp(): void
 	// Factory helper
 	// -----------------------------------------------------------------------
 
-	private function make_endpoint(): PartnersEndpoint
+	private function make_endpoint(?SellerStatusFilter $filter = null): PartnersEndpoint
 	{
 		return new PartnersEndpoint(
 			self::HOST,
@@ -88,7 +89,8 @@ private function make_endpoint(): PartnersEndpoint
 			self::PARTNER_ID,
 			self::MERCHANT_ID,
 			$this->failure_registry,
-			$this->cache
+			$this->cache,
+			$filter ?? new SellerStatusFilter()
 		);
 	}