♻️ Replace number_format with CartHelper method

Author: stracker-phil

modules/ppcp-store-sync/src/CartValidation/CouponValidator/CouponContextBuilder.php

@@ -193,9 +193,9 @@ private function build_minimum_spend( string $code, PayPalCart $cart, ?WC_Coupon
 		$currency = CartHelper::currency( $cart, get_woocommerce_currency() );
 
 		return array(
-			'minimum_required' => number_format( $minimum, 2, '.', '' ),
-			'current_subtotal' => number_format( $subtotal, 2, '.', '' ),
-			'shortage_amount'  => number_format( $shortage, 2, '.', '' ),
+			'minimum_required' => CartHelper::format_decimal( $minimum ),
+			'current_subtotal' => CartHelper::format_decimal( $subtotal ),
+			'shortage_amount'  => CartHelper::format_decimal( $shortage ),
 			'currency_code'    => $currency,
 		);
 	}
@@ -219,8 +219,8 @@ private function build_maximum_spend( string $code, PayPalCart $cart, ?WC_Coupon
 		$currency = CartHelper::currency( $cart, get_woocommerce_currency() );
 
 		return array(
-			'maximum_allowed'  => number_format( $maximum, 2, '.', '' ),
-			'current_subtotal' => number_format( $subtotal, 2, '.', '' ),
+			'maximum_allowed'  => CartHelper::format_decimal( $maximum ),
+			'current_subtotal' => CartHelper::format_decimal( $subtotal ),
 			'currency_code'    => $currency,
 		);
 	}

modules/ppcp-store-sync/src/CartValidation/CouponValidator/DiscountCalculator.php

@@ -15,6 +15,7 @@
 use WC_Discounts;
 use WooCommerce\PayPalCommerce\StoreSync\Helper\ProductManager;
 use WooCommerce\PayPalCommerce\StoreSync\Schema\PayPalCart;
+use WooCommerce\PayPalCommerce\StoreSync\Helper\CartHelper;
 
 /**
  * Calculates discount amounts for coupons using WooCommerce's native discount calculation.
@@ -70,8 +71,7 @@ public function calculate_discount_amount( WC_Coupon $wc_coupon, PayPalCart $car
 				? array_sum( $totals[ $code ] )
 				: $totals[ $code ];
 
-			// The value from get_discounts_by_coupon() is already in regular decimal format.
-			return number_format( $discount_value, 2, '.', '' );
+			return CartHelper::format_decimal( $discount_value );
 		}
 
 		return '0.00';

modules/ppcp-store-sync/src/Helper/CartHelper.php

@@ -79,13 +79,15 @@ static function ( float $cart_total, CartItem $item ): float {
 	}
 
 	/**
-	 * Formats a price value to two decimal places.
+	 * Formats a price value for an API response.
 	 *
-	 * @param float $value The price value to format.
+	 * PayPal expects monetary values to be strings with two decimal places.
+	 *
+	 * @param int|float|string $value The price value to format.
 	 * @return string The formatted price (e.g., "123.45").
 	 */
-	public static function format_decimal( float $value ): string {
-		return number_format( $value, 2, '.', '' );
+	public static function format_decimal( $value ): string {
+		return number_format( (float) $value, 2, '.', '' );
 	}
 
 	public static function full_customer_name( PayPalCart $cart, string $default = '' ): string {
@@ -195,7 +197,7 @@ public static function calculate_totals( WC_Cart $wc_cart, string $currency_code
 	public static function money( string $currency_code, float $value ): array {
 		return array(
 			'currency_code' => $currency_code,
-			'value'         => number_format( $value, 2 ),
+			'value'         => self::format_decimal( $value ),
 		);
 	}
 }

modules/ppcp-store-sync/src/Helper/PayPalOrderManager.php

@@ -257,7 +257,7 @@ private function build_items_for_patch( PayPalCart $cart ): array {
 				'quantity'    => (string) $item->quantity(),
 				'unit_amount' => array(
 					'currency_code' => $currency,
-					'value'         => $this->format_money( (float) $price->value() ),
+					'value'         => CartHelper::format_decimal( $price->value() ),
 				),
 			);
 		}
@@ -406,16 +406,4 @@ public function capture_order( string $order_id ): ?array {
 			return null;
 		}
 	}
-
-	/**
-	 * Format a money value for PayPal API.
-	 *
-	 * PayPal requires money values as strings with 2 decimal places.
-	 *
-	 * @param float $value The money value.
-	 * @return string Formatted money value.
-	 */
-	private function format_money( float $value ): string {
-		return number_format( $value, 2, '.', '' );
-	}
 }

modules/ppcp-store-sync/src/Ingestion/ProductsPayload.php

@@ -4,6 +4,7 @@
 
 use WC_Product;
 use WC_Product_Variation;
+use WooCommerce\PayPalCommerce\StoreSync\Helper\CartHelper;
 
 class ProductsPayload {
 	private string $merchant_store_url;
@@ -293,6 +294,6 @@ private function format_price( $price ): string {
 			return '';
 		}
 
-		return number_format( (float) $price, 2, '.', '' ) . ' ' . get_woocommerce_currency();
+		return CartHelper::format_decimal( $price ) . ' ' . get_woocommerce_currency();
 	}
 }