refactor: 👔 Extract agentic auto-register logic

Author: stracker-phil

modules/ppcp-store-sync/services.php

@@ -37,6 +37,7 @@
 use WooCommerce\PayPalCommerce\StoreSync\Merchant\MerchantMetadataProvider;
 use WooCommerce\PayPalCommerce\StoreSync\Registration\RegistrationService;
 use WooCommerce\PayPalCommerce\StoreSync\Registration\RegistrationEligibility;
+use WooCommerce\PayPalCommerce\StoreSync\Registration\ReconciliationService;
 use WooCommerce\PayPalCommerce\StoreSync\Helper\AgenticCheckoutProcessor;
 use WooCommerce\PayPalCommerce\StoreSync\Helper\ShippingOptionsBuilder;
 use WooCommerce\PayPalCommerce\StoreSync\Helper\PayPalOrderManager;
@@ -109,6 +110,13 @@
 			$c->get( 'agentic.logger.default' )
 		);
 	},
+	'agentic.registration.reconciler'              => static function ( ContainerInterface $c ): ReconciliationService {
+		return new ReconciliationService(
+			$c->get( 'agentic.settings.model' ),
+			$c->get( 'agentic.registration.handler' ),
+			$c->get( 'agentic.logger.default' )
+		);
+	},
 
 	// Authentication services.
 	'agentic.auth.key_provider'                    => static function (): PayPalJwkProvider {

modules/ppcp-store-sync/src/Registration/ReconciliationService.php

@@ -0,0 +1,86 @@
+<?php
+
+declare( strict_types = 1 );
+
+namespace WooCommerce\PayPalCommerce\StoreSync\Registration;
+
+use Psr\Log\LoggerInterface;
+use WooCommerce\PayPalCommerce\StoreSync\Setting\AgenticSettingsDataModel;
+
+/**
+ * Aligns the store's registration with the current settings: registers when the
+ * feature is enabled but the store is not registered, and deregisters when it is
+ * no longer enabled. Reconciliation is idempotent, so calling it when the desired
+ * and actual states already match does nothing.
+ */
+class ReconciliationService {
+
+	private AgenticSettingsDataModel $settings;
+	private RegistrationService $registration;
+	private LoggerInterface $logger;
+
+	public function __construct(
+		AgenticSettingsDataModel $settings,
+		RegistrationService $registration,
+		LoggerInterface $logger
+	) {
+
+		$this->settings     = $settings;
+		$this->registration = $registration;
+		$this->logger       = $logger;
+	}
+
+	/**
+	 * Aligns the registration state with the current settings.
+	 *
+	 * This is convergent: a failed registration disables the feature, so a
+	 * subsequent run sees the desired and actual states already matching and does
+	 * nothing.
+	 */
+	public function reconcile(): void {
+		$desired = $this->settings->should_initialize_features();
+		$actual  = $this->registration->is_registered();
+
+		if ( $desired && ! $actual ) {
+			if ( $this->should_auto_register() ) {
+				$this->register();
+			}
+		} elseif ( ! $desired && $actual ) {
+			$this->registration->deregister();
+		}
+	}
+
+	/**
+	 * Registers the store, disabling the feature when registration fails.
+	 *
+	 * A failure is never retried automatically: re-enabling the toggle is the
+	 * merchant's explicit retry mechanism.
+	 */
+	private function register(): void {
+		$result = $this->registration->register();
+
+		if ( ! is_wp_error( $result ) ) {
+			return;
+		}
+
+		$this->settings->set_active( false );
+		$this->settings->save();
+
+		$this->logger->warning(
+			'Store sync auto-disabled after registration failure',
+			array( 'error' => $result->get_error_message() )
+		);
+	}
+
+	/**
+	 * Whether auto-registration is enabled for this site.
+	 *
+	 * Disable for testing or troubleshooting by adding the following constant to
+	 * wp-config.php:
+	 *
+	 *   define( 'PPCP_AGENTIC_AUTO_REGISTER', false );
+	 */
+	private function should_auto_register(): bool {
+		return ! defined( 'PPCP_AGENTIC_AUTO_REGISTER' ) || PPCP_AGENTIC_AUTO_REGISTER;
+	}
+}

modules/ppcp-store-sync/src/StoreSyncModule.php

@@ -91,17 +91,11 @@ public function run( ContainerInterface $container ): bool {
 
 		// Early exit if features should not be initialized.
 		if ( ! $agentic_settings->should_initialize_features() ) {
-			$this->ensure_deregistered( $registration_handler );
-
 			return true;
 		}
 
 		// Feature is active and merchant is eligible: Initialize everything.
 
-		if ( $this->should_auto_register() ) {
-			$this->ensure_registered( $registration_handler );
-		}
-
 		// Public REST endpoints.
 		add_action(
 			'rest_api_init',
@@ -173,31 +167,4 @@ static function () use ( $settings, $eligibility_check ) {
 			}
 		);
 	}
-
-	private function ensure_registered( RegistrationService $registration_service ): void {
-		if ( $registration_service->is_registered() ) {
-			return;
-		}
-		add_action( 'init', static fn() => $registration_service->register() );
-	}
-
-	private function ensure_deregistered( RegistrationService $registration_service ): void {
-		if ( ! $registration_service->is_registered() ) {
-			return;
-		}
-		add_action( 'init', static fn() => $registration_service->deregister() );
-	}
-
-	/**
-	 * Whether the auto-registration is enabled for this site.
-	 *
-	 * By default, the plugin automatically registers when the merchant is eligible and the feature
-	 * is enabled. For testing or troubleshooting, this behavior can be disabled by adding the
-	 * following constant to wp-config.php:
-	 *
-	 *   define( 'PPCP_AGENTIC_AUTO_REGISTER', false );
-	 */
-	private function should_auto_register(): bool {
-		return ! defined( 'PPCP_AGENTIC_AUTO_REGISTER' ) || PPCP_AGENTIC_AUTO_REGISTER;
-	}
 }