Merge pull request #4322 from woocommerce/dev/PCP-6272-add-declare-strict

stracker-phil · web-flow · commit ec0ceebe0091 · 2026-04-30T14:26:57.000+02:00
Add missing "declare strict" directives (6272)
diff --git a/modules/ppcp-store-sync/src/CartValidation/ValidatorInterface.php b/modules/ppcp-store-sync/src/CartValidation/ValidatorInterface.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\CartValidation;
diff --git a/modules/ppcp-store-sync/src/Config/AgenticWebhookConfiguration.php b/modules/ppcp-store-sync/src/Config/AgenticWebhookConfiguration.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Config;
diff --git a/modules/ppcp-store-sync/src/Config/IngestionConfiguration.php b/modules/ppcp-store-sync/src/Config/IngestionConfiguration.php
@@ -1,5 +1,7 @@
 <?php
 
+declare( strict_types = 1 );
+
 namespace WooCommerce\PayPalCommerce\StoreSync\Config;
 
 use Automattic\WooCommerce\Enums\ProductType;
diff --git a/modules/ppcp-store-sync/src/Config/StoreCurrencyValue.php b/modules/ppcp-store-sync/src/Config/StoreCurrencyValue.php
@@ -1,5 +1,7 @@
 <?php
 
+declare( strict_types = 1 );
+
 namespace WooCommerce\PayPalCommerce\StoreSync\Config;
 
 class StoreCurrencyValue {
diff --git a/modules/ppcp-store-sync/src/Enums/CheckoutFieldType.php b/modules/ppcp-store-sync/src/Enums/CheckoutFieldType.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Enums;
diff --git a/modules/ppcp-store-sync/src/Enums/ErrorCode.php b/modules/ppcp-store-sync/src/Enums/ErrorCode.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Enums;
diff --git a/modules/ppcp-store-sync/src/Enums/ErrorType.php b/modules/ppcp-store-sync/src/Enums/ErrorType.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Enums;
diff --git a/modules/ppcp-store-sync/src/Enums/Priority.php b/modules/ppcp-store-sync/src/Enums/Priority.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Enums;
diff --git a/modules/ppcp-store-sync/src/Enums/ResolutionAction.php b/modules/ppcp-store-sync/src/Enums/ResolutionAction.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Enums;
diff --git a/modules/ppcp-store-sync/src/Ingestion/IngestionBatchProvider.php b/modules/ppcp-store-sync/src/Ingestion/IngestionBatchProvider.php
@@ -1,5 +1,7 @@
 <?php
 
+declare( strict_types = 1 );
+
 namespace WooCommerce\PayPalCommerce\StoreSync\Ingestion;
 
 use WooCommerce\PayPalCommerce\StoreSync\Config\IngestionConfiguration;
diff --git a/modules/ppcp-store-sync/src/Ingestion/IngestionManager.php b/modules/ppcp-store-sync/src/Ingestion/IngestionManager.php
@@ -1,5 +1,7 @@
 <?php
 
+declare( strict_types = 1 );
+
 namespace WooCommerce\PayPalCommerce\StoreSync\Ingestion;
 
 use RuntimeException;
diff --git a/modules/ppcp-store-sync/src/Ingestion/ProductsPayload.php b/modules/ppcp-store-sync/src/Ingestion/ProductsPayload.php
@@ -1,5 +1,7 @@
 <?php
 
+declare( strict_types = 1 );
+
 namespace WooCommerce\PayPalCommerce\StoreSync\Ingestion;
 
 use WC_Product;
diff --git a/modules/ppcp-store-sync/src/Ingestion/SyncJob.php b/modules/ppcp-store-sync/src/Ingestion/SyncJob.php
@@ -1,5 +1,7 @@
 <?php
 
+declare( strict_types = 1 );
+
 namespace WooCommerce\PayPalCommerce\StoreSync\Ingestion;
 
 use RuntimeException;
diff --git a/modules/ppcp-store-sync/src/Merchant/MerchantMetadata.php b/modules/ppcp-store-sync/src/Merchant/MerchantMetadata.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Merchant;
diff --git a/modules/ppcp-store-sync/src/Merchant/MerchantMetadataProvider.php b/modules/ppcp-store-sync/src/Merchant/MerchantMetadataProvider.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Merchant;
diff --git a/modules/ppcp-store-sync/src/Registration/RegistrationEligibility.php b/modules/ppcp-store-sync/src/Registration/RegistrationEligibility.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Registration;
diff --git a/modules/ppcp-store-sync/src/Registration/RegistrationResult.php b/modules/ppcp-store-sync/src/Registration/RegistrationResult.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Registration;
diff --git a/modules/ppcp-store-sync/src/Registration/RegistrationService.php b/modules/ppcp-store-sync/src/Registration/RegistrationService.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Registration;
diff --git a/modules/ppcp-store-sync/src/Session/AgenticSessionHandler.php b/modules/ppcp-store-sync/src/Session/AgenticSessionHandler.php
@@ -7,7 +7,7 @@
  * @package WooCommerce\PayPalCommerce\StoreSync\Session
  */
 
-declare(strict_types=1);
+declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Session;
 
@@ -58,7 +58,7 @@ private function generate_session_id(): string {
 	/**
 	 * Create and save a new cart session.
 	 *
-	 * @param PayPalCart $cart The cart to save.
+	 * @param PayPalCart $cart     The cart to save.
 	 * @param string     $ec_token The PayPal EC token.
 	 * @return string The session ID or null on failure.
 	 */
@@ -84,7 +84,8 @@ public function create_cart_session( PayPalCart $cart, string $ec_token ): strin
 	 * Load a cart session by ID.
 	 *
 	 * @param string $session_id The session ID.
-	 * @return array|null Array with 'cart' (PayPalCart), 'ec_token', 'created', or null if not found.
+	 * @return array|null Array with 'cart' (PayPalCart), 'ec_token', 'created', or null if not
+	 *                    found.
 	 */
 	public function load_cart_session( string $session_id ): ?array {
 		if ( ! $this->session->load_session_by_id( $session_id ) ) {
@@ -114,7 +115,7 @@ public function load_cart_session( string $session_id ): ?array {
 	 * Update an existing cart session.
 	 *
 	 * @param string     $session_id The session ID.
-	 * @param PayPalCart $cart The updated cart.
+	 * @param PayPalCart $cart       The updated cart.
 	 * @return bool True on success.
 	 */
 	public function update_cart_session( string $session_id, PayPalCart $cart ): bool {
diff --git a/modules/ppcp-store-sync/src/Session/AgenticWcSession.php b/modules/ppcp-store-sync/src/Session/AgenticWcSession.php
@@ -7,7 +7,7 @@
  * @package WooCommerce\PayPalCommerce\StoreSync\Session
  */
 
-declare(strict_types=1);
+declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Session;
 
diff --git a/modules/ppcp-store-sync/src/Setting/AgenticSettingsDataModel.php b/modules/ppcp-store-sync/src/Setting/AgenticSettingsDataModel.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Setting;
diff --git a/modules/ppcp-store-sync/src/Setting/AgenticSettingsEndpoint.php b/modules/ppcp-store-sync/src/Setting/AgenticSettingsEndpoint.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Setting;
diff --git a/modules/ppcp-store-sync/src/Setting/AgenticSettingsModule.php b/modules/ppcp-store-sync/src/Setting/AgenticSettingsModule.php
@@ -1,4 +1,5 @@
 <?php
+
 declare( strict_types = 1 );
 
 namespace WooCommerce\PayPalCommerce\StoreSync\Setting;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<?php`
	`2`	`+`
`2`	`3`	`declare( strict_types = 1 );`
`3`	`4`
`4`	`5`	`namespace WooCommerce\PayPalCommerce\StoreSync\CartValidation;`