Merge pull request #212 from WizardOfMenlo/recmo/rs-commit

Interleaved Reed-Solomon commitment protocol

Author: recmo

Cargo.lock

@@ -46,7 +46,7 @@ spongefish = { git = "https://github.com/arkworks-rs/spongefish", features = ["a
 rayon = { version = "1.10", optional = true }
 thiserror = "2.0"
 itertools = "0.14"
-tracing = { version = "0.1", optional = true }
+tracing = { version = "0.1", features = ["attributes"], optional = true }
 hex = "0.4"
 static_assertions = "1.1.0"
 ciborium = "0.2"
@@ -56,17 +56,21 @@ zerocopy = "0.8.33"
 hex-literal = "0.4.1"
 const-oid = "0.9.6"
 arrayvec = "0.7.6"
+derive-where = { version = "1.6.0", features = ["safe"] }
 
 [dev-dependencies]
 proptest = "1.0"
 serde_json = "1.0"
 divan = { version = "4.2", package = "codspeed-divan-compat" }
+tracing-subscriber = { version = "0.3.22", features = ["env-filter"] }
 
 [profile.release]
 debug = true
 
 [features]
 default = ["parallel"]
+# Verifier panics instead of returning errors. Useful for debuging.
+verifier_panics = []
 parallel = [
     "dep:rayon",
     "ark-poly/parallel",

Cargo.toml

@@ -1,5 +1,5 @@
 use divan::{black_box, AllocProfiler, Bencher};
-use whir::{crypto::fields::Field64, ntt};
+use whir::algebra::{fields::Field64, ntt};
 
 #[global_allocator]
 static ALLOC: AllocProfiler = AllocProfiler::system();
@@ -31,7 +31,11 @@ fn interleaved_rs_encode(bencher: Bencher, case: &(u32, usize, usize)) {
             (coeffs, expansion, coset_sz)
         })
         .bench_values(|(coeffs, expansion, coset_sz)| {
-            black_box(ntt::interleaved_rs_encode(&coeffs, expansion, coset_sz))
+            black_box(ntt::interleaved_rs_encode(
+                &coeffs,
+                expansion,
+                1 << coset_sz,
+            ))
         });
 }
 

benches/expand_from_coeff.rs

@@ -1,8 +1,10 @@
 use ark_ff::fields::Field;
 use divan::{black_box, AllocProfiler, Bencher};
 use whir::{
-    crypto::fields::Field64 as F,
-    poly_utils::{coeffs::CoefficientList, multilinear::MultilinearPoint},
+    algebra::{
+        fields::Field64 as F,
+        poly_utils::{coeffs::CoefficientList, multilinear::MultilinearPoint},
+    },
     protocols::sumcheck::SumcheckSingle,
     whir::statement::{Statement, Weights},
 };

benches/sumcheck.rs

@@ -191,7 +191,7 @@ mod tests {
     use ark_ff::Field;
 
     use super::*;
-    use crate::crypto::fields::{Field64, Field64_2};
+    use crate::algebra::fields::{Field64, Field64_2};
 
     type F = Field64;
     type EF2 = Field64_2;