[Bug] Table empty state does not work with `Phoenix.LiveView.LiveStream`

[Flo0807]

Summary

Hey!

It looks like the empty state of the Flop.Phoenix.table component does not work when working with Phoenix.LiveView.LiveStream as a list of items.

The empty state is rendered if @items == [] (see flop_phoenix.ex), but if we pass a stream, the items assign is never an empty list, but always a Phoenix.LiveView.LiveStream struct.

Steps to reproduce

1. Create a Phoenix.LiveView.LiveStream with no items

{:ok, {items, meta}} = MyApp.list(%{})

socket
|> stream(:items, [], reset: true)
|> assign(:meta, meta)

2. Pass the stream to the table/1 component.

<Flop.Phoenix.table items={@streams.items} meta={@meta} path={~p"/"}>
  ...
</Flop.Phoenix.table>

3. See empty state does not work.

Expected behaviour

The empty state of table/1 component should work with Phoenix.LiveView.LiveStream

Actual behaviour

The empty state of table/1 component is not displayed if working with Phoenix.LiveView.LiveStream.

Elixir/Erlang version

Elixir 1.18.3 (compiled with Erlang/OTP 25)

Flop and Ecto versions

• ecto 3.12.5 (Hex package) (mix)
• ecto_sql 3.12.1 (Hex package) (mix)
  locked at 3.12.1 (ecto_sql) aff5b958
• flop 0.26.1 (Hex package) (mix)
  locked at 0.26.1 (flop) 5fcab8a1
• flop_phoenix 0.24.1 (Hex package) (mix)
  locked at 0.24.1 (flop_phoenix) 543c8eb7

Additional context

No response

[Flo0807]

It is difficult by design to check whether a Phoenix.LiveView.LiveStream is empty or not, but as I need to reset the stream after every fetch to make pagination and filters work, I came up with a workaround to solve the above-mentioned issue with the latest flop_phoenix version (0.24.1).

In case anyone else stumbles across the same problem. Here is my workaround:

Every time I fetch the items via Flop, I set an show_empty_state assign based on the fetched list. In my markup, if show_empty_state is true, I pass an empty list to the table/1 component. Otherwise, I use the stream.

# index.ex

def handle_params(params, _uri, socket) do
  {:ok, {items, meta}} = MyApp.list(params)

  socket
  |> stream(:items, items, reset: true)
  |> assign(:meta, meta)
  |> assign(:show_empty_state, items == [])
 
 {:noreply, socket}
end

<%!-- index.html.heex --%>

<Flop.Phoenix.table
  items={(@show_empty_state && []) || @streams.items} 
  meta={@meta} 
  path={~p"/"}>
  ...
</Flop.Phoenix.table>

[woylie]

Thanks for opening the issue and posting the example. There's a PR that attempted to handle this, with some further discussion: #272.