Skip to content

Commit 9597ecd

Browse files
committed
Cross the Phar and WordPress dimensions
`use-phar: true` was excluded on trunk and `use-phar: false` on latest, which made each fully determined by the other: the Phar was only ever tested against WP latest, and source only against trunk. Two combinations therefore went untested — including source against WP latest, which is the ordinary local setup and arguably the most important one in the file. Cross the two dimensions and drop only the combinations that add no signal. Source against WP latest and the Phar against trunk both run now, the latter as an early warning that a WP change has broken the released binary. Neither is covered by the continue-on-error condition, so both can fail the build. This takes the run from 155 jobs to 217. The 256-job matrix cap is the reason the remaining source combinations are dropped rather than the whole cross product being enabled, which would have needed 310. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jy4dmjymj9VmoTBaqrV4iX
1 parent 0b272de commit 9597ecd

1 file changed

Lines changed: 17 additions & 4 deletions

File tree

.github/workflows/testing.yml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,24 @@ jobs:
8282
- php: '7.4'
8383
object_cache: sqlite
8484

85-
# Phar usage match defaults
86-
- use-phar: true
87-
wp: trunk
88-
- use-phar: false
85+
# Phar and source are separate dimensions, not aliases for a WP
86+
# version. Previously `use-phar: true` was excluded on trunk and
87+
# `use-phar: false` on latest, which made the two fully determined by
88+
# each other: the Phar was only ever tested against WP latest and
89+
# source only against trunk, so source-on-latest — the ordinary local
90+
# setup — went untested entirely.
91+
#
92+
# Cross them instead, dropping only the combinations that add no
93+
# signal, which keeps the run under the 256-job matrix cap. What this
94+
# buys is source against WP latest, and the Phar against trunk as an
95+
# early warning that a WP change has broken the released binary.
96+
# Neither of those runs with continue-on-error, so both can fail the
97+
# build.
98+
- php: '7.4'
8999
wp: latest
100+
use-phar: false
101+
- dbtype: sqlite
102+
use-phar: false
90103

91104
# Limit ancient php on trunk
92105
- php: '7.4'

0 commit comments

Comments
 (0)