[javac] Add compiler check for integer division in floating-point contexts#8885
Open
SamCarlberg wants to merge 3 commits into
Open
[javac] Add compiler check for integer division in floating-point contexts#8885SamCarlberg wants to merge 3 commits into
SamCarlberg wants to merge 3 commits into
Conversation
Errors can be suppressed with `@SuppressWarnings("IntegerDivision")`
Contributor
|
At least for this PR, i think that the annotation for disabling this check shouldn't be an @SuppressWarnings annotation since that's used to only disable warnings, whereas this integer division check isn't a warning, but an error that prevents the code from compiling. Ideally, it would be a custom annotation, like @EnableIntegerDivision. Aside from that, though, I'm not sure how I feel about this idea either. It's definitely a really really helpful feature to have, but I'm afraid of getting students into the mindset that every non-FRC java code they write will also check for integer division this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for catching bad behavior when doing math or configuring ratios with integers. Errors can be turned off with
@SuppressWarnings("IntegerDivision")Also adds the compiler plugin as a dependency to the developerRobot project for dev testing