Implement review suggestions

Author: RovinKYK

iamctl/pkg/utils/apiUtils.go

@@ -521,7 +521,10 @@ func SendGetListRequest(resourceType ResourceType, resourceLimit int, opts ...Se
 	var reqUrl = buildRequestUrl(LIST, resourceType, "")
 	http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
 
-	req, _ := http.NewRequest("GET", reqUrl, bytes.NewBuffer(nil))
+	req, err := http.NewRequest("GET", reqUrl, bytes.NewBuffer(nil))
+	if err != nil {
+		return nil, fmt.Errorf("error creating Get List request: %w", err)
+	}
 	req.Header.Set("Authorization", "Bearer "+SERVER_CONFIGS.Token)
 	req.Header.Set("accept", "*/*")
 
@@ -538,7 +541,7 @@ func SendGetListRequest(resourceType ResourceType, resourceLimit int, opts ...Se
 	httpClient := &http.Client{}
 	resp, err := httpClient.Do(req)
 	if err != nil {
-		return nil, fmt.Errorf("failed to retrieve available userstore list. %w", err)
+		return nil, fmt.Errorf("failed to retrieve available resource list. %w", err)
 	}
 	return resp, nil
 }

iamctl/pkg/utils/resourceOrder.go

@@ -36,5 +36,5 @@ var ResourceOrder = []ResourceType{
 	SCRIPT_LIBRARIES,
 	GOVERNANCE_CONNECTORS,
 	CERTIFICATES,
-	WORKFLOWS,
+	WORKFLOWS, // Dependency: Roles
 }

iamctl/pkg/workflows/import.go

@@ -247,9 +247,9 @@ func removeDeletedDeployedWorkflows(localFiles []os.FileInfo, deployedWorkflows
 	}
 }
 
-func removeDeletedDeployedWfAssociations(localNames []string, deployedAssociations []workflowAssociation) map[string]struct{} {
+func removeDeletedDeployedWfAssociations(localNames []string, deployedAssociations []workflowAssociation) (failedWorkflows map[string]struct{}) {
 
-	failedWorkflows := make(map[string]struct{})
+	failedWorkflows = make(map[string]struct{})
 	if len(deployedAssociations) == 0 {
 		return failedWorkflows
 	}

iamctl/pkg/workflows/workflowUtils.go

@@ -361,7 +361,7 @@ func writeWorkflowAssociationsList(outputDirPath string, formatString string) er
 func updateWorkflowExportSummary(success bool, successCount int) {
 
 	if !success {
-		utils.UpdateFailureSummary(utils.WORKFLOW_ASSOCIATIONS, utils.WORKFLOW_ASSOCIATIONS.String())
+		utils.UpdateFailureSummary(utils.WORKFLOWS, utils.WORKFLOW_ASSOCIATIONS.String())
 		return
 	}
 	for i := 0; i < successCount; i++ {