Skip to content

Commit dddea79

Browse files
konradmichalikkonradmichalik
committed
test: clean up whitespace in unit tests for consistency
1 parent 2d79c54 commit dddea79

12 files changed

Lines changed: 196 additions & 219 deletions

File tree

‎Tests/Unit/Backend/ToolbarItems/NewsItemTest.php‎

Lines changed: 29 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ protected function setUp(): void
3939
$this->newsRepositoryMock = $this->getMockBuilder(NewsRepository::class)
4040
->disableOriginalConstructor()
4141
->getMock();
42-
42+
4343
$this->subject = new NewsItem($this->newsRepositoryMock);
4444
}
4545

@@ -53,7 +53,7 @@ public function toolbarItemCanBeInstantiated(): void
5353
public function toolbarItemImplementsInterface(): void
5454
{
5555
$reflection = new \ReflectionClass(NewsItem::class);
56-
56+
5757
self::assertTrue($reflection->implementsInterface(ToolbarItemInterface::class));
5858
}
5959

@@ -62,14 +62,14 @@ public function constructorAcceptsNewsRepository(): void
6262
{
6363
$reflection = new \ReflectionClass(NewsItem::class);
6464
$constructor = $reflection->getConstructor();
65-
65+
6666
self::assertNotNull($constructor);
67-
67+
6868
$parameters = $constructor->getParameters();
6969
self::assertCount(1, $parameters);
70-
70+
7171
self::assertEquals('newsRepository', $parameters[0]->getName());
72-
72+
7373
$paramType = $parameters[0]->getType();
7474
self::assertInstanceOf(\ReflectionNamedType::class, $paramType);
7575
self::assertEquals(NewsRepository::class, $paramType->getName());
@@ -79,70 +79,69 @@ public function constructorAcceptsNewsRepository(): void
7979
public function checkAccessReturnsTrue(): void
8080
{
8181
$result = $this->subject->checkAccess();
82-
82+
8383
self::assertTrue($result);
8484
}
8585

8686
#[Test]
8787
public function hasDropDownReturnsTrue(): void
8888
{
8989
$result = $this->subject->hasDropDown();
90-
90+
9191
self::assertTrue($result);
9292
}
9393

9494
#[Test]
9595
public function getIndexReturns50(): void
9696
{
9797
$result = $this->subject->getIndex();
98-
98+
9999
self::assertEquals(50, $result);
100100
}
101101

102102
#[Test]
103103
public function getAdditionalAttributesReturnsEmptyArray(): void
104104
{
105105
$result = $this->subject->getAdditionalAttributes();
106-
107-
self::assertIsArray($result);
106+
108107
self::assertEmpty($result);
109108
}
110109

111110
#[Test]
112111
public function toolbarItemMethodsHaveCorrectReturnTypes(): void
113112
{
114113
$reflection = new \ReflectionClass(NewsItem::class);
115-
114+
116115
// checkAccess
117116
$checkAccess = $reflection->getMethod('checkAccess');
118117
$returnType = $checkAccess->getReturnType();
119118
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
120119
self::assertEquals('bool', $returnType->getName());
121-
120+
122121
// getItem
123122
$getItem = $reflection->getMethod('getItem');
124123
$returnType = $getItem->getReturnType();
125124
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
126125
self::assertEquals('string', $returnType->getName());
127-
126+
128127
// hasDropDown
129128
$hasDropDown = $reflection->getMethod('hasDropDown');
130129
$returnType = $hasDropDown->getReturnType();
131130
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
132131
self::assertEquals('bool', $returnType->getName());
133-
132+
134133
// getDropDown
135134
$getDropDown = $reflection->getMethod('getDropDown');
136135
$returnType = $getDropDown->getReturnType();
137136
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
138137
self::assertEquals('string', $returnType->getName());
139-
138+
140139
// getAdditionalAttributes
141140
$getAdditionalAttributes = $reflection->getMethod('getAdditionalAttributes');
142141
$returnType = $getAdditionalAttributes->getReturnType();
143142
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
144143
self::assertEquals('array', $returnType->getName());
145-
144+
146145
// getIndex
147146
$getIndex = $reflection->getMethod('getIndex');
148147
$returnType = $getIndex->getReturnType();
@@ -154,16 +153,16 @@ public function toolbarItemMethodsHaveCorrectReturnTypes(): void
154153
public function toolbarItemMethodsArePublic(): void
155154
{
156155
$reflection = new \ReflectionClass(NewsItem::class);
157-
156+
158157
$methods = [
159158
'checkAccess',
160-
'getItem',
159+
'getItem',
161160
'hasDropDown',
162161
'getDropDown',
163162
'getAdditionalAttributes',
164-
'getIndex'
163+
'getIndex',
165164
];
166-
165+
167166
foreach ($methods as $methodName) {
168167
$method = $reflection->getMethod($methodName);
169168
self::assertTrue($method->isPublic(), "Method {$methodName} should be public");
@@ -175,12 +174,12 @@ public function toolbarItemMethodsArePublic(): void
175174
public function toolbarItemHasProtectedConfigurationProperty(): void
176175
{
177176
$reflection = new \ReflectionClass(NewsItem::class);
178-
177+
179178
self::assertTrue($reflection->hasProperty('configuration'));
180-
179+
181180
$property = $reflection->getProperty('configuration');
182181
self::assertTrue($property->isProtected());
183-
182+
184183
$propertyType = $property->getType();
185184
self::assertInstanceOf(\ReflectionNamedType::class, $propertyType);
186185
self::assertEquals('array', $propertyType->getName());
@@ -190,7 +189,7 @@ public function toolbarItemHasProtectedConfigurationProperty(): void
190189
public function toolbarItemUsesCorrectNamespace(): void
191190
{
192191
$reflection = new \ReflectionClass(NewsItem::class);
193-
192+
194193
self::assertEquals('Xima\XimaTypo3InternalNews\Backend\ToolbarItems', $reflection->getNamespaceName());
195194
self::assertEquals('NewsItem', $reflection->getShortName());
196195
}
@@ -199,19 +198,19 @@ public function toolbarItemUsesCorrectNamespace(): void
199198
public function toolbarItemMethodsHaveNoParameters(): void
200199
{
201200
$reflection = new \ReflectionClass(NewsItem::class);
202-
201+
203202
$parameterlessMethods = [
204203
'checkAccess',
205204
'getItem',
206-
'hasDropDown',
205+
'hasDropDown',
207206
'getDropDown',
208207
'getAdditionalAttributes',
209-
'getIndex'
208+
'getIndex',
210209
];
211-
210+
212211
foreach ($parameterlessMethods as $methodName) {
213212
$method = $reflection->getMethod($methodName);
214213
self::assertCount(0, $method->getParameters(), "Method {$methodName} should have no parameters");
215214
}
216215
}
217-
}
216+
}

‎Tests/Unit/ConfigurationTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ public function extensionNameIsCorrect(): void
4545
public function constantsAreFinal(): void
4646
{
4747
$reflection = new \ReflectionClass(Configuration::class);
48-
48+
4949
$extKeyConstant = $reflection->getReflectionConstant('EXT_KEY');
5050
$extNameConstant = $reflection->getReflectionConstant('EXT_NAME');
51-
51+
5252
self::assertTrue($extKeyConstant->isFinal());
5353
self::assertTrue($extNameConstant->isFinal());
5454
}
55-
}
55+
}

‎Tests/Unit/Controller/DateControllerTest.php‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,18 @@ protected function setUp(): void
4141
$this->newsRepositoryMock = $this->getMockBuilder(NewsRepository::class)
4242
->disableOriginalConstructor()
4343
->getMock();
44-
44+
4545
$this->extensionConfigurationMock = $this->getMockBuilder(ExtensionConfiguration::class)
4646
->disableOriginalConstructor()
4747
->getMock();
48-
48+
4949
$this->extensionConfigurationMock
5050
->method('get')
5151
->willReturn([
5252
'enableNotifySessionHide' => true,
5353
'dateListCount' => 20,
5454
]);
55-
55+
5656
$this->subject = new DateController(
5757
$this->newsRepositoryMock,
5858
$this->extensionConfigurationMock
@@ -69,15 +69,15 @@ public function controllerCanBeInstantiated(): void
6969
public function controllerExtendsActionController(): void
7070
{
7171
$reflection = new \ReflectionClass(DateController::class);
72-
72+
7373
self::assertTrue($reflection->isSubclassOf(ActionController::class));
7474
}
7575

7676
#[Test]
7777
public function controllerIsFinal(): void
7878
{
7979
$reflection = new \ReflectionClass(DateController::class);
80-
80+
8181
self::assertTrue($reflection->isFinal());
8282
}
8383

@@ -86,9 +86,9 @@ public function controllerHasAsControllerAttribute(): void
8686
{
8787
$reflection = new \ReflectionClass(DateController::class);
8888
$attributes = $reflection->getAttributes();
89-
89+
9090
self::assertNotEmpty($attributes);
91-
91+
9292
// Check if AsController attribute exists
9393
$hasAsControllerAttribute = false;
9494
foreach ($attributes as $attribute) {
@@ -97,7 +97,7 @@ public function controllerHasAsControllerAttribute(): void
9797
break;
9898
}
9999
}
100-
100+
101101
self::assertTrue($hasAsControllerAttribute);
102102
}
103103

@@ -106,18 +106,18 @@ public function constructorAcceptsRequiredDependencies(): void
106106
{
107107
$reflection = new \ReflectionClass(DateController::class);
108108
$constructor = $reflection->getConstructor();
109-
109+
110110
self::assertNotNull($constructor);
111-
111+
112112
$parameters = $constructor->getParameters();
113113
self::assertCount(2, $parameters);
114-
114+
115115
// Check first parameter (NewsRepository)
116116
self::assertEquals('newsRepository', $parameters[0]->getName());
117117
$firstParamType = $parameters[0]->getType();
118118
self::assertInstanceOf(\ReflectionNamedType::class, $firstParamType);
119119
self::assertEquals(NewsRepository::class, $firstParamType->getName());
120-
120+
121121
// Check second parameter (ExtensionConfiguration)
122122
self::assertEquals('extensionConfiguration', $parameters[1]->getName());
123123
$secondParamType = $parameters[1]->getType();
@@ -129,12 +129,12 @@ public function constructorAcceptsRequiredDependencies(): void
129129
public function notifiesActionMethodExists(): void
130130
{
131131
$reflection = new \ReflectionClass(DateController::class);
132-
132+
133133
self::assertTrue($reflection->hasMethod('notifiesAction'));
134-
134+
135135
$method = $reflection->getMethod('notifiesAction');
136136
self::assertTrue($method->isPublic());
137-
137+
138138
// Check return type
139139
$returnType = $method->getReturnType();
140140
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
@@ -145,12 +145,12 @@ public function notifiesActionMethodExists(): void
145145
public function newsActionMethodExists(): void
146146
{
147147
$reflection = new \ReflectionClass(DateController::class);
148-
148+
149149
self::assertTrue($reflection->hasMethod('newsAction'));
150-
150+
151151
$method = $reflection->getMethod('newsAction');
152152
self::assertTrue($method->isPublic());
153-
153+
154154
// Check return type
155155
$returnType = $method->getReturnType();
156156
self::assertInstanceOf(\ReflectionNamedType::class, $returnType);
@@ -161,12 +161,12 @@ public function newsActionMethodExists(): void
161161
public function controllerHasProtectedConfigurationProperty(): void
162162
{
163163
$reflection = new \ReflectionClass(DateController::class);
164-
164+
165165
self::assertTrue($reflection->hasProperty('configuration'));
166-
166+
167167
$property = $reflection->getProperty('configuration');
168168
self::assertTrue($property->isProtected());
169-
169+
170170
// Check property type
171171
$propertyType = $property->getType();
172172
self::assertInstanceOf(\ReflectionNamedType::class, $propertyType);
@@ -177,7 +177,7 @@ public function controllerHasProtectedConfigurationProperty(): void
177177
public function controllerUsesCorrectNamespace(): void
178178
{
179179
$reflection = new \ReflectionClass(DateController::class);
180-
180+
181181
self::assertEquals('Xima\XimaTypo3InternalNews\Controller', $reflection->getNamespaceName());
182182
self::assertEquals('DateController', $reflection->getShortName());
183183
}
@@ -186,10 +186,10 @@ public function controllerUsesCorrectNamespace(): void
186186
public function controllerMethodsAreNotStatic(): void
187187
{
188188
$reflection = new \ReflectionClass(DateController::class);
189-
189+
190190
$notifiesAction = $reflection->getMethod('notifiesAction');
191191
$newsAction = $reflection->getMethod('newsAction');
192-
192+
193193
self::assertFalse($notifiesAction->isStatic());
194194
self::assertFalse($newsAction->isStatic());
195195
}
@@ -198,11 +198,11 @@ public function controllerMethodsAreNotStatic(): void
198198
public function controllerActionMethodsHaveNoParameters(): void
199199
{
200200
$reflection = new \ReflectionClass(DateController::class);
201-
201+
202202
$notifiesAction = $reflection->getMethod('notifiesAction');
203203
$newsAction = $reflection->getMethod('newsAction');
204-
204+
205205
self::assertCount(0, $notifiesAction->getParameters());
206206
self::assertCount(0, $newsAction->getParameters());
207207
}
208-
}
208+
}

0 commit comments

Comments
 (0)