Always register `FormEngine` inline settings

[konradmichalik]

Problem

Opening a module that extends AbstractBackendController with the default WORKSPACE_ID = 0 throws on every page load:

  Uncaught TypeError: Cannot read properties of undefined (reading 'formName') at form-engine.js 

Root Cause

AbstractBackendController::loadWorkspaceScripts() only registers the FormEngine inline setting inside the if ($this::WORKSPACE_ID) branch.

However, Resources/Public/JavaScript/recordlist-row-edit-multiple.js uses top.TYPO3.settings.FormEngine.moduleUrl unconditionally and pulls @typo3/backend/form-engine.js as a transitive dependency. form-engine.js reads TYPO3.settings.FormEngine.formName at module-evaluation time, so it throws when the setting is missing.

Fix

Move the two FormEngine inline settings out of the workspace branch — they are required by the row-edit JS regardless of workspace mode. Workspaces, RecordHistory and WebLayout stay workspace-only.

 protected function loadWorkspaceScripts(): void                                                                      
 {                                     
+    $this->pageRenderer->addInlineSetting(
+        'FormEngine',
+        'moduleUrl',
+        (string)$this->backendUriBuilder->buildUriFromRoute('record_edit')                                                                                                                                                                                                                                                                                                                                               
+    );
+    $this->pageRenderer->addInlineSetting('FormEngine', 'formName', 'editform');                                                                                                                                                                                                                                                                                                                                         
+                                                                                                                                                                                                                                                                                                                                                                                                                         
     if ($this::WORKSPACE_ID) {        
-        $this->pageRenderer->addInlineSetting(                                                                                                                                                                                                                                                                                                                                                                           
-            'FormEngine',                                                                                                                                                                                                                                                                                                                                                                                                
-            'moduleUrl',              
-            (string)$this->backendUriBuilder->buildUriFromRoute('record_edit')                                                                                                                                                                                                                                                                                                                                           
-        );                                                                                                           
         // ...                        
     }                                                                                                                                                                                                                                                                                                                                                                                                                    
 }

Environment

• TYPO3 v13.4
• xima/xima-typo3-recordlist 14.0.0
• PHP 8.4

[maikschneider]

Hey @konradmichalik ,
thanks for reporting! Unfortunately I can not reproduce the error - I see the issue, but can't find a setup where TYPO3.settings.FormEngine.moduleUrl is not available. Can you reproduce it with the example controllers?
In #54 I fixed a JS error in v14 and added JS error tracking - I would like to cover this error as well. Could you please test with the current master branch?

[konradmichalik]

Hej @maikschneider,

I have freshly installed the extension in a TYPO3 13 project and configured a dataset. I do not want to rule out that the error was caused by other influences, but after the test installation of the described fix in the record list extension, the error disappeared.

I am currently on a longer trip and can only devote myself to PR in some time.

Cheers
Konrad