-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Background colour from options.theme is applied to wrong container element #5781
Copy link
Copy link
Open
Description
Details
- Browser and browser version: Google Chrome v146.0.7680.153
- OS version: Ubuntu 24.04.4 LTS
- xterm.js version: 6.0.0
Steps to reproduce
Hello, first of all thanks for the great work with xterm.js!
We came across the v6.0.0 update, and this seems to break our custom background style, passed via options.theme:
const options = {
theme: {
background: "#292c2f",
},
};
const term = new Terminal(options);
Before (v5.5.0), the background-color style used to be applied to the top container (.xterm-viewport), but in v6.0.0 it seems to be applied to its child, the .xterm-scrollable-element container instead, which is slightly smaller than its parent, causing a border with the default background colour (#000) to appear around the element:
- Before (v5.5.0)
- After (v6.0.0)
Expected behaviour: the background colour should be applied to the .xterm-viewport element as it was in v5.5.0, to avoid the visual glitch shown above.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels