update quality plugin

(cherry picked from commit d6e5d74)

Author: xvik

build.gradle

@@ -1,7 +1,8 @@
 plugins {
     id 'ru.vyarus.github-info' version '2.0.0' apply false
-    id 'ru.vyarus.quality' version '5.0.0' apply false
-    id 'org.cyclonedx.bom' version '2.3.0' apply false
+    id 'ru.vyarus.quality' version '6.0.0' apply false
+    id 'com.github.spotbugs' version '6.2.5' apply false
+    id 'org.cyclonedx.bom' version '2.3.1' apply false
     id 'ru.vyarus.mkdocs' version '4.0.1' apply false
 
     id 'jacoco'
@@ -167,7 +168,7 @@ subprojects {
 //        useJUnitPlatform()
         testLogging {
             events 'skipped', 'failed'
-            exceptionFormat 'full'
+            exceptionFormat = 'full'
         }
         maxHeapSize = '512m'
     }
@@ -239,5 +240,4 @@ afterReleaseBuild {
     doLast {
         logger.warn "RELEASED $project.group:$project.name:$project.version"
     }
-}
-
+}

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/GuiceBundle.java

@@ -124,8 +124,8 @@
  * @see ru.vyarus.dropwizard.guice.module.GuiceyConfigurationInfo for configuratio diagnostic
  * @since 31.08.2014
  */
-@SuppressWarnings({"PMD.ExcessiveClassLength", "PMD.ExcessiveImports", "PMD.TooManyMethods",
-        "PMD.ExcessivePublicCount", "PMD.GodClass"})
+@SuppressWarnings({"PMD.ExcessiveImports", "PMD.TooManyMethods",
+        "PMD.ExcessivePublicCount", "PMD.GodClass", "PMD.CouplingBetweenObjects"})
 public final class GuiceBundle implements ConfiguredBundle<Configuration> {
 
     private final ConfigurationContext context = new ConfigurationContext();
@@ -1209,7 +1209,7 @@ public Builder withSharedState(final Consumer<SharedConfigurationState> stateAct
          * @return builder instance for chained calls
          */
         public <C extends Configuration> Builder onGuiceyStartup(final GuiceyStartupListener<C> listener) {
-            return listen(new GuiceyStartupListenerAdapter<C>(listener));
+            return listen(new GuiceyStartupListenerAdapter<>(listener));
         }
 
         /**

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/GuiceyOptions.java

@@ -183,8 +183,8 @@ public enum GuiceyOptions implements Option {
      */
     UseHkBridge(Boolean.class, false);
 
-    private Class<?> type;
-    private Object value;
+    private final Class<?> type;
+    private final Object value;
 
     <T> GuiceyOptions(final Class<T> type, final T value) {
         this.type = type;

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/bundle/GuiceyBundleLookup.java

@@ -11,6 +11,7 @@
  * @author Vyacheslav Rusakov
  * @since 15.01.2016
  */
+@FunctionalInterface
 public interface GuiceyBundleLookup {
 
     /**

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/debug/LifecycleDiagnostic.java

@@ -49,7 +49,7 @@
  * @author Vyacheslav Rusakov
  * @since 17.04.2018
  */
-@SuppressWarnings({"checkstyle:ClassFanOutComplexity", "PMD.TooManyMethods", "PMD.ExcessiveImports"})
+@SuppressWarnings({"checkstyle:ClassFanOutComplexity", "PMD.ExcessiveImports", "PMD.CouplingBetweenObjects"})
 public class LifecycleDiagnostic extends UniqueGuiceyLifecycleListener {
 
     private static final String BUNDLES = "bundles";
@@ -170,7 +170,7 @@ protected void modulesAnalyzed(final ModulesAnalyzedEvent event) {
                 for (Binding binding : event.getBindingsRemoved()) {
                     final List<String> modules = BindingUtils.getModules(binding).stream()
                             .sorted(Collections.reverseOrder())
-                            .map(it -> it.substring(it.lastIndexOf(".") + 1))
+                            .map(it -> it.substring(it.lastIndexOf('.') + 1))
                             .collect(Collectors.toList());
                     bindings.add(String.join("/", modules) + " | " + RenderUtils
                             .renderClassLine(binding.getKey().getTypeLiteral().getRawType()));
@@ -293,7 +293,7 @@ public void lifeCycleStopped(final LifeCycle event) {
      */
     private final class JerseyEventListener implements ApplicationEventListener {
         @Override
-        @SuppressWarnings({"checkstyle:MissingSwitchDefault", "PMD.SwitchStmtsShouldHaveDefault"})
+        @SuppressWarnings({"checkstyle:MissingSwitchDefault", "PMD.NonExhaustiveSwitch"})
         @SuppressFBWarnings("SF_SWITCH_NO_DEFAULT")
         public void onEvent(final ApplicationEvent event) {
             switch (event.getType()) {

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/debug/StartupTimeDiagnostic.java

@@ -60,6 +60,7 @@ public class StartupTimeDiagnostic extends UniqueGuiceyLifecycleListener {
     private final ShutdownTimeInfo stop = new ShutdownTimeInfo();
 
     // for tracking dw phases in bundles tracker
+    @SuppressWarnings("PMD.LooseCoupling")
     private DropwizardBundlesTracker bundlesTracker;
 
     @Override
@@ -123,12 +124,10 @@ private class JettyListener implements LifeCycle.Listener {
         private final Stopwatch startTime;
         private final Stopwatch stopTime;
         private final List<Class<?>> startupEvents;
-        private final ApplicationRunEvent event;
         private Duration startListenersTime;
         private final StatsInfo stats;
 
         JettyListener(final ApplicationRunEvent event) {
-            this.event = event;
             startTime = Stopwatch.createUnstarted();
             stopTime = Stopwatch.createUnstarted();
             startupEvents = new ArrayList<>();

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/debug/report/ReportRenderer.java

@@ -7,6 +7,7 @@
  * @author Vyacheslav Rusakov
  * @since 01.08.2016
  */
+@FunctionalInterface
 public interface ReportRenderer<T> {
 
     /**

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/debug/report/guice/GuiceAopMapRenderer.java

@@ -1,7 +1,7 @@
 package ru.vyarus.dropwizard.guice.debug.report.guice;
 // CHECKSTYLE:OFF
 
-import com.google.inject.Module; // NOPMD
+import com.google.inject.Module;
 // CHECKSTYLE:ON
 import com.google.inject.*;
 import com.google.inject.spi.ConstructorBinding;

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/debug/report/guice/GuiceBindingsRenderer.java

@@ -289,7 +289,6 @@ private void markExtensions(final Map<Key, BindingDeclaration> moduleBindings) {
     }
 
     @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_INFERRED")
-    @SuppressWarnings({"PMD.AvoidInstantiatingObjectsInLoops", "PMD.ConsecutiveLiteralAppends"})
     private void render(final TreeNode root, final ModuleDeclaration mod) {
         final TreeNode next = root.child(RenderUtils.renderClassLine(mod.getType(), mod.getMarkers()));
 

dropwizard-guicey/src/main/java/ru/vyarus/dropwizard/guice/debug/report/guice/model/BindingDeclaration.java

@@ -183,7 +183,6 @@ public void setModule(final String module) {
     }
 
     @Override
-    @SuppressWarnings("PMD.UseStringBufferForStringAppends")
     public String toString() {
         String res = type.name().toLowerCase() + " " + GuiceModelUtils.renderKey(key);
         if (module != null) {