[Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786)

Remove redundant public visibility modifiers from JUnit5 test classes and
their test/lifecycle methods across 7 modules, as reported by SonarCloud
rule java:S5786. Test code only, behaviour-preserving.

Author: vmassol

xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/DefaultLikeConfigurationTest.java

@@ -38,7 +38,7 @@
  * @since 12.7RC1
  */
 @ComponentTest
-public class DefaultLikeConfigurationTest
+class DefaultLikeConfigurationTest
 {
     @InjectMockComponents
     private DefaultLikeConfiguration defaultLikeConfiguration;

xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/LikeExistCacheEntryListenerTest.java

@@ -42,7 +42,7 @@
  *
  * @version $Id$
  */
-public class LikeExistCacheEntryListenerTest
+class LikeExistCacheEntryListenerTest
 {
     private LikeManagerCacheHelper.LikeExistCacheEntryListener cacheEntryListener;
 

xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/LikeRightTest.java

@@ -31,7 +31,7 @@
  *
  * @version $Id$
  */
-public class LikeRightTest
+class LikeRightTest
 {
     @Test
     void getters()

xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/AddressConverterTest.java

@@ -38,13 +38,13 @@
  * @since 6.2M1
  */
 @ComponentTest
-public class AddressConverterTest
+class AddressConverterTest
 {
     @InjectMockComponents
     private AddressConverter converter;
 
     @Test
-    public void convert() throws Exception
+    void convert() throws Exception
     {
         InternetAddress expected = new InternetAddress("John Doe(comment) <john1@doe.com>");
         assertEquals(expected, this.converter.convert(Address.class, "John Doe(comment) <john1@doe.com>"));

xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/AddressesConverterTest.java

@@ -39,13 +39,13 @@
  * @since 6.1RC1
  */
 @ComponentTest
-public class AddressesConverterTest
+class AddressesConverterTest
 {
     @InjectMockComponents
     private AddressesConverter converter;
 
     @Test
-    public void convert() throws Exception
+    void convert() throws Exception
     {
         InternetAddress[] addresses = new InternetAddress[2];
         addresses[0] = new InternetAddress("John Doe(comment) <john1@doe.com>");
@@ -55,13 +55,13 @@ public void convert() throws Exception
     }
 
     @Test
-    public void convertWhenNull()
+    void convertWhenNull()
     {
         assertNull(this.converter.convert(Address.class, null));
     }
 
     @Test
-    public void convertWhenTypeIsAlreadyAnAddressArray() throws Exception
+    void convertWhenTypeIsAlreadyAnAddressArray() throws Exception
     {
         InternetAddress[] addresses = new InternetAddress[2];
         addresses[0] = new InternetAddress("John Doe(comment) <john1@doe.com>");
@@ -70,7 +70,7 @@ public void convertWhenTypeIsAlreadyAnAddressArray() throws Exception
     }
 
     @Test
-    public void convertWhenInvalid()
+    void convertWhenInvalid()
     {
         Throwable exception = assertThrows(ConversionException.class, () -> {
             this.converter.convert(Address[].class, "invalid(");

xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/DefaultEmailAddressObfuscatorTest.java

@@ -34,7 +34,7 @@
  * @since 12.4RC1
  */
 @ComponentTest
-public class DefaultEmailAddressObfuscatorTest
+class DefaultEmailAddressObfuscatorTest
 {
     @InjectMockComponents
     private DefaultEmailAddressObfuscator obfuscator;

xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/InternetAddressConverterTest.java

@@ -37,13 +37,13 @@
  * @since 12.4RC1
  */
 @ComponentTest
-public class InternetAddressConverterTest
+class InternetAddressConverterTest
 {
     @InjectMockComponents
     private InternetAddressConverter converter;
 
     @Test
-    public void convert() throws Exception
+    void convert() throws Exception
     {
         InternetAddress address = new InternetAddress("John Doe(comment) <john1@doe.com>");
         assertEquals(address, this.converter.convert(InternetAddress.class, "John Doe(comment) <john1@doe.com>"));

xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/configuration/DefaultGeneralMailConfigurationTest.java

@@ -40,7 +40,7 @@
  * @since 12.4RC1
  */
 @ComponentTest
-public class DefaultGeneralMailConfigurationTest
+class DefaultGeneralMailConfigurationTest
 {
     @InjectMockComponents
     private DefaultGeneralMailConfiguration configuration;
@@ -61,14 +61,14 @@ public class DefaultGeneralMailConfigurationTest
     private WikiDescriptorManager wikiDescriptorManager;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         when(this.wikiDescriptorManager.getCurrentWikiId()).thenReturn("mainwiki");
         when(this.wikiDescriptorManager.isMainWiki("mainwiki")).thenReturn(true);
     }
 
     @Test
-    public void shouldObfuscateWhenNotConfigured()
+    void shouldObfuscateWhenNotConfigured()
     {
         // Simulate the default value returned by the call to getProperty() and not the value of the
         // "mail.general.obfuscateEmailAddresses" property which is supposed to be null here...
@@ -77,15 +77,15 @@ public void shouldObfuscateWhenNotConfigured()
     }
 
     @Test
-    public void shouldObfuscateWhenDefinedInXWikiProperties()
+    void shouldObfuscateWhenDefinedInXWikiProperties()
     {
         when(this.xwikiPropertiesSource.getProperty("mail.general.obfuscate", false)).thenReturn(true);
 
         assertTrue(this.configuration.shouldObfuscate());
     }
 
     @Test
-    public void shouldObfuscateFromMailConfigDocumentInMainWiki()
+    void shouldObfuscateFromMailConfigDocumentInMainWiki()
     {
         when(this.currentWikiMailConfigDocumentSource.getProperty("obfuscate", Boolean.class))
             .thenReturn(true);
@@ -94,7 +94,7 @@ public void shouldObfuscateFromMailConfigDocumentInMainWiki()
     }
 
     @Test
-    public void shouldObfuscateFromMailConfigDocumentInSubwikiAndConfigInMainWiki()
+    void shouldObfuscateFromMailConfigDocumentInSubwikiAndConfigInMainWiki()
     {
         when(this.wikiDescriptorManager.getCurrentWikiId()).thenReturn("subwiki");
         when(this.wikiDescriptorManager.isMainWiki("subwiki")).thenReturn(false);

xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/script/GeneralMailScriptServiceTest.java

@@ -39,7 +39,7 @@
  * @since 12.4RC1
  */
 @ComponentTest
-public class GeneralMailScriptServiceTest
+class GeneralMailScriptServiceTest
 {
     @InjectMockComponents
     private GeneralMailScriptService scriptService;

xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/RemoteEventDataTest.java

@@ -28,10 +28,10 @@
  * 
  * @version $Id$
  */
-public class RemoteEventDataTest
+class RemoteEventDataTest
 {
     @Test
-    public void constructor()
+    void constructor()
     {
         RemoteEventData data = new RemoteEventData("event", "source", "data");