[Misc] Remove use of newly deprecated commons-lang3 APIs

Author: manuelleduc

xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/ActiveInstallsInitializerListener.java

@@ -133,7 +133,7 @@ private synchronized void startPingThread()
         // Make sure we always have at least one ping thread.
         if (this.executorService == null) {
             // Start a thread to regularly send pings to the active installs server.
-            BasicThreadFactory factory = new BasicThreadFactory.Builder()
+            BasicThreadFactory factory = BasicThreadFactory.builder()
                 .namingPattern("Active Installs 2 Ping Thread")
                 .daemon(true)
                 .priority(Thread.MIN_PRIORITY)

xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects/src/main/java/org/xwiki/administration/test/po/ThemesAdministrationSectionPage.java

@@ -22,6 +22,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.Strings;
 import org.openqa.selenium.By;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.TimeoutException;
@@ -113,7 +114,7 @@ public void setColorTheme(String colorThemeName)
         getColorThemeOptionElement(colorThemeName).click();
 
         // Waiting to be sure the change is effective
-        getDriver().waitUntilCondition(driver -> StringUtils.equals(getCurrentColorTheme(), colorThemeName));
+        getDriver().waitUntilCondition(driver -> Strings.CS.equals(getCurrentColorTheme(), colorThemeName));
     }
 
     private WebElement getColorThemeOptionElement(String colorThemeName)

xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-rest/src/main/java/org/xwiki/annotation/rest/internal/AbstractAnnotationsRESTResource.java

@@ -29,6 +29,7 @@
 import javax.ws.rs.core.Response.Status;
 
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.xwiki.annotation.AnnotationServiceException;
 import org.xwiki.annotation.rest.model.jaxb.AnnotationAddRequest;
 import org.xwiki.annotation.rest.model.jaxb.AnnotationField;
@@ -76,14 +77,14 @@ protected Response getAnnotatedContent(DocumentReference documentReference)
             AnnotationRequest.Request requestedFields = new AnnotationRequest.Request();
             for (Map.Entry<String, List<String>> entry : parameters.entrySet()) {
                 String name = entry.getKey();
-                if (StringUtils.startsWith(name, ANNOTATION_REQUEST_FILTER_PARAMETER_PREFIX)) {
+                if (Strings.CS.startsWith(name, ANNOTATION_REQUEST_FILTER_PARAMETER_PREFIX)) {
                     for (String value : entry.getValue()) {
                         AnnotationField field = new AnnotationField();
                         field.setName(StringUtils.substringAfter(name, ANNOTATION_REQUEST_FILTER_PARAMETER_PREFIX));
                         field.setValue(value);
                         annotationFields.add(field);
                     }
-                } else if (StringUtils.equals(name, ANNOTATION_REQUEST_REQUESTED_FIELD_PARAMETER)) {
+                } else if (Strings.CS.equals(name, ANNOTATION_REQUEST_REQUESTED_FIELD_PARAMETER)) {
                     requestedFields.getFields().addAll(entry.getValue());
                 }
             }

xwiki-platform-core/xwiki-platform-bridge/src/main/java/org/xwiki/bridge/event/AbstractActionExecutionEvent.java

@@ -21,7 +21,7 @@
 
 import java.io.Serializable;
 
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 
 /**
  * Base class for all action execution related events.
@@ -80,7 +80,7 @@ public int hashCode()
     public boolean equals(Object object)
     {
         if (object != null && getClass().isAssignableFrom(object.getClass())) {
-            return StringUtils.equals(getActionName(), ((ActionExecutionEvent) object).getActionName());
+            return Strings.CS.equals(getActionName(), ((ActionExecutionEvent) object).getActionName());
         }
         return false;
     }

xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-servlet/src/main/java/org/xwiki/container/servlet/filters/internal/SavedRequestRestorerFilter.java

@@ -38,6 +38,7 @@
 import jakarta.servlet.http.HttpSession;
 
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.xwiki.container.servlet.filters.SavedRequestManager;
 import org.xwiki.container.servlet.filters.SavedRequestManager.SavedRequest;
 
@@ -252,7 +253,7 @@ protected SavedRequest getSavedRequest(HttpServletRequest request)
                 SavedRequest savedRequest = savedRequests.get(savedRequestId);
                 // Only reuse this request if the new request is for the same resource (URL)
                 if (savedRequest != null
-                    && StringUtils.equals(savedRequest.getRequestUrl(), request.getRequestURL().toString())) {
+                    && Strings.CS.equals(savedRequest.getRequestUrl(), request.getRequestURL().toString())) {
                     // Remove the saved request from the session
                     savedRequests.remove(savedRequestId);
                     // Return the SavedRequest

xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/main/java/org/xwiki/rendering/internal/macro/dashboard/EditableGadgetRenderer.java

@@ -25,7 +25,7 @@
 import javax.inject.Named;
 import javax.inject.Singleton;
 
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.slf4j.Logger;
 import org.xwiki.component.annotation.Component;
 import org.xwiki.component.manager.ComponentLookupException;
@@ -92,7 +92,7 @@ protected BlockRenderer getGadgetContentRenderer()
 
         // Get the annotated syntax corresponding to the current target syntax
         String annotatedTargetSyntax = currentTargetSyntax.toIdString();
-        if (!StringUtils.startsWith(annotatedTargetSyntax, ANNOTATED_SYNTAXES_PREFIX)) {
+        if (!Strings.CS.startsWith(annotatedTargetSyntax, ANNOTATED_SYNTAXES_PREFIX)) {
             annotatedTargetSyntax = ANNOTATED_SYNTAXES_PREFIX + annotatedTargetSyntax;
         }
 

xwiki-platform-core/xwiki-platform-diff/xwiki-platform-diff-xml/src/main/java/org/xwiki/diff/xml/internal/ImageDownloader.java

@@ -31,6 +31,7 @@
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.io.input.BoundedInputStream;
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.apache.hc.client5.http.classic.methods.HttpGet;
 import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
 import org.apache.hc.client5.http.impl.classic.HttpClientBuilder;
@@ -134,7 +135,7 @@ private DownloadResult handleResponse(URI uri, ClassicHttpResponse response) thr
             String contentType = entity.getContentType();
             contentType = StringUtils.substringBefore(contentType, ";");
 
-            if (!StringUtils.startsWith(contentType, "image/")) {
+            if (!Strings.CS.startsWith(contentType, "image/")) {
                 throw new IOException(String.format("The content of [%s] is not an image.", uri));
             }
 

xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/DefaultRequiredSkinExtensionsRecorder.java

@@ -27,7 +27,7 @@
 import javax.inject.Inject;
 import javax.inject.Provider;
 
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.xwiki.component.annotation.Component;
 import org.xwiki.component.annotation.InstantiationStrategy;
 import org.xwiki.component.descriptor.ComponentInstantiationStrategy;
@@ -70,7 +70,7 @@ public String stop()
         StringBuilder requiredSkinExtensions = new StringBuilder();
         for (Map.Entry<String, String> entry : this.requiredSkinExtensionsMap.entrySet()) {
             requiredSkinExtensions
-                .append(StringUtils.removeStart(getImportString(entry.getKey()), entry.getValue()).trim());
+                .append(Strings.CS.removeStart(getImportString(entry.getKey()), entry.getValue()).trim());
         }
         return requiredSkinExtensions.toString();
     }

xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/DocumentsModifiedDuringDistributionListener.java

@@ -27,7 +27,7 @@
 import javax.inject.Named;
 import javax.inject.Singleton;
 
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.xwiki.bridge.event.DocumentCreatedEvent;
 import org.xwiki.bridge.event.DocumentDeletedEvent;
 import org.xwiki.bridge.event.DocumentUpdatedEvent;
@@ -174,7 +174,7 @@ private void checkXARHandler(Event event, XWikiDocument document)
                 Request request = this.jobContext.getCurrentJob().getRequest();
 
                 // It's a job started by the Distribution Wizard
-                if (StringUtils.equals(request.<String>getProperty("context.action"), "distribution")) {
+                if (Strings.CS.equals(request.<String>getProperty("context.action"), "distribution")) {
                     String distributionWiki = request.getProperty("context.wiki");
 
                     if (distributionWiki != null) {

xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/job/DistributionJobStatus.java

@@ -26,7 +26,7 @@
 import java.util.concurrent.ConcurrentHashMap;
 
 import org.apache.commons.lang3.ObjectUtils;
-import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.Strings;
 import org.xwiki.extension.ExtensionId;
 import org.xwiki.extension.distribution.internal.DistributionManager.DistributionState;
 import org.xwiki.extension.distribution.internal.job.step.DistributionStep;
@@ -105,7 +105,7 @@ public List<DistributionStep> getSteps()
     public DistributionStep getStep(String stepId)
     {
         for (DistributionStep step : getSteps()) {
-            if (StringUtils.equals(step.getId(), stepId)) {
+            if (Strings.CS.equals(step.getId(), stepId)) {
                 return step;
             }
         }